[Bug 14022] New: Subscription form resets 'subscription length' to issues on editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Bug ID: 14022 Summary: Subscription form resets 'subscription length' to issues on editing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com When editing a subscription the subscription length (second page) is reset to issues, even if the subscription was initially saved with a value in months or weeks. This is more of a problem as it sounds even, as a high value in 'issues' can bring created a lot of load on the server with a lot of database requests and causes vry slow response times. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38197&action=edit Bug 14022: Does not reset the subscription length on editing a subscription The subscription length is always set to the first/default value ('issues') when editing a subscription. Even if you selected another value on creating/editing it, the form will show you the first option. Test plan: 1/ Add/Edit a subscription, select a subscription length different of the first value (issues) 2/ Edit the subscription and confirm the value is kept Bonus: issues, week and months become translatable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 38202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38202&action=edit [Signed-off] Bug 14022: Does not reset the subscription length on editing a subscription The subscription length is always set to the first/default value ('issues') when editing a subscription. Even if you selected another value on creating/editing it, the form will show you the first option. Test plan: 1/ Add/Edit a subscription, select a subscription length different of the first value (issues) 2/ Edit the subscription and confirm the value is kept Bonus: issues, week and months become translatable. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #38197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38202|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38209&action=edit [PASSED QA] Bug 14022: Does not reset the subscription length on editing a subscription The subscription length is always set to the first/default value ('issues') when editing a subscription. Even if you selected another value on creating/editing it, the form will show you the first option. Test plan: 1/ Add/Edit a subscription, select a subscription length different of the first value (issues) 2/ Edit the subscription and confirm the value is kept Bonus: issues, week and months become translatable. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13471 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org