[Bug 18687] New: Translatability: abbr tag should not contain lang attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Bug ID: 18687 Summary: Translatability: abbr tag should not contain lang attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In manage-marc-import.tt, we have an abbreviation: <abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr> In translations (e.g. German), the line appears as follows: <abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr> The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63767&action=edit Bug 18687: Translatability: abbr tag should not contain lang attribute In manage-marc-import.tt, we have an abbreviation: <abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr> In translations (e.g. German), the line appears as follows: <abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr> The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. This patch removes it. To test: Verify that code change makes sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 --- Comment #2 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63767|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 65437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65437&action=edit Bug 18687: Translatability: abbr tag should not contain lang attribute In manage-marc-import.tt, we have an abbreviation: <abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr> In translations (e.g. German), the line appears as follows: <abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr> The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. This patch removes it. To test: Verify that code change makes sense. Passes QA test and the change is logical Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65437|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66638&action=edit Bug 18687: Translatability: abbr tag should not contain lang attribute In manage-marc-import.tt, we have an abbreviation: <abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr> In translations (e.g. German), the line appears as follows: <abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr> The lang attribute is wrong here, it is still "en". The text language is the same as defined at the top of the page - or with other words, the lang tag is superfluous. This patch removes it. To test: Verify that code change makes sense. Passes QA test and the change is logical Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org