[Bug 34778] New: Toggle the visibility of the “Show Password"/eye icon in the Login widget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Bug ID: 34778 Summary: Toggle the visibility of the “Show Password"/eye icon in the Login widget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org OPAC: Toggle the visibility of the “Show Password"/eye icon in the Login widget -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Toggle the visibility of |OPAC: Toggle the visibility |the “Show Password"/eye |of the “Show Password"/eye |icon in the Login widget |icon in the Login widget -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC: Toggle the visibility |OPAC: Toggle the visibility |of the “Show Password"/eye |of the Show Password/eye |icon in the Login widget |icon in the Login widget -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Summary|OPAC: Toggle the visibility |Add a 'Show password'/eye |of the Show Password/eye |icon to toggle visibility |icon in the Login widget |of password when logging in --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I'm going to re-word this title, as I don't think it's quite accurate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- This is an interesting one. While the eye icon is familiar from my memory, it looks like a lot of major sites use "<checkbox> Show password" instead underneath the password box. I'd be inclined to follow that usage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24949 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a 'Show password'/eye |Add a 'Show password'/eye |icon to toggle visibility |icon to toggle visibility |of password when logging in |of password when logging | |into OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I've done a little version of this for OPACUserJS. It'll need a little tweak or two for the community I suspect, but hoping to post a patch later today... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|amitddng135@gmail.com |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 173115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173115&action=edit Bug 34778: Add a 'Show password' toggle when logging into the OPAC 1. Apply the patch 2. perl build-resources.PL 3. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 4. Type "ABC" into the "Password" box and click "Show password" 5. Note that the password is now visible. Click again to hide password. 6. Click "Log in to your account" 7. Type "123" into the "Password" box and click "Show password" 8. Note that the password is now visible. Click again to hide password. 9. Note that the password on the main screen wasn't affected by the "Show password" in the modal 10. Repeat the above process on http://localhost:8080/cgi-bin/koha/opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173115|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 173310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173310&action=edit Bug 34778: Add a 'Show password' toggle when logging into the OPAC 1. Apply the patch 2. perl build-resources.PL 3. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 4. Type "ABC" into the "Password" box and click "Show password" 5. Note that the password is now visible. Click again to hide password. 6. Click "Log in to your account" 7. Type "123" into the "Password" box and click "Show password" 8. Note that the password is now visible. Click again to hide password. 9. Note that the password on the main screen wasn't affected by the "Show password" in the modal 10. Repeat the above process on http://localhost:8080/cgi-bin/koha/opac-user.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- "Show password" need to be a label for the checkbox, so that when you click on the label you can easily toggle the checkbox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #6)
"Show password" need to be a label for the checkbox, so that when you click on the label you can easily toggle the checkbox.
Ah touché. I remember thinking about that, and then probably went with span to ease the styling when implementing this feature just via OpacUserJS. Will revisit this one... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Created attachment 174442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174442&action=edit Bug 34778: (follow-up) convert label from 'span' to 'label' element Also uses the "for" attribute to uniquely point to the correct checkbox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Emmanuel Bétemps <e.betemps@gmail.com> --- CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Emmanuel Bétemps from comment #9)
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
Thanks Emmanuel. Uploading a rebased version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173310|0 |1 is obsolete| | --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Created attachment 176485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176485&action=edit Bug 34778: Add a 'Show password' toggle when logging into the OPAC 1. Apply the patch 2. perl build-resources.PL 3. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 4. Type "ABC" into the "Password" box and click "Show password" 5. Note that the password is now visible. Click again to hide password. 6. Click "Log in to your account" 7. Type "123" into the "Password" box and click "Show password" 8. Note that the password is now visible. Click again to hide password. 9. Note that the password on the main screen wasn't affected by the "Show password" in the modal 10. Repeat the above process on http://localhost:8080/cgi-bin/koha/opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174442|0 |1 is obsolete| | --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 176486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176486&action=edit Bug 34778: (follow-up) convert label from 'span' to 'label' element Also uses the "for" attribute to uniquely point to the correct checkbox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176485|0 |1 is obsolete| | --- Comment #13 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176501&action=edit Bug 34778: Add a 'Show password' toggle when logging into the OPAC 1. Apply the patch 2. perl build-resources.PL 3. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 4. Type "ABC" into the "Password" box and click "Show password" 5. Note that the password is now visible. Click again to hide password. 6. Click "Log in to your account" 7. Type "123" into the "Password" box and click "Show password" 8. Note that the password is now visible. Click again to hide password. 9. Note that the password on the main screen wasn't affected by the "Show password" in the modal 10. Repeat the above process on http://localhost:8080/cgi-bin/koha/opac-user.pl Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176486|0 |1 is obsolete| | --- Comment #14 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176502&action=edit Bug 34778: (follow-up) convert label from 'span' to 'label' element Also uses the "for" attribute to uniquely point to the correct checkbox. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, each step of the test plan is ok (please, note I tested on a sandbox) one thing (which wasn't asked) I looked at is 'What if I want to change my password ?' -> there is no 'show my password' option Could it be useful to work on that ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #16 from Emmanuel Bétemps <e.betemps@gmail.com> --- Perhaps Opac self-registration could also include this option 'show my password' when the account is created. The syspref is PatronSelfRegistration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Emmanuel Bétemps from comment #16)
Perhaps Opac self-registration could also include this option 'show my password' when the account is created. The syspref is PatronSelfRegistration.
We though of this because someone when creating their bugzilla account good locked out due to a password mistake. ^^" And Bugzilla doesn't have the feature proposed here for Koha. But it turns out the proposal here wouldn't have prevented the scenario that happened with bugzilla. Note *if* self registration is too different it might risk stalling this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176501|0 |1 is obsolete| | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176505&action=edit Bug 34778: Add a 'Show password' toggle when logging into the OPAC 1. Apply the patch 2. perl build-resources.PL 3. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 4. Type "ABC" into the "Password" box and click "Show password" 5. Note that the password is now visible. Click again to hide password. 6. Click "Log in to your account" 7. Type "123" into the "Password" box and click "Show password" 8. Note that the password is now visible. Click again to hide password. 9. Note that the password on the main screen wasn't affected by the "Show password" in the modal 10. Repeat the above process on http://localhost:8080/cgi-bin/koha/opac-user.pl Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176502|0 |1 is obsolete| | --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176506&action=edit Bug 34778: (follow-up) convert label from 'span' to 'label' element Also uses the "for" attribute to uniquely point to the correct checkbox. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Auth is well covered by selenium tests. It should be easy and could be useful to have a couple of tests to cover this change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176703&action=edit Bug 34778: Add a selenium test prove -v t/db_dependent/selenium/authentication.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176904&action=edit Bug 34778: Remove extra 'bootstrap' when loading the js asset Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176905&action=edit Bug 34778: Remove the include file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- What about this last patch? It feels better to not rely on an additional include file when it can be done using JS easily. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Also it would have been good to apply this to all password fields we have in Koha, not only the login screens at the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176505|0 |1 is obsolete| | --- Comment #26 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176907&action=edit Bug 34778: Add a 'Show password' toggle when logging into the OPAC 1. Apply the patch 2. perl build-resources.PL 3. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 4. Type "ABC" into the "Password" box and click "Show password" 5. Note that the password is now visible. Click again to hide password. 6. Click "Log in to your account" 7. Type "123" into the "Password" box and click "Show password" 8. Note that the password is now visible. Click again to hide password. 9. Note that the password on the main screen wasn't affected by the "Show password" in the modal 10. Repeat the above process on http://localhost:8080/cgi-bin/koha/opac-user.pl Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176506|0 |1 is obsolete| | --- Comment #27 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176908&action=edit Bug 34778: (follow-up) convert label from 'span' to 'label' element Also uses the "for" attribute to uniquely point to the correct checkbox. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176703|0 |1 is obsolete| | --- Comment #28 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176909&action=edit Bug 34778: Add a selenium test prove -v t/db_dependent/selenium/authentication.t Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176904|0 |1 is obsolete| | --- Comment #29 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176910&action=edit Bug 34778: Remove extra 'bootstrap' when loading the js asset Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176905|0 |1 is obsolete| | --- Comment #30 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176911&action=edit Bug 34778: Remove the include file Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #24)
What about this last patch? It feels better to not rely on an additional include file when it can be done using JS easily.
David, if you agree with this change please set to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #32 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #24)
What about this last patch? It feels better to not rely on an additional include file when it can be done using JS easily.
Sounds good to me. I like how you've written the JS there. (In reply to Jonathan Druart from comment #31)
(In reply to Jonathan Druart from comment #24)
What about this last patch? It feels better to not rely on an additional include file when it can be done using JS easily.
David, if you agree with this change please set to PQA.
I don't know that I agree that the change was needed, but I've just tested and it works, so happy to PQA it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #25)
Also it would have been good to apply this to all password fields we have in Koha, not only the login screens at the OPAC.
We've still got time to do that. What other screens do you have in mind for the OPAC? /cgi-bin/koha/opac-memberentry.pl is the only one that springs to mind at the moment for me, but I imagine there could be others. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from David Cook <dcook@prosentient.com.au> --- Actually, it looks like the selenium test is failing now, so got to FQA it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177272&action=edit Bug 34778: (follow-up) Remove the include file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176907|0 |1 is obsolete| | --- Comment #36 from David Cook <dcook@prosentient.com.au> --- Created attachment 177300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177300&action=edit Bug 34778: Add a 'Show password' toggle when logging into the OPAC 1. Apply the patch 2. perl build-resources.PL 3. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 4. Type "ABC" into the "Password" box and click "Show password" 5. Note that the password is now visible. Click again to hide password. 6. Click "Log in to your account" 7. Type "123" into the "Password" box and click "Show password" 8. Note that the password is now visible. Click again to hide password. 9. Note that the password on the main screen wasn't affected by the "Show password" in the modal 10. Repeat the above process on http://localhost:8080/cgi-bin/koha/opac-user.pl Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176908|0 |1 is obsolete| | --- Comment #37 from David Cook <dcook@prosentient.com.au> --- Created attachment 177301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177301&action=edit Bug 34778: (follow-up) convert label from 'span' to 'label' element Also uses the "for" attribute to uniquely point to the correct checkbox. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176909|0 |1 is obsolete| | --- Comment #38 from David Cook <dcook@prosentient.com.au> --- Created attachment 177302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177302&action=edit Bug 34778: Add a selenium test prove -v t/db_dependent/selenium/authentication.t Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176910|0 |1 is obsolete| | --- Comment #39 from David Cook <dcook@prosentient.com.au> --- Created attachment 177303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177303&action=edit Bug 34778: Remove extra 'bootstrap' when loading the js asset Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176911|0 |1 is obsolete| | --- Comment #40 from David Cook <dcook@prosentient.com.au> --- Created attachment 177304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177304&action=edit Bug 34778: Remove the include file Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177272|0 |1 is obsolete| | --- Comment #41 from David Cook <dcook@prosentient.com.au> --- Created attachment 177305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177305&action=edit Bug 34778: (follow-up) Remove the include file Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucas@bywatersolutions.com |dcook@prosentient.com.au Assignee|dcook@prosentient.com.au |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed, | |release-notes-needed --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would love to see bug 24949 also in my queue for 25.05... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a 'Show password'/eye |Add a 'Show password' link |icon to toggle visibility |to toggle visibility of |of password when logging |password when logging into |into OPAC |OPAC Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |link to reveal the password | |a user is typing into the | |OPAC login interface. CC| |lisette@bywatersolutions.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a |This enhancement adds a release notes|link to reveal the password |link to the OPAC login form |a user is typing into the |so a user can reveal their |OPAC login interface. |password as they type it | |in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a |This enhancement adds a release notes|link to the OPAC login form |link to the OPAC login form |so a user can reveal their |so a user can reveal their |password as they type it |password before submitting |in. |the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34778 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #44 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org