[Bug 26288] New: Update the Select2 JS lib to version 4.1.0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Bug ID: 26288 Summary: Update the Select2 JS lib to version 4.1.0 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Bug 25727 updated Select2 to the latest stable release (4.0.13). We found some glitches about the width (see bug 25727 comment 19 for instance). It seems that the next 4.1 is going to fix it, but still beta. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108988&action=edit Bug 26288: Update Select2 to 4.1.0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not ready for integration but it is ready for testing if we want to be prepared when 4.1.0 is released -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://snipboard.io/NznYxe.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we are still using Select2 4.0.13. and the 4.1.0 release candidate is from 2021? https://github.com/select2/select2/releases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #4)
It looks like we are still using Select2 4.0.13. and the 4.1.0 release candidate is from 2021? https://github.com/select2/select2/releases
Looks like the maintainer of the project is not clear about the next release - https://github.com/select2/select2/pull/6044 Other alternatives are suggested "TomSelect". But let's wait some more months and see how it goes... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tom Select - https://github.com/orchidjs/tom-select/ Last commit on Dec 16, 2022 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Summary|Update the Select2 JS lib |Update the Select2 JS lib |to version 4.1.0 |to latest version --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Select2 4.1.0 was released May 2026 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 206432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206432&action=edit Bug 26288: Update the Select2 JS lib to 4.1.0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- This is the full.min.js version from the 4.1.0 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Test plan: Confirm that the select elements using Select2 are still working correctly. Select, multiselect (in sysprefs), clear button. There is also the vendor list in the ERM module that should be tested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38310 [Bug 38310] DataTables - Use Select2 for column filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #10)
Test plan: Confirm that the select elements using Select2 are still working correctly. Select, multiselect (in sysprefs), clear button. There is also the vendor list in the ERM module that should be tested.
multiple selects are actually not handled by select2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 206638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206638&action=edit Bug 26288: Update the Select2 JS lib to 4.1.0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #13 from Brendan Lawlor <blawlor@clamsnet.org> --- I tested this with a multiselect report parameter and in the item search. Both worked, but in item search there appears to be a little css issue where the cursor in the field is not aligned with the little pills of the options that you select. (It's slightly higher than the selections that you make. The inputs are a little taller than the drop downs to select 'is' or 'is not' too) I also tried to test this with bug 38310 using Item search. It looked like the column filters had select2 but I wasn't able to select multiple values. Whenever I tried to select a second value it lost the first one. I tried yarn js:build and reset_all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 206797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206797&action=edit Bug 26288: Update the Select2 JS lib to 4.1.0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 206798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206798&action=edit Bug 26288: (follow-up) Fix multiple select2 layout with Select2 4.1.0 Select2 4.1.0 renders the inline search field as a textarea. It was using its default height, making multiple selects taller than the other fields, and the typed text and the clear button were not aligned with the selected items. Add the 4.1.0 layout rules for multiple selections to Koha's select2.css and adjust the spacing so the field has the same height as the select next to it. Test plan: 1. Go to Catalog > Item search 2. Select several libraries in "Home library" and type some text => The field has the same height as the "is" select on its left => The selected items, the typed text and the clear button are vertically aligned Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Brendan Lawlor from comment #13)
I tested this with a multiselect report parameter and in the item search. Both worked, but in item search there appears to be a little css issue where the cursor in the field is not aligned with the little pills of the options that you select. (It's slightly higher than the selections that you make. The inputs are a little taller than the drop downs to select 'is' or 'is not' too)
LLM managed to fix that for me, it seems.
I also tried to test this with bug 38310 using Item search. It looked like the column filters had select2 but I wasn't able to select multiple values. Whenever I tried to select a second value it lost the first one. I tried yarn js:build and reset_all.
Can you recreate this problem consistently? I did see that yesterday when working on bug 38310, but I cannot recreate it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206797|0 |1 is obsolete| | Attachment #206798|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206802&action=edit Bug 26288: Update the Select2 JS lib to 4.1.0 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206803&action=edit Bug 26288: (follow-up) Fix multiple select2 layout with Select2 4.1.0 Select2 4.1.0 renders the inline search field as a textarea. It was using its default height, making multiple selects taller than the other fields, and the typed text and the clear button were not aligned with the selected items. Add the 4.1.0 layout rules for multiple selections to Koha's select2.css and adjust the spacing so the field has the same height as the select next to it. Test plan: 1. Go to Catalog > Item search 2. Select several libraries in "Home library" and type some text => The field has the same height as the "is" select on its left => The selected items, the typed text and the clear button are vertically aligned Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org