[Bug 13350] New: Untranslatable strings in aqbudgetperiods.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Bug ID: 13350 Summary: Untranslatable strings in aqbudgetperiods.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org CC: bgkriegel@gmail.com, frederic@tamil.fr, tomascohen@gmail.com A few strings in aqbudgetperiods.tt are untranslatable like Duplicate budget:245, closed:257, and Budgets administration:262. If you review the po file for staff, you will notice that these strings aren't include. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 36003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36003&action=edit Bug 13350 - Untranslatable strings in aqbudgetperiods.tt This patch fix a few untranslatable strings in aqbudgetperiods.tt. Style not pretty but work. The section modified is BREADCRUMBS. This patch adds html tags to be recognized by misc/translator/translate script. Test plan --------------- 1) Use another language (not English) 2) Go to More > Administration > Budgets. Notice that "> Budgets administration" is untranslatable in the Navigation section. 3) Try to create a New budget. Notice the same happens as previous step. 4) Try delete, edit, duplicate, and close a budget. The result is the same. 5) Apply the patch. 6) Run perl translate update xx-XX (in my case es-ES) 7) Edit es-ES-i-staff-t-prog-v-3006000.po 8) Get notice that a new lines has been adhered to po file. 9) Run perl translate install es-ES 10) Go to Global system preferences and search for "language" in I18N/L10N preferences. Enable Español(es-ES). 11) Follow step 2 and 3 and notice that the strings were translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36003|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 36004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36004&action=edit Bug 13350 - Untranslatable strings in aqbudgetperiods.tt This patch fix a few untranslatable strings in aqbudgetperiods.tt. Style not pretty but work. The section modified is BREADCRUMBS. This patch adds html tags to be recognized by misc/translator/translate script. Test plan --------------- 1) Use another language (not English) 2) Go to More > Administration > Budgets. Notice that "> Budgets administration" is untranslatable in the Navigation section. 3) Try to create a New budget. Notice the same happens as previous step. 4) Try delete, edit, duplicate, and close a budget. The result is the same. 5) Apply the patch. 6) Run perl translate update xx-XX (in my case es-ES) 7) Edit es-ES-i-staff-t-prog-v-3006000.po 8) Get notice that a new lines has been adhered to po file. 9) Run perl translate install es-ES 10) Go to Global system preferences and search for "language" in I18N/L10N preferences. Enable Español(es-ES). 11) Follow step 2 and 3 and notice that the strings were translated. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 36407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36407&action=edit [Signed-off] Bug 13350 - Untranslatable strings in aqbudgetperiods.tt This patch fix a few untranslatable strings in aqbudgetperiods.tt. Style not pretty but work. The section modified is BREADCRUMBS. This patch adds html tags to be recognized by misc/translator/translate script. Test plan --------------- 1) Use another language (not English) 2) Go to More > Administration > Budgets. Notice that "> Budgets administration" is untranslatable in the Navigation section. 3) Try to create a New budget. Notice the same happens as previous step. 4) Try delete, edit, duplicate, and close a budget. The result is the same. 5) Apply the patch. 6) Run perl translate update xx-XX (in my case es-ES) 7) Edit es-ES-i-staff-t-prog-v-3006000.po 8) Get notice that a new lines has been adhered to po file. 9) Run perl translate install es-ES 10) Go to Global system preferences and search for "language" in I18N/L10N preferences. Enable Español(es-ES). 11) Follow step 2 and 3 and notice that the strings were translated. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #36004|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 36407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36407 [Signed-off] Bug 13350 - Untranslatable strings in aqbudgetperiods.tt Review of attachment 36407: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13350&attachment=36407) ----------------------------------------------------------------- Hi Héctor, I think something strange is going on here and I would like to avoid changing how the bradcrumbs display the last bit - could you take another look? Also adding Bernardo, maybe he has some ideas. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt @@ +238,2 @@
[% ELSE %] + Delete budget <i>'[% budget_period_description %]'?</i>
I am not sure why the ' would cause the strings to be not translatable, but probably easisest would be to just remove them and maybe also the <i>? Thinking about how this looks like in other places in Koha. @@ +240,5 @@
[% END %] [% END %] <!-- duplicate a budget --> [% IF ( duplicate_form ) %] + <a href="/cgi-bin/koha/admin/aqbudgetperiods.pl">Budgets</a> › <strong>Duplicate budget</strong>
I think we shouldn't use strong here, as the current page is not highlighted like that on the other pages. I think a <span> should do the trick without an optical change, but it would be a little better to see why these pages don't get translated, while other pages work correctly and adjust the code to look the same (hope I make sense). @@ +257,5 @@
[% END %] <!-- display budget periods list --> <!-- ########################################## --> [% IF ( else ) %] + <strong>Budgets administration</strong>
Same here as above - there are a lot of strange looking comments on this site. Hm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Katrine I've used strong tag on example basis. If you go to Patrons and then create a New patron (e.g. Staff), this will display "Add patron (Staff)" in bold type. So, this kind of code has been used in memberentrygen.tt I will try to test another solution or if Bernardo can help, he has got more experiences with untranslatables strings. Regards -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- I'm looking into this right now :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Can't said that I found the problem, but a solution. Removing comments on breadcrumb code does the job, e.g. - <!-- delete a budget period --> - <!-- ################################ --> With only that the text is now picked up by translation script. But new strings are not good, some phrases are split and then difficult to translate. So I propose a counter patch, putting <span>...</span> on each string. With that, updating and installing es-ES gives a correct result, no need to translate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36634&action=edit Bug 13350: Untranslatable strings in aqbudgetperiods.tt Counter patch, same test plan as original -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- I think this need a sign, or an opinion :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 36639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36639&action=edit [Signed-off] Bug 13350: Untranslatable strings in aqbudgetperiods.tt Counter patch, same test plan as original Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36634|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36407|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36639|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36772&action=edit Bug 13350: Untranslatable strings in aqbudgetperiods.tt Counter patch, same test plan as original Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! We are getting closer! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org