http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351 --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to paxed from comment #1) See Coding Guidelines at <http://wiki.koha-community.org/wiki/Coding_Guidelines#JS2:_Enabling_translation_of_language_strings_in_embedded_JavaScript> in JS2 Section. Maybe need to be wrapped to the special funciton _().

The file name is koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt

The whole update_searched() javascript function should be redone with i18n in mind - using format() and %s placeholders instead of concatenating strings.

-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | --- Comment #3 from Marc Véron <veron@veron.ch> --- To reproduce: Go to Home > Patrons (cgi-bin/koha/members/members-home.pl) - Switch language e.g. to German - Use filter and fill all fields You get a result like: Treffer gefunden for patron on standard fields beginnend mit Nepomuk mit Kategorie Erwachsener in der Bibliothek Allschwil Hmm, English version looks weird too: Results found for patron on borrower number fields starting with 1 with category Staff in library Fairview Something like the following would look better and would be better to translate: Patrons found for: Standard containing 'A' with category 'Adult' in library Airfield -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36427|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36579&action=edit [PASSED QA] Bug 13351 - Untranslatable javascript in members.tt This patch streamlines the page title text for search results in Home > Patrons to make it translateable (and more readable). To test: - Apply patch - Select Englsh language - Apply filter wit several values or click on a letter for "Browse by last name" - Verify that the title makes sense - Translate to your language and select this language - Verify that the text appears properly in your language Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. http://bugs.koha-community.org/show_bug.cgi?id=13352 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.