[Bug 22922] New: Allow to modify hold dates on reserve/request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Bug ID: 22922 Summary: Allow to modify hold dates on reserve/request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 89824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89824&action=edit Bug 22922: Allow to modify hold dates on reserve/request.pl Test plan: 1. Place some holds 2. Go to the 'Holds' tab of the biblio record 3. Modify dates in the table and click on 'Update holds' button 4. Verify that dates have been correctly updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What is the use case for changing the date the hold was placed? (allowing them to be in the future? And should this not depend on the syspref then?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #2)
What is the use case for changing the date the hold was placed? (allowing them to be in the future? And should this not depend on the syspref then?)
I'm not sure what the use case is if you're *not* changing a hold date to/from a future date, but I think that's good enough reason to have the ability. Tying the operation to AllowHoldDateInFuture sounds right to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Thanks for the feedback. I will write a followup soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 89896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89896&action=edit Bug 22922: Allow reservedate changes only if AllowHoldDateInFuture is on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I realize that there is no aspect of the date selection process which requires specific features of the jQuery datepicker, but I think it should be used for consistency's sake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 89902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89902&action=edit Bug 22922: Use jQuery datepicker instead of <input type="date"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89824|0 |1 is obsolete| | --- Comment #8 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 89915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89915&action=edit Bug 22922: Allow to modify hold dates on reserve/request.pl Test plan: 1. Place some holds 2. Go to the 'Holds' tab of the biblio record 3. Modify dates in the table and click on 'Update holds' button 4. Verify that dates have been correctly updated Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89896|0 |1 is obsolete| | --- Comment #9 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 89916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89916&action=edit Bug 22922: Allow reservedate changes only if AllowHoldDateInFuture is on Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89902|0 |1 is obsolete| | --- Comment #10 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 89917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89917&action=edit Bug 22922: Use jQuery datepicker instead of <input type="date"> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow to modify hold dates |Allow to modify hold and |on reserve/request.pl |hold expiration date in | |staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch does a bit more than I thought - apart from changing the hold date, it also allows to change the expiration date. I think while the first should be controlled by the AllowHoldDateInFuture, the expiration date should not as it's already available to be set in the table now. Note: the expiration date has a double use, it's used to say: - Patron: I don't need this after... and also: - Library: Hold needs to picked up until ... Can you please change? I am not sure about the consequences of this change. I think the date pickers are a bit too wide in the table. Adding Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #11)
I think the date pickers are a bit too wide in the table. Adding Owen.
I usually give date input fields a size attribute of 10 on the assumption that is the maximum likely number of characters in a date: 0000-00-00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We only need a syspref check and some cosmetics here... please fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #13)
We only need a syspref check and some cosmetics here... please fix!
Which syspref and where ? attachment 89916 already checks AllowHoldDateInFuture -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Seeing the pref check now... maybe it was only the width of the inputs missing then? (see comment#12) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94372&action=edit Bug 22922: (follow-up) Markup corrections This patch adds a "size" attribute to the datepicker input fields and adds self-closing "/". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89915|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94383&action=edit Bug 22922: Allow to modify hold dates on reserve/request.pl Test plan: 1. Place some holds 2. Go to the 'Holds' tab of the biblio record 3. Modify dates in the table and click on 'Update holds' button 4. Verify that dates have been correctly updated Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89916|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94384&action=edit Bug 22922: Allow reservedate changes only if AllowHoldDateInFuture is on Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89917|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94385&action=edit Bug 22922: Use jQuery datepicker instead of <input type="date"> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94372|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94386&action=edit Bug 22922: (follow-up) Markup corrections This patch adds a "size" attribute to the datepicker input fields and adds self-closing "/". Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a rather small change, so I don't want to block it any longer. Just 2 things: - There are no unit tests for the changes in Reserve.pm - I am not sure all libraries will be happy about people being able to move the pick-up date, as there is also a fine penalty in some for not picking up your holds, but for the same reason: others will like it. If you get a call that someone needs some extra time, you can do that now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org