https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com, | |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Serhij, can you please try to make a valid git patch file? You can use the git format-patch command or tCan you detail the problem a bit more? I am not sure why the mapping should be a problem.he git bz tool described in our wiki. Maybe the by should still be wrapped in a class? That way we could hide the whole line still without the by remaining. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 --- Comment #3 from Serhij Dubyk <dubyk@ukr.net> --- Before this patch in file en-GB-marc-MARC21.po present next paragraph: #: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457 #, fuzzy, c-format msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed the following command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: #: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:348 #: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457 #, fuzzy, c-format msgid "by " msgstr " by " And the string " by " becomes available for translation in uk-UA/xslt/MARC21slim2intranetResults.xsl (and other language versions) This can be checked the command sudo koha-translate --update uk-UA In the file uk-UA/xslt/MARC21slim2intranetResults.xsl string 'by <p class = "author">' is now translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Serhij, the patch looks good now, but I have one concern: The class=author was added to make it possible for libraries to hide the information if they want to. That's why the 'by' was inside. Can we find a way that fixes both needs? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Serhij, thx for investigating! I have signed off on your patch with some little changes: - The subject should always start with "Bug xxxx" as this helps our tools to recognize what the patch is for and is used to link all the things together. - The patch commit message should contain a short description of the problem and the test plan (just copied your test plan in) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66345|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66510&action=edit Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl Signed-off-by: Serhij Dubyk {Сергій Дубик} <serhijdubyk@gmail.com> The "by" after the title was not translatable in the result lists of the intranet. This patch fixes it by removing a comment, that caused a problem with the translation scripts. To test: Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: msgid "by " msgstr " by " https://bugs.koha-community.org/show_bug.cgi?id=17827 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66510|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66687&action=edit Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl Signed-off-by: Serhij Dubyk {Сергій Дубик} <serhijdubyk@gmail.com> The "by" after the title was not translatable in the result lists of the intranet. This patch fixes it by removing a comment, that caused a problem with the translation scripts. To test: Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: msgid "by " msgstr " by " https://bugs.koha-community.org/show_bug.cgi?id=17827 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes.