[Bug 18778] New: Translatability: Get rid of tt directive in translation for item-status.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 Bug ID: 18778 Summary: Translatability: Get rid of tt directive in translation for item-status.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 64189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64189&action=edit Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " This patch fixes new lines inside a tt directive (comment). It is merely a string patch. To test: Verify that the code changes make sense. (Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64189|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64736&action=edit [SIGNED-OFF] Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " This patch fixes new lines inside a tt directive (comment). It is merely a string patch. To test: Verify that the code changes make sense. (Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po) NOTE: Followed test plan similar to bug 18776 comment 3. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64736|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66645&action=edit Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " This patch fixes new lines inside a tt directive (comment). It is merely a string patch. To test: Verify that the code changes make sense. (Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po) NOTE: Followed test plan similar to bug 18776 comment 3. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18778 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.17 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org