https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 [Bug 34468] Add a progress callback to job_progress.js -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Bug 34788 depends on bug 34468, which changed state. Bug 34468 Summary: Add a progress callback to job_progress.js https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Hi Sonia, There is a solution ready which is in testing with one of our customers. When I get a chance I'll upload it to the bug for you to test as well. The more feedback the better! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161380&action=edit Bug 34788: Add Vue components, api client and navigation route This patch adds a new component to handle the file import, a route to that component and the API client route needed to access the API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161382&action=edit Bug 34788: Add unit test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161384&action=edit Bug 34788: Allow for import of CSV files This commit allows CSV files to be imported alongside TSV files. It also adds some performance improvements relating to the max_allowed_packet and the matching of titles, as well as some small bugfixes and unit test changes Test plan: 1) Enable the ERM module 2) Navigate to E-resource management > eHoldings > Local > Packages 3) Create at least one package 4) Navigate to E-resource management > eHoldings > Local > Titles 5) There should be a button for "Import from KBART file" 6) Click this button 7) Select the package that you created from the dropdown and then choose your KBART file using the "Choose file" button 8) Click Submit 9) If your file is a valid file, a background job will be queued, if not then a warning will display showing what is incorrect in your file 10) To test the file format warning, edit your file and add a random column heading into the file e.g. test_column. When you upload it, the warning should show that an invalid column "test_column" has been detected 11) Click on the background job. (If you have uploaded a very large file, the system will chunk the file into smaller pieces and create multiple background jobs) 12) It should display a progress bar followed by a report and any error messages 13) Navigate to E-resource management > eHoldings > Local > Titles and you should see your new titles. 14) Run the unit test: prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #11 from Jonathan Field <jonathan.field@ptfs-europe.com> --- Hi Lucas, Springer provide their KBART files in the public domain. You could take a few of these to use as sample files. I'll leave Matt to answer the other point! https://adminportal.springernature.com/metadata/kbart Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #13 from Mathieu Saby <mathsabypro@gmail.com> --- For your information, the KBART files used in France and available from https://bacon.abes.fr/exporter.html have an extra field "ppn" after the mandatory KBART fields (it is permitted, as per the specification : "In order to supply additional information for other purposes not required by the KBART Recommended Practice, content providers are permitted to include any extra data fields after the last KBART utilized position (access_type in position 25)." An other import source is https://gokb.org/ , whitch adds 3 fields : zdb_id, gokb_tipp_uid, gokb_title_uid It could be interesting to test how Koha behaves with those kind of "enhanced" Kbart Files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 165189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165189&action=edit Example TSV file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161379|0 |1 is obsolete| | --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 165191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165191&action=edit Bug 34788: Add an API endpoint to import a KBART file This patch adds the endpoint needed to queue an import_from_kbart_file background job -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161381|0 |1 is obsolete| | --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 165193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165193&action=edit Bug 34788: Add a background job to import a KBART file This patch adds a background job that will import a KBART file Sponsored-by: UKHSA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161383|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 165195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165195&action=edit Bug 34788: Add a relationship to a package for the imported file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 165197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165197&action=edit Bug 34788: Make biblio creation optional This patch rebases in the changes from bug 36618 to make biblio creation optional -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Maude <maude.boudreau@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maude.boudreau@collecto.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- It will return the warning before the job is queued so no columns will be imported at that stage. Once the file is edited to remove the columns it can then be re-imported and the job will be queued -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think I like that suggestion, warn that those fields will be dropped, but continue with the import. We could later add a general 'other fields' catch somewhere to allow importing those too, but I'm not sure how they'd actually ever get surfaced/used.. they could be anything so it'll be difficult to use them in standard reports. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Mathieu Saby from comment #27)

Well, I am not your sponsor but as an average librarian I can say that it not the most effective workflow : when we librarians download valid kbart files from gokb or other sources, we usually wont want to edit the file to remove columns that are not defined in kbart specs. If all mandatory fields are in the file, won't it be possible to import the file with a "simple" warning telling the user that the other (non mandatory) fields were discarded?

+10 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe adding custom fields at the end is actually according to the standard. I found this in a quick search: https://www.niso.org/standards-committees/kbart/kbart-content-providers Links to Style Guide: https://docs.google.com/document/d/1jF154euh8s_RWKX0Tb0ci1W_gzziYKd5ayy5Srjy... On last page: Extra Fields This data field is applicable to serials and monographs. If it is desired to transmit additional identifiers, they may be included as extra data in fields after the last KBART utilized position, (access_type in position 25). Multiple values should be delimited using a semi-colon. As we can't do anything with those right now, but it might be a lot of work for libraries (and error prone) to manually edit the files, I think Mathieu's suggestion would be perfect for now. Make them aware we are not importing these, while still allowing to continue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 165837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165837&action=edit Bug 34788: Allow import of file with additional columns This patch allows a file with additional columns to be imported. When the file is submitted, the system will enqueue the background job and send back information to the UI that certain columns have been ignored. The data will stil l import as normal but only the standard KBART columns will be parsed and imported -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've not given up on this one yet, if you can make me believe it's unlikely to have bad side effects :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 [Bug 36618] Make biblio creation optional for ERM local titles -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #39 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 165888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165888&action=edit Bug 34788: Add Vue components, api client and navigation route This patch adds a new component to handle the file import, a route to that component and the API client route needed to access the API Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #41 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 165890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165890&action=edit Bug 34788: Add unit test Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #43 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 165892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165892&action=edit Bug 34788: Allow for import of CSV files This commit allows CSV files to be imported alongside TSV files. It also adds some performance improvements relating to the max_allowed_packet and the matching of titles, as well as some small bugfixes and unit test changes Test plan: 1) Enable the ERM module 2) Navigate to E-resource management > eHoldings > Local > Packages 3) Create at least one package 4) Navigate to E-resource management > eHoldings > Local > Titles 5) There should be a button for "Import from KBART file" 6) Click this button 7) Select the package that you created from the dropdown and then choose your KBART file using the "Choose file" button. I have attached some example files to the bug but feel free to use your own if you have them. 8) Click Submit 9) If your file is a valid file, a background job will be queued, if not then a warning will display showing what is incorrect in your file 10) To test the file format warning, edit your file and add a random column heading into the file e.g. test_column. When you upload it, the warning should show that an invalid column "test_column" has been detected 11) Click on the background job. (If you have uploaded a very large file, the system will chunk the file into smaller pieces and create multiple background jobs) 12) It should display a progress bar followed by a report and any error messages 13) Navigate to E-resource management > eHoldings > Local > Titles and you should see your new titles. 14) Run the unit test: prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #45 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 165894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165894&action=edit Bug 34788: Allow import of file with additional columns This patch allows a file with additional columns to be imported. When the file is submitted, the system will enqueue the background job and send back information to the UI that certain columns have been ignored. The data will stil l import as normal but only the standard KBART columns will be parsed and imported Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #48 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 166420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166420&action=edit Bug 34788: (QA follow-up) This patch fixes a few things: 1) The blue dialog box now clears when navigating away from the page 2) The background job now uses skip_record_index to avoid queuing indexing jobs for every new biblio and instead queues one job at the end 3) Large files that get chunked now successfully create linked biblios if requested 4) Title matching rules have been expanded to check the package ID so that we can have duplicate titles in different packages 5) A link to the package is now included on the job report page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165888|0 |1 is obsolete| | --- Comment #51 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166434&action=edit Bug 34788: Add Vue components, api client and navigation route This patch adds a new component to handle the file import, a route to that component and the API client route needed to access the API Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165890|0 |1 is obsolete| | --- Comment #53 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166436&action=edit Bug 34788: Add unit test Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165892|0 |1 is obsolete| | --- Comment #55 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166438&action=edit Bug 34788: Allow for import of CSV files This commit allows CSV files to be imported alongside TSV files. It also adds some performance improvements relating to the max_allowed_packet and the matching of titles, as well as some small bugfixes and unit test changes Test plan: 1) Enable the ERM module 2) Navigate to E-resource management > eHoldings > Local > Packages 3) Create at least one package 4) Navigate to E-resource management > eHoldings > Local > Titles 5) There should be a button for "Import from KBART file" 6) Click this button 7) Select the package that you created from the dropdown and then choose your KBART file using the "Choose file" button. I have attached some example files to the bug but feel free to use your own if you have them. 8) Click Submit 9) If your file is a valid file, a background job will be queued, if not then a warning will display showing what is incorrect in your file 10) To test the file format warning, edit your file and add a random column heading into the file e.g. test_column. When you upload it, the warning should show that an invalid column "test_column" has been detected 11) Click on the background job. (If you have uploaded a very large file, the system will chunk the file into smaller pieces and create multiple background jobs) 12) It should display a progress bar followed by a report and any error messages 13) Navigate to E-resource management > eHoldings > Local > Titles and you should see your new titles. 14) Run the unit test: prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165894|0 |1 is obsolete| | --- Comment #57 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166440&action=edit Bug 34788: Allow import of file with additional columns This patch allows a file with additional columns to be imported. When the file is submitted, the system will enqueue the background job and send back information to the UI that certain columns have been ignored. The data will stil l import as normal but only the standard KBART columns will be parsed and imported Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As a non-native speaker, I have a giant pet-peeve: Translatability. 1) Translatability (please follow-up) a) It looks like you are building somewhat nice error messages in ImportKBARTFile.pm, but this is the wrong spot. Example: + my $formatted_title = format_title($new_title); + if ( !$formatted_title->{publication_title} ) { + push @messages, { + code => 'title_failed', + type => 'error', + error_message => "No publication_title found for title_id: ", + title => '(Unknown)', + title_id => $formatted_title->{external_id} + }; I think these should be codes and then resolved in the template to make them translatable in the templates. b) I believe these are also not translatable in .vue files? + <li>Column headings row</li> + <li>Title data row</li> We have this construct just a few lines above: <li>{{ $__("The file must be in TSV or CSV format") }}</li> c) Do not include the HTML in the translatable string. Use concatenation. These are likely to get broken in process or by translators getting confused: + message += this.$__( + "<p style='font-weight: normal; font-size: medium; margin-top: 1em;'>Your file was too large to process in one job, the file has been split into %s jobs to meet the maximum size limits.</p>" + '<li>Job %s for uploaded file has been queued, <a href="/cgi-bin/koha/admin/background_jobs.pl?op=view&id=%s" target="_blank">click here</a> to check its progress.</li> (some more of these in the file below) 2) File endings (separate bug/future) Most of the time KBART files are received as .txt. It looks like the code expects the "correct" file endings .csv and .tsv. This can be a problem for libraries especially if they are working in Windows and file endings are set to not show. Some might not have the choice to change that easily. It would be great if we could do some kind of auto-detection for .txt files. (maybe checking for the tab chars?) 3) Accessibility (follow-up) Accessibility guidelines say we should not use constructs like "click here" - a link should already be clear by it's formatting. And we should always make sure to have a good link text that has "sense". + <a href="/cgi-bin/koha/erm/eholdings/local/packages/[% report.package_id | $raw %]">Click here to see the package</a> Why not just "Package"? 4) Terminology (done) We are trying hard to get rid of "biblio" which is not a real word :) (see wiki/terminology list). + >{{ $__("Create linked biblio record") }}:</label I'll fix that one in a follow-up (bibliographic) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please reset to "Passed QA" when supplying a follow-up, makes it easier to spot for me in all the bugzilla noise :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36831 [Bug 36831] Add support for .txt files to the KBART import tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we broke the tests with the translation fixes, can you please check? I had fixed the first one, but got stuck on the second: prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_24_05_candidate | --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked follow-up for pushing to main. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement to the ERM |This enhancement to the ERM release notes|module allows for importing |module allows for importing |KBART format files into the |KBART format files into the |system. |system. It also allows to | |optionally create linked | |bibliographic records from | |the provided data. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #68 from Hugo Agud <hagud@orex.es> --- I really love this feature! Altought there is pending to check documentation, I can not wait for asking ;) fsome questions about this lovely feature. 1. Kbart offer the chance of import local files into biblio, but just title, why not push also issn or isbn or publisher or itype? 362? for example? 2. If the kbart belongs to proquestor ebsco probably they will to update monthly, i have not seen an unimport buttom.. am I right? This is something I try to sponsor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36895 [Bug 36895] Background job links for KBART import are not working -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37647 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37647 [Bug 37647] Unnecessary use of Text::CSV_XS in Koha/REST/V1/ERM/EHoldings/Titles/Local.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #71)

(In reply to Matt Blenkinsop from comment #61)

...

Created attachment 166571 [details] [review] [review] [review] Bug 34788: (follow-up): Fix translations

Please stop using backtick, it does not work correctly with translations.

See: fr-FR-messages-js.po

+#: koha-tmpl/intranet-tmpl/prog/js/vue/dist/erm.js:20920 +#, javascript-format +msgid "" +"Your file was too large to process in one job, the file has been split into %s jobs to meet the maximum size limits.\"\n" +" ).format(success.job_ids.length)}</p>`\n" +" }\n" +" success.job_ids.forEach((job, i) => {\n" +" message += `<li>${this.$__(\n" +" \"Job %s for uploaded file has been queued\"\n" +" ).format(\n" +" i + 1\n" [...]

See bug 38058.

I believe I fixed some of these to be compliant with coding guidelines: Bug 36836 - Review ERM module for translation issues ... still waiting for sign-off :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37491 [Bug 37491] Remove duplicate asset import from KBART template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 [Bug 42130] Holdings created in ERM with a linked bibliographic record do not link to the record, nor is the record indexed -- You are receiving this mail because: You are watching all bug changes.