[Bug 29567] New: Cataloguing plugins are broken on the batch item mod toold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Bug ID: 29567 Summary: Cataloguing plugins are broken on the batch item mod toold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Tools Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 28445 Broken by bug 28445. See also the FIXME from commit 86156da415141e32e16f2090477be32bda241afb Bug 28445: Adjust code to handle regexs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127973&action=edit Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins Broken by bug 28445. See also the FIXME from commit 86156da415141e32e16f2090477be32bda241afb Bug 28445: Adjust code to handle regexs The problem is that the cataloguing plugins inject JS code in the DOM BEFORE the footer in somes page we have all the JS loaded at the end of the DOM and so $ (jQuery) is not defined It's working on additem as we don't have the JS in the footer, but the batch item mod tool has it there. Test plan: Batch edit items and confirm that cataloguing are working correctly with this patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cataloguing plugins are |Cataloguing plugins are |broken on the batch item |broken on the batch item |mod toold |mod tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127973|0 |1 is obsolete| | --- Comment #2 from Andrew Nugged <nugged@gmail.com> --- Created attachment 127974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127974&action=edit Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins Broken by bug 28445. See also the FIXME from commit 86156da415141e32e16f2090477be32bda241afb Bug 28445: Adjust code to handle regexs The problem is that the cataloguing plugins inject JS code in the DOM BEFORE the footer in somes page we have all the JS loaded at the end of the DOM and so $ (jQuery) is not defined It's working on additem as we don't have the JS in the footer, but the batch item mod tool has it there. Test plan: Batch edit items and confirm that cataloguing are working correctly with this patch applied. Signed-off-by: Andrew Nugged <nugged@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Skipping QA, this needs to be pushed today. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42133 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org