https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Lisette Scheer <lisetteslatah@gmail.com> --- *** Bug 23500 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #3 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 92863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92863&action=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92864|0 |1 is obsolete| | --- Comment #5 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 93052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93052&action=edit Bug 23260: Add anonymize items_last_borrower feature This patch adds the feature to anonymize patrons from items_last_borrower table. This code is run from batch_anonymize script, which is triggered from a cron job. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 5) In mysql, update created_on date to one day earlier. 6) set AnonymousPatron preference to a valid patron id 7) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 4 and 5 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 94859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94859&action=edit Bug 23260: Add anonymize items_last_borrower feature This patch adds the feature to anonymize patrons from items_last_borrower table. This code is run from batch_anonymize script, which is triggered from a cron job. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 5) In mysql, update created_on date to one day earlier. 6) set AnonymousPatron preference to a valid patron id 7) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 4 and 5 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #12 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 95033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95033&action=edit Bug 23260: (follow-up) optimize anonymise_items_last_borrower -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #14 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Marcel de Rooy from comment #13)

Thx for continuing here, Augustin.

Just wondering what happens here: - subtest 'Logged in librarian is not superlibrarian & IndependentBranches' => sub {

Why remove another subtest??

Hi Marcel, now that we don't search the patron to anonymise, this test has no sense.. We can no longer check the library of the borrower in case IndependentBranches preference is set on. Thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94858|0 |1 is obsolete| | Attachment #94859|0 |1 is obsolete| | Attachment #95033|0 |1 is obsolete| | --- Comment #15 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 95457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95457&action=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable Sponsored-by: Northeast Kansas Library System -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #17 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 95459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95459&action=edit Bug 23260: (follow-up) optimize anonymise_items_last_borrower Sponsored-by: Northeast Kansas Library System -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Maryse Simard from comment #5)

Created attachment 93052 [details] [review] Bug 23260: Add anonymize items_last_borrower feature

This patch adds the feature to anonymize patrons from items_last_borrower table. This code is run from batch_anonymize script, which is triggered from a cron job.

To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 5) In mysql, update created_on date to one day earlier. 6) set AnonymousPatron preference to a valid patron id 7) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 4 and 5 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Your test plan has me concerned. If you must first set the feature to allow (#3), which is what Koha currently does without this feature, it sounds like this feature is not on by default. Is that true? It should retain the current behavior of Koha by default. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- ReQAing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Two things left, after the follow-up: We need an adjusted dbrev: `created_on` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp(), That is an updated_on ! So we should remove the ON UPDATE. This made me add the nb_rows comment. A count after the update would be affected by the updated timestamp. my $before = $now + DateTime::Duration->new( days => 1 ); That does not look good. Use add_days or something like that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- $items_last_returned_by_rs->update_or_create( { borrowernumber => $borrower->borrowernumber, itemnumber => $self->id } ); So it might be better to KEEP the UPDATE clause but RENAME the field. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #27 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 95699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95699&action=edit Bug 23260: Add anonymize items_last_borrower feature This patch adds the feature to anonymize patrons from items_last_borrower table. This code is run from batch_anonymize script, which is triggered from a cron job. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 5) In mysql, update created_on date to one day earlier. 6) set AnonymousPatron preference to a valid patron id 7) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 4 and 5 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Sponsored-by: Northeast Kansas Library System Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #29 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 95701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95701&action=edit Bug 23260: (QA follow-up) Use ->update instead of ->next Also moves initialization of $anonymous_patron closer to associated comment lines. And removes the unneeded changes from Koha::Patrons. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #31 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Marcel de Rooy from comment #24)

Hmm

sub last_returned_by { my ( $self, $borrower ) = @_;

my $items_last_returned_by_rs = Koha::Database->new()->schema()->resultset('ItemsLastBorrower');

Not so nice in Koha::Item. (Possibly out of scope though)

This was introduced in Bug 14945. Do you want me to change it to use Items::LastPatrons class? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Marcel, your patch introduces the use of ->update. Given the problems about it raised on bug 21761, could you resubmit it without using ->update? Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Agustín Moyano from comment #31)

(In reply to Marcel de Rooy from comment #24)

...

Hmm

sub last_returned_by { my ( $self, $borrower ) = @_;

my $items_last_returned_by_rs = Koha::Database->new()->schema()->resultset('ItemsLastBorrower');

Not so nice in Koha::Item. (Possibly out of scope though)

This was introduced in Bug 14945.

Do you want me to change it to use Items::LastPatrons class?

Another report? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #36 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Marcel de Rooy from comment #35)

(In reply to Agustín Moyano from comment #31)

...

(In reply to Marcel de Rooy from comment #24)

...

Hmm

sub last_returned_by { my ( $self, $borrower ) = @_;

my $items_last_returned_by_rs = Koha::Database->new()->schema()->resultset('ItemsLastBorrower');

Not so nice in Koha::Item. (Possibly out of scope though)

This was introduced in Bug 14945.

Do you want me to change it to use Items::LastPatrons class?

Another report?

Agreed, I created bug 24092 to address this issue. Changing this bug to SO again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Agustín Moyano from comment #32)

I agree that the created_on column should be renamed to updated_on, or maybe we should have both columns, but I believe this should be done in a separate bug.. we have to analyze the impact of such a change

OK Separate bug. Please open it too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95698|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95769&action=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable Sponsored-by: Northeast Kansas Library System Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95700|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95771&action=edit Bug 23260: (follow-up) optimize anonymise_items_last_borrower Sponsored-by: Northeast Kansas Library System Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why $class->_resultset->search instead of $self->search? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Basically I do not think this table deserves its own modules. We could handle that from Koha::Patron I'd say. I guess it's late now as it's PQA. Letting RM decide. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Agustín Moyano from comment #46)

(In reply to Jonathan Druart from comment #43)

...

Why $class->_resultset->search instead of $self->search?

I believe that's a question only you can reply (bug 16966 - https://bugs.koha-community.org/bugzilla3/attachment. cgi?id=60705&action=diff#a/Koha/Patrons.pm_sec1) ;P

on a firt attempt, I copied what search_patron_to_anonymize does, but then in follow-up removed it from Patrons and placed it in LastPatrons without $class->_resultset->search.

Heh ok, fair enough. I do not think it's correct (not incorrect either). We should return $class->search(), as you did then! I am still not happy with that new module. I do not think it really makes sense. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 | released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- error: sha1 information is lacking or useless (Koha/Patrons.pm). error: could not build fake ancestor Patch failed at 0001 Bug 23260: (follow-up) optimize anonymise_items_last_borrower -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96791&action=edit Bug 23260: [ALTERNATIVE] Inline code to anonymise_issue_history This alternative patch reduces the complexity of the change by simply updateing the existing anonymise_issue_history method to include anonymisation of the items_last_borrowers table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Martin, your alternative approach looks good to me! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #58 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 97842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97842&action=edit Bug 23260: Inline code to anonymise_issue_history This alternative patch reduces the complexity of the change by simply updateing the existing anonymise_issue_history method to include anonymisation of the items_last_borrowers table. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 5 and 6 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98054&action=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #63)

Almost done but I think I found an issue, the method does no longer return the number of issues modified. I do not think we should sum the number of items_last_borrower updated.

I think your right.. looks like an oversight on my part when I first submitted the alternative approach. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98054|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98282&action=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98282|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98349&action=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I see!!!! Right.. I totally missed that `but not if the item is lost, damaged, or withdrawn.` in the original request is different to how the existing anonymisation logic works. Personally (and I've checked with a few people now) I feel that the two locations this data is stored should be anonymised equally so they don't fall out of sync. As this is a change in a privacy feature I think we probably need to govern whether we filter out by item status based on a system preference to keep everyone happy. I'll add that as a followup now and update the test to correspond. Good catch Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98352&action=edit Bug 23260: Proposed preference driven filtering -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9011, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14945 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I guess what I was trying to say is that this was designed to fall out of sync with the other tables - so we should not break that use case and allow for separate treatment of both. Added see also the bugs with former discussion. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24576 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #77 from George Williams (NEKLS) <george@nekls.org> --- NEKLS is sponsoring the development of this cronjob. Currently we have StoreLastBorrower turned on because we want the last borrower information stored if patron privacy is anonymized. We also have a cron running that prunes old_issues more than 400 days old so that all patron data is effectively anonymized after about 13 months. But we are not pruning items_last_borrower because staff at many of our libraries want the last borrower information saved on the item record if the item was lost. This means that we are currently anonymizing patron data in old_issues after it's 400 days old and never anonymizing that same data in items_last_borrower for the sake of the libraries that want that data saved for lost items. So for us the point of this cronjob is to prune items_last_borrower once the data is more than 400 days old which is in line with the other pruning we're already doing but it will make an exception if the item has a lost status. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've run out of steam for this at this point I'm afraid. We've gone nearly full circle now.. to me this highlights the need for good RFC's as the first step. I'll try to revisit unless someone takes it back over. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97841|0 |1 is obsolete| | Attachment #98044|0 |1 is obsolete| | Attachment #98053|0 |1 is obsolete| | Attachment #98064|0 |1 is obsolete| | Attachment #98349|0 |1 is obsolete| | Attachment #98352|0 |1 is obsolete| | --- Comment #81 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 112734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112734&action=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable Sponsored-by: Northeast Kansas Library System Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #83 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 112736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112736&action=edit Bug 23260: Simplify tests Use build_sample_item and build_object -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #85 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 112738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112738&action=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #87 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 112740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112740&action=edit Bug 23260: (follow-up) Add AnonymiseLastBorrower and AnonymiseLastBorrowerDays sysprefs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #89 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 112742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112742&action=edit Bug 23260: (follow-up) Add new cron job -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #91 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Katrin Fischer from comment #78)

Hi George,

I think an option to clean it is not in question, I just think we should not tie it to the same 'switch' - so libraries can make the decision to delete both tables after a different number of days.

This change as proposed currently would not only affect the cronjob. The method changed is used in different areas:

- batch_anonymise.pl cronjob - When using the batch anonymize feature tool in the staff interface - When a patron decides to delete their reading history from the OPAC (OpacPrivacy etc.)

So if I know I just returned a damaged book via the self check... I could delete my reading history from the OPAC. Info might still be retrievable somewhere, but I feel StoreLastPatron should be covering that use case.

Hi Katrin, I've added a series of follow-ups that separates anonymization of checkouts from item's last borrower. I added a new cron job just for this, that's controlled by two sysprefs.. one to say if anonymizing item's last borrower is allowed and another to set how old it must be before it get's anonymized. Hope this is the one! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112735|0 |1 is obsolete| | --- Comment #93 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117975&action=edit Bug 23260: Inline code to anonymise_issue_history This alternative patch reduces the complexity of the change by simply updateing the existing anonymise_issue_history method to include anonymisation of the items_last_borrowers table. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 5 and 6 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112737|0 |1 is obsolete| | --- Comment #95 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117977&action=edit Bug 23260: (follow-up) Remove last_borrower updates from issues count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112739|0 |1 is obsolete| | --- Comment #97 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117979&action=edit Bug 23260: Proposed preference driven filtering -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112741|0 |1 is obsolete| | --- Comment #99 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117981&action=edit Bug 23260: (follow-up) Update test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112743|0 |1 is obsolete| | --- Comment #101 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117983&action=edit Bug 23260: (follow-up) Add anonymise_last_borrowers method to Patrons.pm This patch adds the method anonymise_last_borrowers in Patrons.pm. To test: 1) apply this patch and the previous ones 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/anonymise_last_borrowers.pl CHECK => borrower number in items_last_borrower is not anonymised yet. 8) Repeat step 5 and 6 but instead of two days earlier, set the new entry in items_last_borrower to three days eralier. 9) set AnonymiseLastBorrower to 'Anonymise' and AnonymiseLastBorrowerDays to 2 days. 10) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 11) repeat step 8 12) set AnonymousPatron preference to 0 13) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to null 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117975|0 |1 is obsolete| | --- Comment #104 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120523&action=edit Bug 23260: Inline code to anonymise_issue_history This alternative patch reduces the complexity of the change by simply updateing the existing anonymise_issue_history method to include anonymisation of the items_last_borrowers table. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 5 and 6 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117977|0 |1 is obsolete| | --- Comment #106 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120525&action=edit Bug 23260: (follow-up) Remove last_borrower updates from issues count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117979|0 |1 is obsolete| | --- Comment #108 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120527&action=edit Bug 23260: Proposed preference driven filtering -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117981|0 |1 is obsolete| | --- Comment #110 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120529&action=edit Bug 23260: (follow-up) Update test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117983|0 |1 is obsolete| | --- Comment #112 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120531&action=edit Bug 23260: (follow-up) Add anonymise_last_borrowers method to Patrons.pm This patch adds the method anonymise_last_borrowers in Patrons.pm. To test: 1) apply this patch and the previous ones 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/anonymise_last_borrowers.pl CHECK => borrower number in items_last_borrower is not anonymised yet. 8) Repeat step 5 and 6 but instead of two days earlier, set the new entry in items_last_borrower to three days eralier. 9) set AnonymiseLastBorrower to 'Anonymise' and AnonymiseLastBorrowerDays to 2 days. 10) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 11) repeat step 8 12) set AnonymousPatron preference to 0 13) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to null 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120523|0 |1 is obsolete| | --- Comment #115 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122964&action=edit Bug 23260: Inline code to anonymise_issue_history This alternative patch reduces the complexity of the change by simply updateing the existing anonymise_issue_history method to include anonymisation of the items_last_borrowers table. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 5 and 6 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120525|0 |1 is obsolete| | --- Comment #117 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122966&action=edit Bug 23260: (follow-up) Remove last_borrower updates from issues count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120527|0 |1 is obsolete| | --- Comment #119 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122968&action=edit Bug 23260: Proposed preference driven filtering -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120529|0 |1 is obsolete| | --- Comment #121 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122970&action=edit Bug 23260: (follow-up) Update test Update test count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120531|0 |1 is obsolete| | --- Comment #123 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122972&action=edit Bug 23260: (follow-up) Add anonymise_last_borrowers method to Patrons.pm This patch adds the method anonymise_last_borrowers in Patrons.pm. To test: 1) apply this patch and the previous ones 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/anonymise_last_borrowers.pl CHECK => borrower number in items_last_borrower is not anonymised yet. 8) Repeat step 5 and 6 but instead of two days earlier, set the new entry in items_last_borrower to three days eralier. 9) set AnonymiseLastBorrower to 'Anonymise' and AnonymiseLastBorrowerDays to 2 days. 10) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 11) repeat step 8 12) set AnonymousPatron preference to 0 13) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to null 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122963|0 |1 is obsolete| | Attachment #122964|0 |1 is obsolete| | Attachment #122965|0 |1 is obsolete| | Attachment #122966|0 |1 is obsolete| | Attachment #122967|0 |1 is obsolete| | Attachment #122968|0 |1 is obsolete| | Attachment #122969|0 |1 is obsolete| | Attachment #122970|0 |1 is obsolete| | Attachment #122971|0 |1 is obsolete| | Attachment #122972|0 |1 is obsolete| | --- Comment #124 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145175&action=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable Sponsored-by: Northeast Kansas Library System Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #126 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145177&action=edit Bug 23260: Simplify tests Use build_sample_item and build_object -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #128 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145179&action=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #130 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145181&action=edit Bug 23260: (follow-up) Add AnonymiseLastBorrower and AnonymiseLastBorrowerDays sysprefs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #132 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145183&action=edit Bug 23260: (follow-up) Add new cron job -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Patch doesn't apply --- Comment #134 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- error: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t). error: could not build fake ancestor Patch failed at 0001 Bug 23260: (follow-up) Update test hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #137 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157107&action=edit Bug 23260: Inline code to anonymise_issue_history This alternative patch reduces the complexity of the change by simply updateing the existing anonymise_issue_history method to include anonymisation of the items_last_borrowers table. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 5 and 6 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl --days 1 SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #139 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157109&action=edit Bug 23260: (follow-up) Remove last_borrower updates from issues count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #141 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157111&action=edit Bug 23260: Proposed preference driven filtering -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #143 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157113&action=edit Bug 23260: (follow-up) Update test Update test count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #145 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157115&action=edit Bug 23260: (follow-up) Add anonymise_last_borrowers method to Patrons.pm This patch adds the method anonymise_last_borrowers in Patrons.pm. To test: 1) apply this patch and the previous ones 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/anonymise_last_borrowers.pl CHECK => borrower number in items_last_borrower is not anonymised yet. 8) Repeat step 5 and 6 but instead of two days earlier, set the new entry in items_last_borrower to three days eralier. 9) set AnonymiseLastBorrower to 'Anonymise' and AnonymiseLastBorrowerDays to 2 days. 10) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 11) repeat step 8 12) set AnonymousPatron preference to 0 13) perl misc/cronjobs/anonymise_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to null 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #147 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Oi, so many rebases. Sorry we didn't get to this earlier. 1) Can you explain this part of the code please? + my $last_borrowers_to_anonymise = $patron->_result->items_last_borrowers->search( + { + ( + $older_than_date + ? ( created_on => { '<' => $dtf->format_datetime($older_than_date) } ) + : (), + "itemnumber.damaged" => 0, + "itemnumber.itemlost" => 0, + "itemnumber.withdrawn" => 0, + ), + }, + { join => ['itemnumber'] } + ); 2) Database updated needs to be reformatted to use the newer template. 3) Terminology / System preference naming Sorry to be nit-picky about this, but I believe we should stick to the standard terminology as per our coding guidelines: * Use AE instead of BE: Anonymise should be Anonymize * Borrower should be Patron AnonymiseLastBorrower => AnonymizeLastPatron AnonymiseLastBorrowerDays => AnonymizeLastPatronDelay/Days System preference descriptions need to be adapted as well. 4) Cronjob +use strict; +use warnings; --> should be Use Modern::Perl. 5) anonymise_issue_history appears to be unused? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157106|0 |1 is obsolete| | Attachment #157107|0 |1 is obsolete| | Attachment #157108|0 |1 is obsolete| | Attachment #157109|0 |1 is obsolete| | Attachment #157110|0 |1 is obsolete| | Attachment #157111|0 |1 is obsolete| | Attachment #157112|0 |1 is obsolete| | Attachment #157113|0 |1 is obsolete| | Attachment #157114|0 |1 is obsolete| | Attachment #157115|0 |1 is obsolete| | Attachment #157116|0 |1 is obsolete| | --- Comment #148 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159291&action=edit Bug 23260: Database updates and new system preferences AnonymizeLastBorrower / AnonymizeLastBorrowerDays This patch alters the items_last_borrowers table to allow for NULL borrowers It also adds two new system preferences to allow controlling the anonymization of items_last_borrower data -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #150 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159293&action=edit Bug 23260: Unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #152 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #147)

Oi, so many rebases. Sorry we didn't get to this earlier.

1) Can you explain this part of the code please?

+ my $last_borrowers_to_anonymise = $patron->_result->items_last_borrowers->search( + { + ( + $older_than_date + ? ( created_on => { '<' => $dtf->format_datetime($older_than_date) } ) + : (), + "itemnumber.damaged" => 0, + "itemnumber.itemlost" => 0, + "itemnumber.withdrawn" => 0, + ), + }, + { join => ['itemnumber'] } + );

This fetches the items_last_borrower rows to anonymise, joining to the items table to avoid removing info from items that are no longer in circulation where the last borrower is likely to be responsible for that status

2) Database updated needs to be reformatted to use the newer template.

OK

3) Terminology / System preference naming

Sorry to be nit-picky about this, but I believe we should stick to the standard terminology as per our coding guidelines:

* Use AE instead of BE: Anonymise should be Anonymize * Borrower should be Patron

AnonymiseLastBorrower => AnonymizeLastPatron AnonymiseLastBorrowerDays => AnonymizeLastPatronDelay/Days

System preference descriptions need to be adapted as well.

changed 'ise' to 'ize' As the table is 'items_last_borrower' and we are referring to 'the patron that last borrowed' I think borrower actually makes more sense in this case

4) Cronjob

+use strict; +use warnings;

--> should be Use Modern::Perl.

OK

5) anonymise_issue_history appears to be unused?

It looks like this has been through multiple coders and revisions - all squashed - unused routine removed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159291|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159298&action=edit Bug 23260: Database updates and new system preferences AnonymizeLastBorrower / AnonymizeLastBorrowerDays This patch alters the items_last_borrowers table to allow for NULL borrowers It also adds two new system preferences to allow controlling the anonymization of items_last_borrower data Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159293|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159300&action=edit Bug 23260: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice clean rebase, all workings as described here now. Signing off and passing back for a final QA round. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159298|0 |1 is obsolete| | Attachment #159299|0 |1 is obsolete| | Attachment #159300|0 |1 is obsolete| | Attachment #159301|0 |1 is obsolete| | --- Comment #158 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164129&action=edit Bug 23260: Database updates and new system preferences AnonymizeLastBorrower / AnonymizeLastBorrowerDays This patch alters the items_last_borrowers table to allow for NULL borrowers It also adds two new system preferences to allow controlling the anonymization of items_last_borrower data Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #160 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164131&action=edit Bug 23260: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #162 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164133&action=edit Bug 23260: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164129|0 |1 is obsolete| | --- Comment #164 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182000&action=edit Bug 23260: Database updates and new system preferences AnonymizeLastBorrower / AnonymizeLastBorrowerDays This patch alters the items_last_borrowers table to allow for NULL borrowers It also adds two new system preferences to allow controlling the anonymization of items_last_borrower data Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164131|0 |1 is obsolete| | --- Comment #166 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182002&action=edit Bug 23260: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164133|0 |1 is obsolete| | --- Comment #168 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182004&action=edit Bug 23260: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #170 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182006&action=edit Bug 23260: Tidy Koha/Patrons.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lin-wei.li@inLibro.com --- Comment #173 from Lin Wei <lin-wei.li@inLibro.com> --- # Test Results Unsure. I think the Test Plan mentions the wrong perl script to run: attachment 182007 shows a script different to the one mentionned in the Test Plan. Furthermore, the unit tests defined in `t/db_dependent/Koha/Patrons.t` currently fail in `main`. # Test Execution 1. Apply patch. 2. Set "AnonymousPatron" to "10101010." 3. Set "AnonymizeLastBorrower" and "AnonymizeLastBorrower" to "Anonymize" and "10". 3. Run `./misc/cronjobs/batch_anonymise.pl`. => Runs without asking for confirmation. 4. Run `./misc/cronjobs/anonymize_last_borrowers.pl`. => Asks for "--confirm" flag. 5. Run `./misc/cronjobs/anonymize_last_borrowers.pl --confirm`. => Runs. 6. Run `prove t/db_dependent/Koha/Patrons.t`. => Tests fail, see [Prove Output - Patch] below. 7. Reset via `git reset --hard origin/main; git pull`. 8. Run `prove t/db_dependent/Koha/Patrons.t`. => Tests fail, see [Prove Output - Main] below. # Conclusion - Test Plan is unclear: - Test Plan might contain typo. - Script that I think needs to be tested behaves as expected. - Attachment 182006 shows inconsequential change in code formatting (ok). - But 182005 adjusts unit tests that are difficult to verify because they also fail in `main`. - It seems that everything is likely behaving as expected but, due to the uncertainties mentionned above, I am leaving this patch as "Needs Signoff." # Prove Output - Patch prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 13/47 # Failed test 'Patron should have 2 overdues' # at t/db_dependent/Koha/Patrons.t line 862. # got: '3' # expected: '2' # Looks like you failed 1 test of 19. t/db_dependent/Koha/Patrons.t .. 16/47 # Failed test 'checkouts + pending_checkouts + overdues + old_checkouts' # at t/db_dependent/Koha/Patrons.t line 882. t/db_dependent/Koha/Patrons.t .. 46/47 # Failed test 'no warnings' # at /usr/local/share/perl/5.38.2/Test/Builder.pm line 187. # There were 3 warning(s) # Previous test 17 'The issue should be returned in the same order as they have been done, second is correct' # Use of uninitialized value $unit in string eq at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # C4::Overdues::get_chargeable_units(undef, DateTime=HASH(0x59e5be8f57f8), DateTime=HASH(0x59e5be8d1b18), "zJnwJX") called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2830 # C4::Circulation::_calculate_new_debar_dt(Koha::Patron=HASH(0x59e5be7c50b0), Koha::Item=HASH(0x59e5be8bba30), DateTime=HASH(0x59e5be8f57f8), DateTime=HASH(0x59e5be8d1b18)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2893 # C4::Circulation::_debar_user_on_return(Koha::Patron=HASH(0x59e5be7c50b0), Koha::Item=HASH(0x59e5be8bba30), DateTime=HASH(0x59e5be8f57f8), DateTime=HASH(0x59e5be8d1b18)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2471 # C4::Circulation::AddReturn("F7WtNareKyJ_KO") called at t/db_dependent/Koha/Patrons.t line 873 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x59e5b3d98ff0), "checkouts + pending_checkouts + overdues + old_checkouts", CODE(0x59e5be47d6a8)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("checkouts + pending_checkouts + overdues + old_checkouts", CODE(0x59e5be47d6a8)) called at t/db_dependent/Koha/Patrons.t line 882 # # ---------- # Previous test 17 'The issue should be returned in the same order as they have been done, second is correct' # Use of uninitialized value $unit in string eq at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # C4::Overdues::get_chargeable_units(undef, DateTime=HASH(0x59e5be8bee00), DateTime=HASH(0x59e5be8dedf0), "zJnwJX") called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2830 # C4::Circulation::_calculate_new_debar_dt(Koha::Patron=HASH(0x59e5be8e6838), Koha::Item=HASH(0x59e5be8e6598), DateTime=HASH(0x59e5be8bee00), DateTime=HASH(0x59e5be8dedf0)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2893 # C4::Circulation::_debar_user_on_return(Koha::Patron=HASH(0x59e5be8e6838), Koha::Item=HASH(0x59e5be8e6598), DateTime=HASH(0x59e5be8bee00), DateTime=HASH(0x59e5be8dedf0)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2471 # C4::Circulation::AddReturn("DaXCuu4Lm6mqI") called at t/db_dependent/Koha/Patrons.t line 874 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x59e5b3d98ff0), "checkouts + pending_checkouts + overdues + old_checkouts", CODE(0x59e5be47d6a8)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("checkouts + pending_checkouts + overdues + old_checkouts", CODE(0x59e5be47d6a8)) called at t/db_dependent/Koha/Patrons.t line 882 # # ---------- # Previous test 0 '' # Use of uninitialized value $unit in string eq at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # C4::Overdues::get_chargeable_units(undef, DateTime=HASH(0x59e5be808390), DateTime=HASH(0x59e5be8f2fb8), "mxQDxyz8") called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2830 # C4::Circulation::_calculate_new_debar_dt(Koha::Patron=HASH(0x59e5be700268), Koha::Item=HASH(0x59e5be75cc50), DateTime=HASH(0x59e5be808390), DateTime=HASH(0x59e5be8f2fb8)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2893 # C4::Circulation::_debar_user_on_return(Koha::Patron=HASH(0x59e5be700268), Koha::Item=HASH(0x59e5be75cc50), DateTime=HASH(0x59e5be808390), DateTime=HASH(0x59e5be8f2fb8)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2471 # C4::Circulation::AddReturn("rgu6PRZrAlB", undef, undef, DateTime=HASH(0x59e5be8f2fb8)) called at t/db_dependent/Koha/Patrons.t line 1589 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x59e5b3d98ff0), "anonymize items_last_borrower by days", CODE(0x59e5be8f5660)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("anonymize items_last_borrower by days", CODE(0x59e5be8f5660)) called at t/db_dependent/Koha/Patrons.t line 1612 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x59e5b3d98ff0), "anonymize items_last_borrower", CODE(0x59e5be47d6a8)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("anonymize items_last_borrower", CODE(0x59e5be47d6a8)) called at t/db_dependent/Koha/Patrons.t line 1704 # # Looks like you failed 2 tests of 47. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/47 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 512 (exited 2) Tests: 47 Failed: 2) Failed tests: 16, 47 Non-zero exit status: 2 Files=1, Tests=47, 27 wallclock secs ( 0.04 usr 0.01 sys + 18.53 cusr 2.86 csys = 21.44 CPU) Result: FAIL # Prove Output - Main prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 13/46 # Failed test 'Patron should have 2 overdues' # at t/db_dependent/Koha/Patrons.t line 862. # got: '3' # expected: '2' # Looks like you failed 1 test of 19. t/db_dependent/Koha/Patrons.t .. 16/46 # Failed test 'checkouts + pending_checkouts + overdues + old_checkouts' # at t/db_dependent/Koha/Patrons.t line 882. t/db_dependent/Koha/Patrons.t .. 44/46 # Failed test 'no warnings' # at /usr/local/share/perl/5.38.2/Test/Builder.pm line 187. # There were 2 warning(s) # Previous test 17 'The issue should be returned in the same order as they have been done, second is correct' # Use of uninitialized value $unit in string eq at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # C4::Overdues::get_chargeable_units(undef, DateTime=HASH(0x5c5975d35c98), DateTime=HASH(0x5c5975d0eba0), "uNLwkz") called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2830 # C4::Circulation::_calculate_new_debar_dt(Koha::Patron=HASH(0x5c5975c01cb0), Koha::Item=HASH(0x5c5975c19cf0), DateTime=HASH(0x5c5975d35c98), DateTime=HASH(0x5c5975d0eba0)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2893 # C4::Circulation::_debar_user_on_return(Koha::Patron=HASH(0x5c5975c01cb0), Koha::Item=HASH(0x5c5975c19cf0), DateTime=HASH(0x5c5975d35c98), DateTime=HASH(0x5c5975d0eba0)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2471 # C4::Circulation::AddReturn("Z6bNQUnw8Q1_F") called at t/db_dependent/Koha/Patrons.t line 873 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x5c596b215960), "checkouts + pending_checkouts + overdues + old_checkouts", CODE(0x5c59758ad970)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("checkouts + pending_checkouts + overdues + old_checkouts", CODE(0x5c59758ad970)) called at t/db_dependent/Koha/Patrons.t line 882 # # ---------- # Previous test 17 'The issue should be returned in the same order as they have been done, second is correct' # Use of uninitialized value $unit in string eq at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # at /inlibro/git/koha-master-dev-linwei/C4/Overdues.pm line 352. # C4::Overdues::get_chargeable_units(undef, DateTime=HASH(0x5c5975d3be70), DateTime=HASH(0x5c5975d48620), "uNLwkz") called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2830 # C4::Circulation::_calculate_new_debar_dt(Koha::Patron=HASH(0x5c5975c7f748), Koha::Item=HASH(0x5c5975c23998), DateTime=HASH(0x5c5975d3be70), DateTime=HASH(0x5c5975d48620)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2893 # C4::Circulation::_debar_user_on_return(Koha::Patron=HASH(0x5c5975c7f748), Koha::Item=HASH(0x5c5975c23998), DateTime=HASH(0x5c5975d3be70), DateTime=HASH(0x5c5975d48620)) called at /inlibro/git/koha-master-dev-linwei/C4/Circulation.pm line 2471 # C4::Circulation::AddReturn("oVFGo_tqof9jA7HGAgH1") called at t/db_dependent/Koha/Patrons.t line 874 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x5c596b215960), "checkouts + pending_checkouts + overdues + old_checkouts", CODE(0x5c59758ad970)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("checkouts + pending_checkouts + overdues + old_checkouts", CODE(0x5c59758ad970)) called at t/db_dependent/Koha/Patrons.t line 882 # # Looks like you failed 2 tests of 46. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/46 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 512 (exited 2) Tests: 46 Failed: 2) Failed tests: 16, 46 Non-zero exit status: 2 Files=1, Tests=46, 24 wallclock secs ( 0.05 usr 0.00 sys + 16.98 cusr 2.70 csys = 19.73 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #175 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #174)

prove t/db_dependent/Koha/Patrons.t succeeds for me both with and without this patch. The test plan worked as described.

I get an error trying to open /cgi-bin/koha/catalogue/moredetail.pl when StoreLastBorrower is enabled and one or more items on the bib has a null borrowernumber entry in items_last_borrower. That means step 13 of the test plan is creating data that causes records not to load in the staff client.

I can't recreate exactly this. Instead, when I get to step 12, I get: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'borrowernumber' cannot be null at /kohadevbox/koha/Koha/Patrons.pm line 218 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #177 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- In last_returned_by there is this line: return unless $rs; So if there is no item, return. We should add this directly afterwards: return unless $rs->borrowernumber; So if there is an item but no borrowernumber, return. -- You are receiving this mail because: You are watching all bug changes.