[Bug 34320] New: Hold reordering arrows look broken after Font Awesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Bug ID: 34320 Summary: Hold reordering arrows look broken after Font Awesome upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 32910 On the place hold screen where the interface shows existing holds, there are custom-style arrows for "Move hold to top" and "Move hold to bottom." The border on these looks wrong after the Font Awesome upgrade. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 [Bug 32910] Upgrade fontawesome icons to V6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153715&action=edit Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade This patch makes minor CSS corrections to the arrows on the place hold page in the staff interface. The corrections are necessary because of changes in the display of icons in Font Awesome 6. To test, apply the patch and locate a bibliographic record in the staff interface to place a hold on. - Place at least one hold on that title. - After placing the hold, you should see a table of all the existing holds on that record. - The arrow control links should look correct, with the "move to top" and "move to bottom" arrows having an extra border to differentiate them from the others. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153715|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 153734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153734&action=edit Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade This patch makes minor CSS corrections to the arrows on the place hold page in the staff interface. The corrections are necessary because of changes in the display of icons in Font Awesome 6. To test, apply the patch and locate a bibliographic record in the staff interface to place a hold on. - Place at least one hold on that title. - After placing the hold, you should see a table of all the existing holds on that record. - The arrow control links should look correct, with the "move to top" and "move to bottom" arrows having an extra border to differentiate them from the others. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Trivial patch, looks good and QA tool is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #5)
Enhancement not pushed to 23.05.x
I mean : Depends on Bug 32910 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Bug 34320 depends on bug 32910, which changed state. Bug 32910 Summary: Upgrade fontawesome icons to V6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org