[Bug 38057] New: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Bug ID: 38057 Summary: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P1 - high Component: Cataloging Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 35402 The advanced editor apparently thought it could get away with using the class hidden from bootstrap.min.css to hide and show the checkmarks in the Settings menu next to framework names as you switch to a different framework. Boy did the Bootstrap5 upgrade show it that it was wrong, by just getting rid of bootstrap.min.css. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172293&action=edit Bug 38057: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update The advanced editor was using a class hidden from bootstrap.min.css to hide checkmarks in the part of the Settings menu that lets you change frameworks. Now that's gone, so it needs to have its own class. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - click the Settings menu 3. In Change framework, ... checkmarks, checkmarks everywhere, and they don't change when you choose a different one, so after the first change you can't even tell what's current 4. Apply patch, Shift+Reload the advanced editor page to bypass the cache 5. Click the Setting menu, see that only the current framework has a checkmark, change to a different one and reopen the Settings menu, see that the one you changed to now has the only checkmark Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172293|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172296&action=edit Bug 38057: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update The advanced editor was using a class hidden from bootstrap.min.css to hide checkmarks in the part of the Settings menu that lets you change frameworks. Now that's gone, so it needs to have its own class. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - click the Settings menu 3. In Change framework, ... checkmarks, checkmarks everywhere, and they don't change when you choose a different one, so after the first change you can't even tell what's current 4. Apply patch, Shift+Reload the advanced editor page to bypass the cache 5. Click the Setting menu, see that only the current framework has a checkmark, change to a different one and reopen the Settings menu, see that the one you changed to now has the only checkmark Sponsored-by: Chetco Community Public Library Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m QA Contact|testopia@bugs.koha-communit |oleonard@myacpl.org |y.org | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Adding Owen here as this is bootstrap related and would be good to have his say here, I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38082 [Bug 38082] Advanced editor does not save the selected framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172296|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 172537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172537&action=edit Bug 38057: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update The advanced editor was using a class hidden from bootstrap.min.css to hide checkmarks in the part of the Settings menu that lets you change frameworks. Now that's gone, so it needs to have its own class. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - click the Settings menu 3. In Change framework, ... checkmarks, checkmarks everywhere, and they don't change when you choose a different one, so after the first change you can't even tell what's current 4. Apply patch, Shift+Reload the advanced editor page to bypass the cache 5. Click the Setting menu, see that only the current framework has a checkmark, change to a different one and reopen the Settings menu, see that the one you changed to now has the only checkmark Sponsored-by: Chetco Community Public Library Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- The bug could also have been fixed by replacing the "hidden" class with the BS5 version, "invisible." But either way works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- I see an .invisible in the opac, but I don't see where it is in intranet-tmpl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Ah, it magically appears (from outside the tree?) in staff-global.css. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Phil Ringnalda from comment #7)
Ah, it magically appears (from outside the tree?) in staff-global.css.
SCSS magic. Bootstrap is bundled into staff-global.css. https://getbootstrap.com/docs/5.3/utilities/visibility/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172537|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172664&action=edit Bug 38057: Fix checkmarks in Change framework menu in Advanced editor after Bootstrap5 update The advanced editor was using a class hidden from bootstrap.min.css to hide checkmarks in the part of the Settings menu that lets you change frameworks. Now that's gone, so it needs to have its own class. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - click the Settings menu 3. In Change framework, ... checkmarks, checkmarks everywhere, and they don't change when you choose a different one, so after the first change you can't even tell what's current 4. Apply patch, Shift+Reload the advanced editor page to bypass the cache 5. Click the Setting menu, see that only the current framework has a checkmark, change to a different one and reopen the Settings menu, see that the one you changed to now has the only checkmark Sponsored-by: Chetco Community Public Library Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix checkmarks in Change |Fix checkmarks in change |framework menu in Advanced |framework menu in advanced |editor after Bootstrap5 |editor after Bootstrap5 |update |update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- BS5 isn't going to 24.05, so this won't need to either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38082 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38082 [Bug 38082] Advanced editor does not save the selected framework with new record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38057 Bug 38057 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org