[Bug 6574] New: js error in en-GB template breaks circulation toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Bug #: 6574 Summary: js error in en-GB template breaks circulation toolbar Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: emrysminnig@varndean.co.uk QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Line 20 of internet-tmpl/prog/en-GB/circ-toolbar.inc AND line 20 of internet-tmpl/prog/en-GB/members-toolbar.inc read: var is_confirmed = window.confirm(_('Are you sure you want to renew this user\\'s registration?')); It should read: var is_confirmed = window.confirm(_('Are you sure you want to renew this user\'s registration?')); This bug causes the buttons on the patron's 'circ' and 'details' pages to not display properly. Further, as a result, the 'Delete' button will not work. I'm not sure if this error appears in the templates for other languages. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |I18N/L10N AssignedTo|kyle.m.hall@gmail.com |frederic@tamil.fr --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-07-11 16:20:16 UTC --- Confirmed in a freshly-processed installation of en-GB and en-NZ translations. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-12-07 17:02:10 UTC --- *** Bug 7109 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #3 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- I also confirm this bug ib en-NZ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 --- Comment #4 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- The same issue is found in moremember.tt. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Using double quites instead of single quotes is currently the most used fix for this. It prevents translators from using double quotes in translations, but single quotes are more often used in a lot of languages. In the past I had problems with escaping in Pootle - \n was changed to \\n (double escaped) automatically. So I think not using escaping is safer. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 --- Comment #6 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 13831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13831&action=edit Bug 6574 - js error in en-GB template breaks circulation toolbar To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 --- Comment #7 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- I'm not really clear on how translations get from template -> pootle -> misc/translator/po -- there may be a step in testing necessary for that (like, grabbing the new .po from translate.koha-community.org or somesuch). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13831|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13983&action=edit [SIGNED-OFF] Bug 6574 - js error in en-GB template breaks circulation toolbar To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change, fixes reported problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|frederic@tamil.fr |liz@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: I did not test this patch, but it does not break anything and is in agreement with the result of the discussion of Bug 6574. Marked as Passed QA. Jared, this patch will be in conflict with Bug 6261. So I advice you to apply the patch of Bug 6261 before this one. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13983|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14270&action=edit Bug 6574 - js error in en-GB template breaks circulation toolbar To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change, fixes reported problem. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I believe this patch is unnecessary now that bug 6261 has been pushed. Could you please confirm that? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14270|0 |1 is obsolete| | --- Comment #12 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14304&action=edit Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #13 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- This last patch is based on the work of 6261, which was just pushed. It'll need a new signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14304|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14317&action=edit [SIGNED-OFF] Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Same as comment 9 Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14317|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14560&action=edit Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.2 and 3.8.9 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org