[Bug 8557] New: in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Priority: P5 - low Change sponsored?: --- Bug ID: 8557 Assignee: koha-bugs@lists.koha-community.org Summary: in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly Severity: enhancement Classification: Unclassified OS: All Reporter: christophe.croullebois@biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha in orderreceive when you receive an order with 'AcqCreateItem ' on 'receiving', you must first fill the 'Item' block and validating by clicking 'add' before clicking the 'save' button. Using a scan machine is like typing 'enter' and saving this receive, it is unwanted. For serials-edit it's the same problem. So this patch do the same in the two pages. To test: You must have a barcode scan... ;o) Or try to type enter without the patch, it's what the scan machine sends. thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 12392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12392&action=edit proposed patch thx for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12392|0 |1 is obsolete| | --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 12393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12393&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- I can confirm the behaviour without patch. However the patch does not longer apply: error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:422 error: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt: patch does not apply Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12393|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 12689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12689&action=edit Bug-8557-Prevents-form-validation-by-pressing-Enter.patch Rebased patch. Could you test now? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12689|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 12702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12702&action=edit [SIGNED-OFF] Bug 8557: Prevents form validation by pressing "Enter" this patch prevents a scan machine to send 'enter' to the form when it is not expected. The patch is on orderreceive.tt and serials-edit.tt. Written by Alex Arnaud. MT6626. Signed-off-by: Marc Veron <veron@veron.ch> Tested with receiving orders and receiving serials. Could reporduce problem befor applying the patch. After applying the patch both forms behaved as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 13167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13167&action=edit pic -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #0)
in orderreceive when you receive an order with 'AcqCreateItem ' on 'receiving', you must first fill the 'Item' block and validating by clicking 'add' before clicking the 'save' button. Using a scan machine is like typing 'enter' and saving this receive, it is unwanted. For serials-edit it's the same problem. So this patch do the same in the two pages. To test: You must have a barcode scan... ;o) Or try to type enter without the patch, it's what the scan machine sends.
hmmm, i need more info to QA this patch... do i need to scan a barcode in the 'barcode' field to test this patch? if i do this, the 'enter' key *is* detected and the form is saved, so the patch does not seem to work (in chrome-osx)? i have added a screenshot to explain what i am testing (the barcode field) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #8 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 13247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13247&action=edit snapshot without patch Hello James, in fact, I have pasted a snapshot. Without the patch if you hit "enter" in the orderreceive page, the form is submited, in my case I have not filled a requested field in order to make this state more visible. So, James, you don't need a scan machine, the machine sends a "enter" to koha. Without the patch if you hit enter (the same action than a scan) the form is submitted, what we need is that the scanning doesn't send the form. With the patch if you hit "enter" nothing happens, it's what we expect. Thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12702|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13660&action=edit [SIGNED-OFF] Bug 8557: Prevents form validation by pressing "Enter" this patch prevents a scan machine to send 'enter' to the form when it is not expected. The patch is on orderreceive.tt and serials-edit.tt. Written by Alex Arnaud. MT6626. Signed-off-by: Marc Veron <veron@veron.ch> Tested with receiving orders and receiving serials. Could reporduce problem befor applying the patch. After applying the patch both forms behaved as expected. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked order receive and serials edit page, barcode + enter does no longer submit the form. All tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Could someone please confirm that there is no situation where a library would want Enter to automatically save the barcode? If that is a feature that libraries might be using, I am loth to remove it entirely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's consistent with other item forms (cataloguing) this way and is more like the expected behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch --- Comment #12 from Marc Véron <veron@veron.ch> --- I agree with Katrin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was thinking about this. Maybe a good rule of thumb could be: if the barcode field is one of many fields (data entry) we don't want it to submit the form, but when it's only a barcode field we want it to. Would that make sense? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #14 from Marc Véron <veron@veron.ch> --- Makes sense! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I do not see any "Add" button nor anywhere to edit items on the order receive page on current master. I see a table with a list of items, and there are links to take me to edit the items, but hitting enter in the barcode field on those screens does not do anything. Please provide a detailed test plan covering the entire workflow I should be following, starting at the VERY beginning, so that I can test this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 13749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13749&action=edit Screenshot unwanted return while adding item during receiving process 1) Set syspref 'AcqCreateItem' to 'Create Item when receiving an order.' 2) Create a basket for a vendor, add an order line. 3) Search for this vendor using Vendor search 4) Receive Shipment for this vendor and choose the title you ordered in 2) 5) You will get the dialog to create related item(s) 6) Fill in Item 0 through o (see screenshot) 7) Scan Barcode for field p - Barcode 7) Result: Scanner sends a [return], form closes and you had no chance to fill in fields t - z -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13660|0 |1 is obsolete| | --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 13750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13750&action=edit [SIGNED-OFF] Bug 8641 [Follow up]-Reword warning about log-in as root user to About-System information The wording of this message sounds strange to a native speaker. Reword it. Signed-off-by: Marc Veron <veron@veron.ch> New wording appears as expected on about page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13750|0 |1 is obsolete| | --- Comment #18 from Marc Véron <veron@veron.ch> --- Comment on attachment 13750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13750 [SIGNED-OFF] Bug 8641 [Follow up]-Reword warning about log-in as root user to About-System information Sorry, mistaked with bug number... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13660|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. Marc, thank you for the detailed test plan. As a note, I observe that this still does not work quite right in Chrome -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #20 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #19)
This patch has been pushed to master. Marc, thank you for the detailed test plan. As a note, I observe that this still does not work quite right in Chrome
... which is submitting a different form when you hit the "Enter" key. It works perfectly in FF, though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x, will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 --- Comment #22 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14019&action=edit Bug 8557 - Unexpected behavior with scanners This is an alternative to the original implementation - this one works in chrome as well as firefox. To test: 1) Set syspref 'AcqCreateItem' to 'Create Item when receiving an order.' 2) Create a basket for a vendor, add an order line. 3) Search for this vendor using Vendor search 4) Receive Shipment for this vendor and choose the title you ordered in 2) 5) You will get the dialog to create related item(s) 6) Fill in Item 0 through o (see screenshot) 7) Scan Barcode for field p - Barcode 7) Result: Scanner sends a [return], form closes and you had no chance to fill in fields t - z -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |In Discussion CC| |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13660|0 |1 is obsolete| | Attachment #14019|0 |1 is obsolete| | --- Comment #23 from Marc Véron <veron@veron.ch> --- Created attachment 14325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14325&action=edit Bug 8557 - Unexpected behavior with scanners This is an alternative to the original implementation - this one works in chrome as well as firefox. To test: 1) Set syspref 'AcqCreateItem' to 'Create Item when receiving an order.' 2) Create a basket for a vendor, add an order line. 3) Search for this vendor using Vendor search 4) Receive Shipment for this vendor and choose the title you ordered in 2) 5) You will get the dialog to create related item(s) 6) Fill in Item 0 through o (see screenshot) 7) Scan Barcode for field p - Barcode 7) Result: Scanner sends a [return], form closes and you had no chance to fill in fields t - z Signed-off-by: Marc Veron <veron@veron.ch> Testted with Chrome Version 23.0.1271.97 m and Firefox 17.0.1, both behave as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14325|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14556&action=edit [SIGNED-OFF] Bug 8557 - Unexpected behavior with scanners This is an alternative to the original implementation - this one works in chrome as well as firefox. To test: 1) Set syspref 'AcqCreateItem' to 'Create Item when receiving an order.' 2) Create a basket for a vendor, add an order line. 3) Search for this vendor using Vendor search 4) Receive Shipment for this vendor and choose the title you ordered in 2) 5) You will get the dialog to create related item(s) 6) Fill in Item 0 through o (see screenshot) 7) Scan Barcode for field p - Barcode 7) Result: Scanner sends a [return], form closes and you had no chance to fill in fields t - z Signed-off-by: Marc Veron <veron@veron.ch> Tested with Chrome Version 23.0.1271.97 m and Firefox 17.0.1, both behave as expected. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with Firefox and Chromium in Ubuntu. Additional test done: 1) Add a new subscription, choose 'receive adds items' 2) Receive an issue, fill out $p with a barcode 3) Make sure hitting enter in the barcode field does not send the form. All tests pass and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #26 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org