[Bug 20552] New: Fix HTML tag for search facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Bug ID: 20552 Summary: Fix HTML tag for search facets Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: claire_gravely@hotmail.com QA Contact: testopia@bugs.koha-community.org The tags for home library and holding library in the 'refine your search' list should be h5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |claire_gravely@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 --- Comment #1 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 73925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73925&action=edit Bug 20552: Fix HTML tag for search facets The tags for home library and holding library in the 'refine your search' list should be h5. This patch changes the html tag for the holding library and home library facets. To test: - Search for an item in the OPAC where the relevant facet appears - Use 'Inspect element' to check the tag - Apply patch - Confirm the facet now has the h5 tag - Confirm spacing is improved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73925|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 73926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73926&action=edit Bug 20552: Fix HTML tag for search facets The tags for home library and holding library in the 'refine your search' list should be h5. This patch changes the html tag for the holding library and home library facets. To test: - Search for an item in the OPAC where the relevant facet appears - Use 'Inspect element' to check the tag - Apply patch - Confirm the facet now has the h5 tag - Confirm spacing is improved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73926|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 73928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73928&action=edit Bug 20552: Fix HTML tag for search facets The tags for home library and holding library in the 'refine your search' list should be h5. This patch changes the html tag for the availability, holding library and home library facets. To test: - Search for an item in the OPAC where the relevant facet appears - Use 'Inspect element' to check the tag - Apply patch - Confirm the facet now has the h5 tag - Confirm spacing is improved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73928|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73929&action=edit Bug 20552: Fix HTML tag for search facets The tags for home library and holding library in the 'refine your search' list should be h5. This patch changes the html tag for the availability, holding library and home library facets. To test: - Search for an item in the OPAC where the relevant facet appears - Use 'Inspect element' to check the tag - Apply patch - Confirm the facet now has the h5 tag - Confirm spacing is improved Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 [Bug 20554] New OPAC CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73929|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73991&action=edit Bug 20552: Fix HTML tag for search facets The tags for home library and holding library in the 'refine your search' list should be h5. This patch changes the html tag for the availability, holding library and home library facets. To test: - Search for an item in the OPAC where the relevant facet appears - Use 'Inspect element' to check the tag - Apply patch - Confirm the facet now has the h5 tag - Confirm spacing is improved Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.06 Awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org