[Bug 36459] New: Backdating checkouts on circ/circulation.pl not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Bug ID: 36459 Summary: Backdating checkouts on circ/circulation.pl not working properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Go to circ/circulation.pl and check an item out to a patron. 2. Backdate it to sometime in the past using the "Specify due date (MM/DD/YYYY) : " input 3. A modal appears to "Please confirm checkout". The date is no longer populated in that field. 4. You must add the date again here. This is due to Bug 18885. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885 [Bug 18885] When 'on-site checkout' was used, the 'Specify due date' should be emptied for next checkout unless OnSiteCheckoutAutoCheck -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- This highlights the fact that there are multiple '#duedatespec' on the same page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167124&action=edit Bug 36459: Do not set an empty flatpickr explicitly To test; 1. Go to circ/circulation.pl and check an item out to a patron. 2. Backdate it to sometime in the past using the "Specify due date (MM/DD/YYYY) : " input 3. A modal appears to "Please confirm checkout". The date is no longer populated in that field. 4. You must add the date again here. 5. APPLY PATCH 6. Try again and this time the confimration date should be set correctly. 7. Follow the test plan from Bug 18885 to make sure on site checkouts still work correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucas Gass from comment #1)
This highlights the fact that there are multiple '#duedatespec' on the same page.
I didn't address this with my patch but we should do so. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36494 [Bug 36494] Flatpickr error on checkout page if the patron is blocked from checking out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167124|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 167127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167127&action=edit Bug 36459: Do not set an empty flatpickr explicitly To test; 1. Go to circ/circulation.pl and check an item out to a patron. 2. Backdate it to sometime in the past using the "Specify due date (MM/DD/YYYY) : " input 3. A modal appears to "Please confirm checkout". The date is no longer populated in that field. 4. You must add the date again here. 5. APPLY PATCH 6. Try again and this time the confimration date should be set correctly. 7. Follow the test plan from Bug 18885 to make sure on site checkouts still work correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- This does break 18885, I'm afraid: 1. Have OnSiteCheckouts enabled and OnSiteAutoCheck disabled 2. Go to circulation.pl 3. Check the checkbox for on-site checkout --> The checkout date is auto-populated with today's date 4. Check out an item --> When the page reloads, the checkbox is no longer checked, but the checkout date is still populated In the use case you're aiming to fix here, though, on-site checkouts was never checked in the first place...so why is #duedatespec being cleared at all? I think there's something deeper going on here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Emily Lamancusa from comment #5)
This does break 18885, I'm afraid:
1. Have OnSiteCheckouts enabled and OnSiteAutoCheck disabled 2. Go to circulation.pl 3. Check the checkbox for on-site checkout --> The checkout date is auto-populated with today's date 4. Check out an item --> When the page reloads, the checkbox is no longer checked, but the checkout date is still populated
In the use case you're aiming to fix here, though, on-site checkouts was never checked in the first place...so why is #duedatespec being cleared at all? I think there's something deeper going on here.
Are you sure? In my testing steps 1-4 only work when my patch from this bug is applied. Without this patch: -I check the on-site checkbox, today's date is populated. -I checkout an item, both the checkbox and the due date is cleared With my patch: -I check the on-site checkbox, today's date is populated. -I checkout an item, the checkbox is cleared but the date remains. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167676&action=edit Bug 36459: Do not duplicate duedatespec IDs To test; 1. Go to circ/circulation.pl and check an item out to a patron. 2. Backdate it to sometime in the past using the "Specify due date (MM/DD/YYYY) : " input 3. A modal appears to "Please confirm checkout". The date is no longer populated in that field. 4. You must add the date again here. 5. APPLY PATCH 6. Try again and this time the confimration date should be set correctly. 7. Follow the test plan from Bug 18885 to make sure on site checkouts still work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Completely new patch, so resetting to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167676|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167684&action=edit Bug 36459: Do not duplicate duedatespec IDs To test; 1. Go to circ/circulation.pl and check an item out to a patron. 2. Backdate it to sometime in the past using the "Specify due date (MM/DD/YYYY) : " input 3. A modal appears to "Please confirm checkout". The date is no longer populated in that field. 4. You must add the date again here. 5. APPLY PATCH 6. Try again and this time the confimration date should be set correctly. 7. Follow the test plan from Bug 18885 to make sure on site checkouts still work correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167684|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167693&action=edit Bug 36459: Do not duplicate duedatespec IDs To test; 1. Go to circ/circulation.pl and check an item out to a patron. 2. Backdate it to sometime in the past using the "Specify due date (MM/DD/YYYY) : " input 3. A modal appears to "Please confirm checkout". The date is no longer populated in that field. 4. You must add the date again here. 5. APPLY PATCH 6. Try again and this time the confimration date should be set correctly. 7. Follow the test plan from Bug 18885 to make sure on site checkouts still work correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #11 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks for the new patch and signoff! Looks good and works as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 37332 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.02 released in| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #16 from wainuiwitikapark@catalyst.net.nz --- not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes setting a due release notes| |date in the past when | |checking out an item to a | |patron. The date entered | |was not remembered and not | |displayed on the "Please | |confirm checkout" message - | |you had to select and add | |the date again. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #17 from Phil Ringnalda <phil@chetcolibrary.org> --- Backporting to 23.05.x actually was sort of requested by comment 0, since this bug was filed because Lucas wasn't going to backport bug 18885 to 23.05.x unless this was fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Phil Ringnalda from comment #17)
Backporting to 23.05.x actually was sort of requested by comment 0, since this bug was filed because Lucas wasn't going to backport bug 18885 to 23.05.x unless this was fixed.
Sorry, 23.05.x is no longer maintained now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459 Bug 36459 depends on bug 18885, which changed state. Bug 18885 Summary: When 'on-site checkout' was used, the 'Specify due date' should be emptied for next checkout unless OnSiteCheckoutAutoCheck https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org