[Bug 42639] New: Change gender field from radio buttons to dropdown and add the the missing "required" tag.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 Bug ID: 42639 Summary: Change gender field from radio buttons to dropdown and add the the missing "required" tag. Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: bosse@gustavsson.one QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 38361: (Follow-up) Fix mandatory gender field in the staff interface To reproduce: 1. Find the system setting 'BorrowerMandatoryField' and mark 'Gender (sex)' as required. 2. Edit an existing patron or create a new one. No 'Required' label under the gender section. The gender field should also be a dropdown instead of a set of radio buttons for consistency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 Bo Gustavsson <bosse@gustavsson.one> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bosse@gustavsson.one Assignee|koha-bugs@lists.koha-commun |bosse@gustavsson.one |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Bo Gustavsson <bosse@gustavsson.one> --- Created attachment 199278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199278&action=edit Bug 42639: Change gender field from radio buttons to dropdown and add the the missing "required" tag. Adds the missing 'required' label if to gender field when creating a new patron or editing an existing one. This also updates the section from using radio buttons to a more convenient dropdown menu. To test: 1. Apply this patch 2. Find the system setting 'BorrowerMandatoryField' and mark 'Gender (sex)' as required. 3. Edit an existing patron or create a new one. You should see the 'Required' label under the gender section. There should also be a dropdown menu to choose the gender with, instead of the old radio buttons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- The Required label fix makes sense, but I don't believe that the change from radio buttons to a select improves usability or accessibility. Radio buttons are generally preferred for small sets of mutually exclusive visible choices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Owen, Brendan could either of you take a look at let me know if I'm overthinking this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Laura Escamilla from comment #2)
Radio buttons are generally preferred for small sets of mutually exclusive visible choices.
I agree with this. To me the radio buttons seem easier to use because I can see all the options and select one with one click. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 --- Comment #5 from Bo Gustavsson <bosse@gustavsson.one> --- Well, it's a personal preference. I'll provide an updated patch with the old radio buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- I also agree that for short sets of mutually exclusive options, radio buttons would be better for useability. As Owen mentioned you can easily see all options and to it's one click instead of two to set it. On the other hand, some people may prefer the arguably cleaner look of a dropdown, especially in the context of when a record already exists and it's just being edited. In this case the relevant info is the the currently selected value, and two clicks would make it less prone to accidentally changing than the radio buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38361 Summary|Change gender field from |Change gender field from |radio buttons to dropdown |radio buttons to dropdown |and add the the missing |and add the the missing |"required" tag. |"required" tag CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #4)
(In reply to Laura Escamilla from comment #2)
Radio buttons are generally preferred for small sets of mutually exclusive visible choices.
I agree with this. To me the radio buttons seem easier to use because I can see all the options and select one with one click.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 --- Comment #8 from Bo Gustavsson <bosse@gustavsson.one> --- (In reply to Katrin Fischer from comment #7)
(In reply to Owen Leonard from comment #4)
(In reply to Laura Escamilla from comment #2)
Radio buttons are generally preferred for small sets of mutually exclusive visible choices.
I agree with this. To me the radio buttons seem easier to use because I can see all the options and select one with one click.
+1
Well, in that case, shouldn’t we change the “Salutation”, “Relationship”, and “Show barcode on the summary screen item listings” dropdowns to radio buttons as well to maintain consistency across the page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42639 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Salutation and relationship can contain many many values depending on the setup as both lists are configurable. So I don't think it radio boxes would work for those. A yes/no kinda question like "show barcode" could be changed - but this is a configured patron attribute with an authorised value as base and again, could contain many entries. If at all it could be a new option for how patron attributes can be displayed. I believe there is a "checkbox" enhancement request out there already maybe. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org