https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75719&action=edit Bug 20851: Add module to circ/article-request-slip.pl See bug 20468, comment7. Although the script seems to compile well, we better add the module here. Trivial change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving trivial fix to SO rightaway -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #3)

I don't see a sign off or a test plan. What is this supposed to fix?

Printing article request slips works without problems for me. Can you please explain and reset to needs signoff?

LOL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5)

If you think my request is so silly, maybe you should epxlain it anyway.

Sure :) As mentioned in comment1 Owen got an error. And you and I did not (see also commit message). The error comes from a missing module; might be a devbox config issue for Owen. But the script itself calls C4::Letters but does not load it. So it depends on implicit loading by one of the other modules or deeper down the chain. We should not assume it will be loaded. If one day Letters is removed elsewhere, the script does not compile. So what does this oneliner do: add the missing module for that reason. Which is indeed stated ultra compact in the commit msg. No test plan needed. Back to SO. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- This indeed fixes the error I was getting in my devbox. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75764|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75792&action=edit Bug 20851: Add module to circ/article-request-slip.pl See bug 20468, comment7. Although the script seems to compile well, we better add the module here. Trivial change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #10)

Thanks, Owen, for the sign-off and retesting. Article slips still work for me.

Thx Katrin for QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.