[Bug 39561] New: Users with only editcatalogue: fast_cataloguing cannot add an item if a duplicate is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Bug ID: 39561 Summary: Users with only editcatalogue: fast_cataloguing cannot add an item if a duplicate is found Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To recreate: 1 - Create or choose a borrower and grant permissions: catalogus circulate borrowers: list_borrowers editcatalogue: fast_cataloguing 2 - Log in as that patron 3 - Search for another borrower and go to checkout screen 4 - Enter random string as barcode to checkout 5 - Item is not found, click to fast catalogue 6 - In the editor type into 245$a 'Perl best practices' - or another title that exists in your system 7 - Get a notice of duplicate with options: Yes: View existing items No, save as new record 8 - Both options take you to the record details page and you cannot add an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Users with only |Users with only |editcatalogue: |editcatalogue: |fast_cataloguing cannot add |fast_cataloging cannot |an item if a duplicate is |easily add an item if a |found |duplicate is found -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180623&action=edit Bug 39561: Allow users with fast_cataloging to continue after duplicate is found This patch adds the fast_cataloging permission to those checked when a duplicate is found Additionally, the barcode was missing from the duplicate check and is now added to be passed forward To test: 1 - Create or choose a borrower and grant permissions: catalogue circulate borrowers: list_borrowers editcatalogue: fast_cataloguing 2 - Log in as that patron 3 - Search for another borrower and go to checkout screen 4 - Enter random string as barcode to checkout 5 - Item is not found, click to fast catalogue 6 - In the editor type into 245$a 'Perl best practices' - or another title that exists in your system 7 - Get a notice of duplicate with options: Yes: View existing items No, save as new record 8 - Clicking 'Yes' will take you to the record details page - you cannot add an item because record is not FA framework 9 - You can click 'back' to return to the messages 10 - Clicking 'No' will create a new record and take you to the details page - you can add an item (Edit->manage items) but barcode has been dropped 11 - Apply patch 12 - Repeate 3-6 13 - You now get options: Yes: View existing items (you cannot add items to an existing record) No, save as new record 14 - 'Yes' will take you to details view 15 - Click back 16 - 'No' will take you to the edit items screen and populate the barcode 17 - Saving the item should return you to patron and issue item 18 - Repeat again with a staff patron with full permissions and confirm saying 'Yes' completes the fast catalogin workflow as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This could use another improvement - I am not sure the correct behavior when a duplicate is found but user can only fast catalogue - should they always add a new record? They cannot add items to existing records, so should we just skip the check? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- According to me in bug 37702, we shouldn't skip the check, we should check only for duplicate fast add records, since in that case can do something with the knowledge that they were creating a record that looks like a duplicate of another fast add. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- *** Bug 37702 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #3)
According to me in bug 37702, we shouldn't skip the check, we should check only for duplicate fast add records, since in that case can do something with the knowledge that they were creating a record that looks like a duplicate of another fast add.
Made 37702 a duplicate here and added 39590 to improve handling of duplicates. This bug should still be able to move forward -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180623|0 |1 is obsolete| | --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 180886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180886&action=edit Bug 39561: Allow users with fast_cataloging to continue after duplicate is found This patch adds the fast_cataloging permission to those checked when a duplicate is found Additionally, the barcode was missing from the duplicate check and is now added to be passed forward To test: 1 - Create or choose a borrower and grant permissions: catalogue circulate borrowers: list_borrowers editcatalogue: fast_cataloguing 2 - Log in as that patron 3 - Search for another borrower and go to checkout screen 4 - Enter random string as barcode to checkout 5 - Item is not found, click to fast catalogue 6 - In the editor type into 245$a 'Perl best practices' - or another title that exists in your system 7 - Get a notice of duplicate with options: Yes: View existing items No, save as new record 8 - Clicking 'Yes' will take you to the record details page - you cannot add an item because record is not FA framework 9 - You can click 'back' to return to the messages 10 - Clicking 'No' will create a new record and take you to the details page - you can add an item (Edit->manage items) but barcode has been dropped 11 - Apply patch 12 - Repeate 3-6 13 - You now get options: Yes: View existing items (you cannot add items to an existing record) No, save as new record 14 - 'Yes' will take you to details view 15 - Click back 16 - 'No' will take you to the edit items screen and populate the barcode 17 - Saving the item should return you to patron and issue item 18 - Repeat again with a staff patron with full permissions and confirm saying 'Yes' completes the fast catalogin workflow as expected Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180886|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182272&action=edit Bug 39561: Allow users with fast_cataloging to continue after duplicate is found This patch adds the fast_cataloging permission to those checked when a duplicate is found Additionally, the barcode was missing from the duplicate check and is now added to be passed forward To test: 1 - Create or choose a borrower and grant permissions: catalogue circulate borrowers: list_borrowers editcatalogue: fast_cataloguing 2 - Log in as that patron 3 - Search for another borrower and go to checkout screen 4 - Enter random string as barcode to checkout 5 - Item is not found, click to fast catalogue 6 - In the editor type into 245$a 'Perl best practices' - or another title that exists in your system 7 - Get a notice of duplicate with options: Yes: View existing items No, save as new record 8 - Clicking 'Yes' will take you to the record details page - you cannot add an item because record is not FA framework 9 - You can click 'back' to return to the messages 10 - Clicking 'No' will create a new record and take you to the details page - you can add an item (Edit->manage items) but barcode has been dropped 11 - Apply patch 12 - Repeate 3-6 13 - You now get options: Yes: View existing items (you cannot add items to an existing record) No, save as new record 14 - 'Yes' will take you to details view 15 - Click back 16 - 'No' will take you to the edit items screen and populate the barcode 17 - Saving the item should return you to patron and issue item 18 - Repeat again with a staff patron with full permissions and confirm saying 'Yes' completes the fast catalogin workflow as expected Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA CC| |martin.renvoize@openfifth.c | |o.uk Blocks| |39590 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Keeping this moving as i's a bit of a blocking action right now.. Passing QA. Follow-up work to be on bug 39590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39590 [Bug 39590] Better handling of fast add duplicates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39561 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org