[Bug 20507] New: Shelf browser does not update image sources when paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Bug ID: 20507 Summary: Shelf browser does not update image sources when paging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When using a cover source other than Amazon (which uses static links) the shelf browser does not fire a call to the image sources when moving to a new page To recreate: Enable coce (https://coce.bywatersolutions.com) and enable all sources except amazon Enable shelf browser View a title in the opac View the shelf browser, note images load on first page Page left or right and note images are not loaded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76436&action=edit Bug 20507: Shelf browser does not update image sources when paging This patch updates the shelfbrowser include so that the system preference check for Coce will function correctly. To test, apply the patch and test the OPAC shelf browser with each of the enhanced content options enabled: Coce, Amazon, Google. In each case, page through the shelf browser to confirm that covers load correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bibliwho@gmail.com --- Comment #2 from Cab Vinton <bibliwho@gmail.com> --- (In reply to Owen Leonard from comment #1)
Created attachment 76436 [details] [review] Bug 20507: Shelf browser does not update image sources when paging
This patch updates the shelfbrowser include so that the system preference check for Coce will function correctly.
To test, apply the patch and test the OPAC shelf browser with each of the enhanced content options enabled: Coce, Amazon, Google. In each case, page through the shelf browser to confirm that covers load correctly.
The patch seemed to work fine in Sandbox 06, clearing the cache for each content option. Several items had covers missing, but these all appeared to titles for which no covers were available in the first place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Cab, you can also mark the patch as signed off from the sandboxes by using the form at the bottom. We can add your name in QA for this one, maybe for your next! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #4 from Cab Vinton <bibliwho@gmail.com> --- (In reply to Katrin Fischer from comment #3)
Hi Cab, you can also mark the patch as signed off from the sandboxes by using the form at the bottom. We can add your name in QA for this one, maybe for your next!
OK, thank you, Katrin. Was thinking I should post on BugZilla, where it's just as easy to update the status. But that's probably not necessary ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Cab Vinton from comment #4)
(In reply to Katrin Fischer from comment #3)
Hi Cab, you can also mark the patch as signed off from the sandboxes by using the form at the bottom. We can add your name in QA for this one, maybe for your next!
OK, thank you, Katrin. Was thinking I should post on BugZilla, where it's just as easy to update the status. But that's probably not necessary ...
Setting the status is alright, but using the sign-off feature will also add your name as a sign-off to the patches, which will make your name go into release notes etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... also your sign-offs made my day, thx! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #7 from Cab Vinton <bibliwho@gmail.com> --- Ah, gotcha. Excellent. The tutorial video was helpful. Think developers should add a code to the bugs needing Sign Offs -- TBAI (Testable by Any Idiot) ;-) With several hundred bugs, it can take some time to identify the ones that don't require CLI access, don't have too many moving parts, etc. Not complaining by any means, but it might increase the number of bugs that get signed off by everyday librarians, which should be a good thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76436|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76718&action=edit Bug 20507: Shelf browser does not update image sources when paging This patch updates the shelfbrowser include so that the system preference check for Coce will function correctly. To test, apply the patch and test the OPAC shelf browser with each of the enhanced content options enabled: Coce, Amazon, Google. In each case, page through the shelf browser to confirm that covers load correctly. Signed-off-by: Cab Vinton <bibliwho@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Cab Vinton from comment #7)
Ah, gotcha.
Excellent. The tutorial video was helpful.
Excellent? But I still had to add your signoff line ;) Would you not forget next time ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org