[Bug 16305] New: Remove the use of "onclick" from transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16305 Bug ID: 16305 Summary: Remove the use of "onclick" from transport cost matrix Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/transport-cost-matrix.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org, veron@veron.ch There are a few places in the transport cost matrix template where event attributes (onclick, onblur) are used. These should be rewritten so that JS functionality can be separate from the markup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16305 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16305 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50450&action=edit Bug 16305 - Remove the use of "onclick" from transport cost matrix This patch updates the transport cost matrix template to eliminate the use of event attributes (onclick and onblur) in favor of JS separate from the markup. To test, apply the patch and go to Administration -> Transport cost matrix. - Click in any table cell. Form fields in the cell should activate. - Check and uncheck the "disable" checkbox. The form field should be correctly disabled and enabled. - Fill various enabled fields and submit the form to confirm that data is saved correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16305 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50450|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 50455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50455&action=edit Bug 16305 - Remove the use of "onclick" from transport cost matrix This patch updates the transport cost matrix template to eliminate the use of event attributes (onclick and onblur) in favor of JS separate from the markup. To test, apply the patch and go to Administration -> Transport cost matrix. - Click in any table cell. Form fields in the cell should activate. - Check and uncheck the "disable" checkbox. The form field should be correctly disabled and enabled. - Fill various enabled fields and submit the form to confirm that data is saved correctly. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16305 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16305 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16305 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50455|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50624&action=edit [PASSED QA] Bug 16305 - Remove the use of "onclick" from transport cost matrix This patch updates the transport cost matrix template to eliminate the use of event attributes (onclick and onblur) in favor of JS separate from the markup. To test, apply the patch and go to Administration -> Transport cost matrix. - Click in any table cell. Form fields in the cell should activate. - Check and uncheck the "disable" checkbox. The form field should be correctly disabled and enabled. - Fill various enabled fields and submit the form to confirm that data is saved correctly. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16305 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org