[Bug 18660] New: Translatability: Get rid of template directives [ %% in translation for patroncards-errors.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Bug ID: 18660 Summary: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like %%]%s %sLayout: [%% -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63658&action=edit Bug 18660: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like: %%]%s %sLayout: [%% This patch fixes it To test: - Verify that code changes make sense - Apply patch - Create a translation (cd misc/translator , then: perl translate create aa-AA - Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%% for patroncards-errors.inc - Try to get an error: Try a link like http://[YOUR SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1 ...where template_id and layout_id do not exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marc, The block now displays like: 551 msgid "" 552 "%s %s %s %s The database returned an error while %ssaving %s %s%sattempting " 553 "a save operation%s. %s %s The database returned an error while %sdeleting %s " 554 "%s%s%s%sattempting a delete operation%s. %s %s An unsupported operation was " 555 "attempted%s on %s %s%s. %s %s An error has occurred. %s %s A non-existent or " 556 "invalid library code was supplied. Please verify that you have a library " 557 "set. " Adding <span> around the strings will avoid the %s and we will get one entry per message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 --- Comment #3 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #2) (...)
Adding <span> around the strings will avoid the %s and we will get one entry per message.
Good idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63658|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 64014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64014&action=edit Bug 18660: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like: %%]%s %sLayout: [%% This patch fixes it To test: - Verify that code changes make sense - Apply patch - Create a translation (cd misc/translator , then: perl translate create aa-AA - Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%% for patroncards-errors.inc - Try to get an error: Try a link like http://[YOUR SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1 ...where template_id and layout_id do not exist (Amended for comment #2 2017-06-05 mv) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 --- Comment #5 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I still see some problematic areas: #. %1$s: IF ( element_id ) #. %2$s: card_element #. %3$s: element_id #. %4$s: END #: intranet-tmpl/prog/en/includes/patroncards-errors.inc:30 #, c-format msgid "An unsupported operation was attempted%s on %s %s%s. " msgstr "" I notice some lines where there is a placeholder which doesn't belong. I think some simple whitespace problems? #. %1$s: END #: intranet-tmpl/prog/en/includes/patroncards-errors.inc:28 #, c-format msgid "The database returned an error while attempting a delete operation%s. " msgstr "" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64014|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 65427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65427&action=edit Bug 18660: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like: %%]%s %sLayout: [%% This patch fixes it To test: - Verify that code changes make sense - Apply patch - Create a translation (cd misc/translator , then: perl translate create aa-AA - Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%% for patroncards-errors.inc - Try to get an error: Try a link like http://[YOUR SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1 ...where template_id and layout_id do not exist (Amended for comment #2 2017-06-05 mv) (Amended for comment #6 2017-08-02 mv) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65427|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65433&action=edit [SIGNED-OFF] Bug 18660: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like: %%]%s %sLayout: [%% This patch fixes it To test: - Verify that code changes make sense - Apply patch - Create a translation (cd misc/translator , then: perl translate create aa-AA - Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%% for patroncards-errors.inc - Try to get an error: Try a link like http://[YOUR SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1 ...where template_id and layout_id do not exist (Amended for comment #2 2017-06-05 mv) (Amended for comment #6 2017-08-02 mv) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65433|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66639&action=edit Bug 18660: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like: %%]%s %sLayout: [%% This patch fixes it To test: - Verify that code changes make sense - Apply patch - Create a translation (cd misc/translator , then: perl translate create aa-AA - Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%% for patroncards-errors.inc - Try to get an error: Try a link like http://[YOUR SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1 ...where template_id and layout_id do not exist (Amended for comment #2 2017-06-05 mv) (Amended for comment #6 2017-08-02 mv) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.17 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org