[Bug 15707] New: Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

31 Jan 2016 31 Jan '16

12:32 p.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Bug ID: 15707 Summary: Add ability to define hierarchical groups of libraries Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Koha needs the ability to create hierarchical groups of libraries. This ability could be used in many areas of Koha to make Koha much more flexible and consortium friendly. -- You are receiving this mail because: You are watching all bug changes.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

31 Jan 31 Jan

12:36 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:30 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47734&action=edit Bug 15707 - Unit Tests -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Feb 8 Feb

9:27 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Obvious test case to check for fails does. Make root Make sub group Add some libraries off both. Attempt to delete root. "Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Cannot delete or update a parent row: a foreign key constraint fails (`koha_library`.`library_groups`, CONSTRAINT `library_groups_ibfk_1` FOREIGN KEY (`parent_id`) REFERENCES `library_groups` (`id`)) at /home/mtompset/kohaclone/Koha/Object.pm line 155 For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error." Treegrid library does add. Updates both fresh and update work. Given that the Unit Tests work, I believe the new modules and schema files function. There is a nice about page entry. So, this is purely an "Add editor" patch issue. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:29 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Deletion from bottom up does work, however. :) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 Feb 9 Feb

5:22 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #15)

...

Deletion from bottom up does work, however. :)

Thanks for testing! Deleting a group with children should have worked, I'm guessing my ON DELETE isn't quite right. I'll look into it! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:34 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- I've been unable to reproduce your error. Here's is a video of my testing: http://screencast.com/t/cM1Duz9y Am I not taking the same steps as you were? Can you reproduce the issue repeatedly? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:03 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Kyle M Hall from comment #17)

...

I've been unable to reproduce your error. Here's is a video of my testing: http://screencast.com/t/cM1Duz9y

Am I not taking the same steps as you were? Can you reproduce the issue repeatedly?

One question. Were you running from user account or system account? Where you running from an upgrade or a fresh install? My scenario, I drop'd the db, created an empty one, did the web install and was using the system account. root -> group 1 -> subgroup 1 & subgroup 2 add libraries to subgroup 1 & subgroup 2 attempt to delete root. I'll reattempt after lunch. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:47 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #18) For the record, I was using a user account and tested via upgrade. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:13 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- Preliminary setup: http://screencast.com/t/AtYoC3pJY Actual test explosion: http://screencast.com/t/SgusNdiT I noticed in the replay that Koha Admin is Midway, and Midway was one of the libraries I added. I don't know if that has anything to do with it, but I thought I'd mention that. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Feb 10 Feb

3:10 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

3:11 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47855&action=edit Bug 15707 - Unit Tests -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:13 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #20)

...

Preliminary setup: http://screencast.com/t/AtYoC3pJY Actual test explosion: http://screencast.com/t/SgusNdiT

I noticed in the replay that Koha Admin is Midway, and Midway was one of the libraries I added. I don't know if that has anything to do with it, but I thought I'd mention that.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

15 Feb 15 Feb

6:23 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

6:24 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48072&action=edit Bug 15707: Fix conflict with bug 15446 (type vs _type) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Apr 19 Apr

3:37 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:37 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47868|0 |1 is obsolete| | Attachment #47869|0 |1 is obsolete| | Attachment #47870|0 |1 is obsolete| | Attachment #47871|0 |1 is obsolete| | Attachment #47872|0 |1 is obsolete| | Attachment #47873|0 |1 is obsolete| | Attachment #47874|0 |1 is obsolete| | Attachment #48072|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 50400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50400&action=edit Bug 15707 - Update DB Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

3:43 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #37)

...

Kyle, 1/ Could you provide a test plan?

Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to Administration/Library groups 4) Create a new group via the add group button 5) Create one or more subgroups in this group 6) Add libraries to the group and subgroups 7) Add another top level group via the add group button 8) Try adding groups and libraries to this group 9) Test editing a group 10) Test deleting a group 11) Test removing a library from a group

...

2/ What's next for these library groups? What's the difference with our existing groups? Is there a plan to move the existing ones to this new table? 3/ We already have a treetable plugin (compatible with DataTables), is there a reason to add another one?

I had thought the treetable plugin wouldn't work well in this instance, but I gave treetables a shot and it looks almost identical. I've removed the patch that adds the treegrid library and have added a follow switching to treetables. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:47 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #37)

...

2/ What's next for these library groups? What's the difference with our existing groups? Is there a plan to move the existing ones to this new table?

Bug 15708 is my first enhancement that will take advantage of this. However, I think there will be many other possible uses for this system in the future. The existing groups function is not actually used anywhere in Koha and should probably be removed. The search groups could go either way, but are fine the way they are. What makes this far more powerful is the ability to define hierarchical group structures. This will be a cornerstone for making Koha much more usable in consortial library settings. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Jun 12 Jun

11:18 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52275&action=edit Bug 15707: QA follow-up - Drop table if exists 1/ DROP table if exists 2/ FAIL spelling decendents ==> descendants -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:26 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #49)

...

(In reply to Jonathan Druart from comment #37)

...
2/ What's next for these library groups? What's the difference with our existing groups? Is there a plan to move the existing ones to this new table?

Bug 15708 is my first enhancement that will take advantage of this. However, I think there will be many other possible uses for this system in the future. The existing groups function is not actually used anywhere in Koha and should probably be removed. The search groups could go either way, but are fine the way they are.

What makes this far more powerful is the ability to define hierarchical group structures. This will be a cornerstone for making Koha much more usable in consortial library settings.

It is weird to have 2 "library groups" features and I think the first step should be to replace the existing one. The existing feature is used in the advanced search form and should work. Moreover I'd like to get Owen opinion on the modal you use to create/update a new entry. I am going to ping him on IRC. There are also some inconsistencies on styles, the confirmation of add/update is a warning (orange) Keeping it in the Signed Off queue to get other opinions. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:28 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also it might be odd to have a new feature not doing anything (if pushed as it) :) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:32 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The following patch could be obsoleted: Bug 15707 - Add TreeGrid library to about page -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Jun 13 Jun

2:58 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #62 from Owen Leonard <oleonard@myacpl.org> ---

...

(In reply to Jonathan Druart from comment #59) It is weird to have 2 "library groups" features and I think the first step should be to replace the existing one.

I agree. It is confusing to have two menu items on the administration page, "Libraries and groups" and "Library groups." I think we should think of a way to manage all this functionality in one section. Some other comments: - Nowhere else do we use the "fa-plus-circle" icon for "add." We always use "fa-plus." - Nowhere else in Koha do we use a modal to display an add form. We either display a form on a separate page or we use JS to show/hide the edit form on the page to mimic the display of a separate page. See admin/items_search_fields.pl for example. - Nowhere else in Koha do we use the "fa-edit" icon for "edit." We always use "fa-pencil." - When displaying confirmation messages we use '<div class="dialog message">' not '<div class="dialog alert">' - There is no reason to display an icon ("<i class="fa fa-object-group"></i>") next to each group. It doesn't serve any function. - There is no reason to display an icon ("<i class="fa fa-home"></i>") next to each library in a group. It doesn't serve any function. - Nowhere else in Koha do we use "fa-minus-circle" to mean "remove." It should be "fa-trash." - Nowhere else in Koha do we add an icon to the "actions" menu. - Nowhere else in Koha do we use a modal to display a delete confirmation message. I think I could be convinced that we should, but I'd like to hear the argument. If we do, we should use the space given to display more information about the deletion than this implementation does, e.g. what exactly am I deleting? - Instead of a "home" icon for "Add library" I think it should be the "plus" icon which is associated with adding or creating something. - The list of libraries in the "Add library" dropdown should be alphabetized by library name, not library code. - This patch adds five new instances of "onclick." I've been working very hard to eliminate the use of "onclick" and I don't think new patches should add them. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Jun 14 Jun

1:54 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> ---

...

I agree. It is confusing to have two menu items on the administration page, "Libraries and groups" and "Library groups." I think we should think of a way to manage all this functionality in one section.

These two sub-systems are completely unrelated. They really don't belong together. I'd be more than happy to rename it "Library hierarchies" if you find that acceptable, or to rename the existing groups to "search groups" which is what they are.

...

Some other comments:

- Nowhere else do we use the "fa-plus-circle" icon for "add." We always use "fa-plus."

Changed with followup.

...

- Nowhere else in Koha do we use a modal to display an add form. We either display a form on a separate page or we use JS to show/hide the edit form on the page to mimic the display of a separate page. See admin/items_search_fields.pl for example.

You are correct, but I believe the modal may be a better paradigm. Would you disagree? It means we aren't shifting elements on the page around when we hide/display a form. I know it's without precedent at the moment but I'd like you to consider the advantages. Think about how every other site does this stuff. It's typically with modals. Koha is generally working against the standard web ux by *not* using modals! Would you agree?

...

- Nowhere else in Koha do we use the "fa-edit" icon for "edit." We always use "fa-pencil."

Changed with followup!

...

- When displaying confirmation messages we use '<div class="dialog message">' not '<div class="dialog alert">'

Can do!

...

- There is no reason to display an icon ("<i class="fa fa-object-group"></i>") next to each group. It doesn't serve any function.

Changed in followup!

...

- There is no reason to display an icon ("<i class="fa fa-home"></i>") next to each library in a group. It doesn't serve any function.

Changed in followup!

...

- Nowhere else in Koha do we use "fa-minus-circle" to mean "remove." It should be "fa-trash."

Fixed in followup!

...

- Nowhere else in Koha do we add an icon to the "actions" menu.

Will do!

...

- Nowhere else in Koha do we use a modal to display a delete confirmation message. I think I could be convinced that we should, but I'd like to hear the argument. If we do, we should use the space given to display more information about the deletion than this implementation does, e.g. what exactly am I deleting?

We use plenty of js confirm dialogs for delete confirmation messages. Over the years they've gotten more and more jarring in my opinion. They cannot be styled to match the look of Koha. Even more importantly, we tend to abuse confirm dialogs by adding far to much text to them which we attempt to lay out with only spaces and newlines. With the modal this is a non-issue because we can simply use html. The modal seems much more natural and integrated, while presenting the exact same options to the user.

...

- Instead of a "home" icon for "Add library" I think it should be the "plus" icon which is associated with adding or creating something.

Fixed!

...

- The list of libraries in the "Add library" dropdown should be alphabetized by library name, not library code.

Fixed!

...

- This patch adds five new instances of "onclick." I've been working very hard to eliminate the use of "onclick" and I don't think new patches should add them.

Fixed! I wrote this patch before the move away from onclick and I'm happy to see them go ; ) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:55 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:55 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52367&action=edit Bug 15707 [QA Followup] - Fix UI issues -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:55 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #65 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #63)

...

These two sub-systems are completely unrelated. They really don't belong together.

If this is a feature without any real application in Koha yet, perhaps we shouldn't add it to the menu system at all?

...

...
- Nowhere else in Koha do we use a modal to display an add form.

You are correct, but I believe the modal may be a better paradigm.

Perhaps. However, I think introducing a new interface pattern requires a certain amount of commitment to making that change consistently throughout the interface. For example, using jEditable for the Quote of the Day feature was an interesting proof of concept, but it went nowhere after that. Introducing the use of Font Awesome was a good improvement, but it took a lot of buy-in and work to make it consistent.

...

...
- Nowhere else in Koha do we use a modal to display a delete confirmation message.

The modal seems much more natural and integrated, while presenting the exact same options to the user.

I think that's fine, especially if we take advantage of the opportunity to display thorough information to the user. As I said above, I think making the change requires /some/ commitment to implementing the same change throughout the staff client. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:11 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

...

I've removed the patch that adds the treegrid library and have added a follow switching to treetables.

Treegrid is still getting added to the about page. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:15 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Owen Leonard from comment #65)

...

(In reply to Kyle M Hall from comment #63)

...
These two sub-systems are completely unrelated. They really don't belong together.

If this is a feature without any real application in Koha yet, perhaps we shouldn't add it to the menu system at all?

I don't expect this patch set to be pushed to master until Bug 15708 is ready to be pushed along with it. I would like to get this to Passed QA in the meantime.

...

...
...
- Nowhere else in Koha do we use a modal to display an add form.

You are correct, but I believe the modal may be a better paradigm.

Perhaps. However, I think introducing a new interface pattern requires a certain amount of commitment to making that change consistently throughout the interface. For example, using jEditable for the Quote of the Day feature was an interesting proof of concept, but it went nowhere after that. Introducing the use of Font Awesome was a good improvement, but it took a lot of buy-in and work to make it consistent.

I agree. I'm willing to put in some work if you can identify some areas where you'd like to see modals. I think the low-hanging fruit would be any of the hide/show forms we have. The audio alerts editor is the first one that comes to mind, but I'm sure you can point out some others!

...

...
...
- Nowhere else in Koha do we use a modal to display a delete confirmation message.

The modal seems much more natural and integrated, while presenting the exact same options to the user.

I think that's fine, especially if we take advantage of the opportunity to display thorough information to the user. As I said above, I think making the change requires /some/ commitment to implementing the same change throughout the staff client.

Agreed, this latest followup takes advantage of that a bit be showing the group to be deleted in one case, in the case of removing a library from a group it shows the library name and the group it will be removed from with some minor styling. Nothing amazing but definitely easier on the eyes and no unnecessary use of quotes around the names of things because the confirm dialogs are only plaintext. If you think my styling could be improved just let me know! Basically it's just styled with the group and library names italicized and bold. I think we need a standard pattern for how to style the names of things in this fashion, and I see no reason not to start here. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:22 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:22 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52370&action=edit Bug 15707 [QA Followup] - Remove class for treegrid -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:24 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #69 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #63)

...

...
I agree. It is confusing to have two menu items on the administration page, "Libraries and groups" and "Library groups." I think we should think of a way to manage all this functionality in one section.

These two sub-systems are completely unrelated.

Do you not plan to replace the existing library groups functionality with this? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:18 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10276 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:20 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12599 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:51 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

4:57 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Owen Leonard from comment #69)

...

(In reply to Kyle M Hall from comment #63)

...
...
I agree. It is confusing to have two menu items on the administration page, "Libraries and groups" and "Library groups." I think we should think of a way to manage all this functionality in one section.

These two sub-systems are completely unrelated.

Do you not plan to replace the existing library groups functionality with this?

I had not thought about it, but it would make a log of sense! That should definitely be a separate bug to limit scope creep, but I think it's an excellent idea. After that we could do away with the existing groups functionality altogether. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:05 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:09 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #70)

...

The discussion about the modal should be brought at the next dev meeting I think: Is everybody (i.e. the majority) agrees on this change, who is going to implement it to the other pages, etc.

That sounds good to me. I think we should vote to add this behavior as the preferred "one page" viewer/editor style, deprecating the older "hide/show" style in preference to it. Once that is voted on, we can identify pages that use the "hide/show" style and file bugs to replace each one. I'd be happy to work on those bugs. I think using the modal is great ux improvement and it would be worthwhile to make that change throughout Koha. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

15 Jun 15 Jun

8:08 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

...

Basically it's just styled with the group and library names italicized and >bold. I think we need a standard pattern for how to style the names of things >in this fashion, and I see no reason not to start here.

Please don't do this! It breaks translation by splitting the sentence into multiple parts in the po files. Until that is fixed, using in-sentence mark-up is a really bad thing for translators. Using TT variables works fine and they get replaced by %s, but <b> and <i> mid-sentence are bad. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:10 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Talking about these for an example: + <div class="dialog alert group-added"> + [% IF added.branchcode %] + <i>[% added.library.branchname %]</i> added to group. + [% ELSE %] + Group <i>[% added.title %]</i> created. + [% END %] + </div> Second example in the po file is: - Group - created Instead of: Group %s created. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:31 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #74)

...

Talking about these for an example:

+ <div class="dialog alert group-added"> + [% IF added.branchcode %] + <i>[% added.library.branchname %]</i> added to group. + [% ELSE %] + Group <i>[% added.title %]</i> created. + [% END %] + </div>

Second example in the po file is: - Group - created Instead of: Group %s created.

What if we were to take advantage of TT to "hide" the markup for translations? Instead of: Group <i>[% added.title %]</i> created. we could do this: Group [% "<i>" _ added.title _ "</i>" %] created. That way, we can still emphasize names, but the markup will not show. We could even create a filter if we standardize this so we could do something like this: Group [% added.title | $KohaSpan id => 'myId' class => 'name' %] created. That solves the problem of translations while still allowing us to style particular elements in a sentence! What do you think? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:48 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If that works with the po files - it's totally ok for me. I can see how highlighting words or pre-formatting things can be useful. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:17 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #77 from Marc Véron <veron@veron.ch> --- (In reply to Kyle M Hall from comment #75)

...

(In reply to Katrin Fischer from comment #74)

...
Talking about these for an example:

+ <div class="dialog alert group-added"> + [% IF added.branchcode %] + <i>[% added.library.branchname %]</i> added to group. + [% ELSE %] + Group <i>[% added.title %]</i> created. + [% END %] + </div>

Second example in the po file is: - Group - created Instead of: Group %s created.

What if we were to take advantage of TT to "hide" the markup for translations? Instead of: Group <i>[% added.title %]</i> created. we could do this: Group [% "<i>" _ added.title _ "</i>" %] created.

That way, we can still emphasize names, but the markup will not show. We could even create a filter if we standardize this so we could do something like this:

Group [% added.title | $KohaSpan id => 'myId' class => 'name' %] created.

That solves the problem of translations while still allowing us to style particular elements in a sentence!

What do you think?

That sounds interesting, see: http://template-toolkit.org/docs/manual/Directives.html ---start snip--- You can concatenate strings together using the ' _ ' operator. In Perl 5, the . is used for string concatenation, but in Perl 6, as in the Template Toolkit, the . will be used as the method calling operator and ' _ ' will be used for string concatenation. Note that the operator must be specified with surrounding whitespace which, as Larry says, is construed as a feature: [% copyright = '(C) Copyright' _ year _ ' ' _ author %] You can, of course, achieve a similar effect with double quoted string interpolation. [% copyright = "(C) Copyright $year $author" %] ---end snip--- -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Jun 16 Jun

3:54 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #78 from Marc Véron <veron@veron.ch> --- (In reply to Kyle M Hall from comment #75) (...)

...

That way, we can still emphasize names, but the markup will not show. We could even create a filter if we standardize this so we could do something like this: Group [% added.title | $KohaSpan id => 'myId' class => 'name' %] created. (...)

Hi Kyle, I tried the follwing: Group [% '<i>' _ added.title | $KohaSpan id => 'myId' class => 'name' _ '</i>' %] created. ...but it results in a template error. A workaround would be: [% myvalue = added.title | $KohaSpan id => 'myId' class => 'name' %] Group [% '<i>' _ myvalue _ '</i>' %] created. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:47 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkpattison@gmail.com, | |manueltamayao@gmail.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 Jun 20 Jun

1:28 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #79 from Kyle M Hall <kyle@bywatersolutions.com> --- Marc, did you create a KohaSpan filter? If not, that would cause your error. I will write that and add it to this bug! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:46 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:46 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52267|0 |1 is obsolete| | Attachment #52268|0 |1 is obsolete| | Attachment #52269|0 |1 is obsolete| | Attachment #52270|0 |1 is obsolete| | Attachment #52271|0 |1 is obsolete| | Attachment #52272|0 |1 is obsolete| | Attachment #52273|0 |1 is obsolete| | Attachment #52274|0 |1 is obsolete| | Attachment #52275|0 |1 is obsolete| | Attachment #52367|0 |1 is obsolete| | Attachment #52370|0 |1 is obsolete| | --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52562&action=edit Bug 15707 - Update DB Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1:48 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

2 Aug 2 Aug

11:15 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What is the status of this? IMO we should wait for bug 16735 before pushing this one. It won't make sense to have 15707 without 16735. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 Oct 20 Oct

9:31 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this still moving.. looks interesting -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Nov 2 Nov

2:25 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52563|0 |1 is obsolete| | Attachment #52564|0 |1 is obsolete| | Attachment #52565|0 |1 is obsolete| | Attachment #52566|0 |1 is obsolete| | Attachment #52567|0 |1 is obsolete| | Attachment #52568|0 |1 is obsolete| | Attachment #52569|0 |1 is obsolete| | Attachment #52570|0 |1 is obsolete| | Attachment #52571|0 |1 is obsolete| | Attachment #52572|0 |1 is obsolete| | Attachment #52573|0 |1 is obsolete| | Attachment #52575|0 |1 is obsolete| | --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57080&action=edit Bug 15707 - Update DB Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:26 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

9 Dec 9 Dec

2:02 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Dec 10 Dec

9:01 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #110 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58086&action=edit Bug 15707: Followup - use cat-search instead of cities-search in header -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:03 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #111 from Josef Moravec <josef.moravec@gmail.com> --- When testing bug 16735, I found, that in header is used cities search form, I fixed it in followup as it is an easy fix. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Dec 13 Dec

3:17 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #112 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comments (with bug 16735): 1/ treegrid plugin patches should be removed 2/ updatedb: I think we decided not to use Koha code from the updatedb process 3/ I have added a library to __SEARCH_GROUPS__, on the adv search form, the dropdown list contains an empty line, if I select it, the result list is empty 4/ There are 2 occurrences of Koha::Library->get_categories in C4/Circulation.pm 5/ There is a lack of tests, some new subroutines are not tested 6/ DB structure - updated_on could be "timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP". That would avoid the trick in ->store - Don't we want a constraint a the library_groups table? A unique key on title for instance. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 Feb 21 Feb

2:41 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:41 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57082|0 |1 is obsolete| | Attachment #57083|0 |1 is obsolete| | Attachment #57084|0 |1 is obsolete| | Attachment #57085|0 |1 is obsolete| | Attachment #57086|0 |1 is obsolete| | Attachment #57087|0 |1 is obsolete| | Attachment #57088|0 |1 is obsolete| | Attachment #57089|0 |1 is obsolete| | Attachment #57090|0 |1 is obsolete| | Attachment #57091|0 |1 is obsolete| | Attachment #57092|0 |1 is obsolete| | Attachment #57093|0 |1 is obsolete| | Attachment #58086|0 |1 is obsolete| | --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60504&action=edit Bug 15707 - Update DB Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:41 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

2:42 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60506&action=edit Bug 15707 - Add new modules Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:42 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #116 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60507&action=edit Bug 15707 - Add editor Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Feb 23 Feb

6:46 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #144 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #62)

...

- Nowhere else in Koha do we use a modal to display an add form. We either display a form on a separate page or we use JS to show/hide the edit form on the page to mimic the display of a separate page. See admin/items_search_fields.pl for example.

...

- Nowhere else in Koha do we add an icon to the "actions" menu.

...

- Nowhere else in Koha do we use a modal to display a delete confirmation message. I think I could be convinced that we should, but I'd like to hear the argument. If we do, we should use the space given to display more information about the deletion than this implementation does, e.g. what exactly am I deleting?

This is still valid. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:57 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #145 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #142)

...

Created attachment 60586 [details] [review] Bug 15707 - Add UNIQUE constraint to library groups table

This works but explodes if happens (DBD::mysql::st execute failed: Duplicate entry 'xxx' for key 'title') -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #146 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- - Empty groups (without libraries) are displayed in the adv search form, I do not think they should. - If Search groups contain several levels of subgroups, only the first one will be used. Not sure it's the expected behaviour. Example: __SEARCH_GROUP__ Group 1 Library 1 Subgroup Library 2 Search on "Group 1" will search in library 1. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:09 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #147 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment 144 in discussion Failing QA for comments 145 and 146. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:11 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #148 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also note that last DB changes have not been propagated to schema files. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Feb 24 Feb

8:35 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

1 Mar 1 Mar

3:01 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60573|0 |1 is obsolete| | Attachment #60574|0 |1 is obsolete| | Attachment #60575|0 |1 is obsolete| | Attachment #60576|0 |1 is obsolete| | Attachment #60577|0 |1 is obsolete| | Attachment #60578|0 |1 is obsolete| | Attachment #60579|0 |1 is obsolete| | Attachment #60580|0 |1 is obsolete| | Attachment #60581|0 |1 is obsolete| | Attachment #60582|0 |1 is obsolete| | Attachment #60583|0 |1 is obsolete| | Attachment #60584|0 |1 is obsolete| | Attachment #60585|0 |1 is obsolete| | Attachment #60586|0 |1 is obsolete| | Attachment #60587|0 |1 is obsolete| | --- Comment #149 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60755&action=edit Bug 15707 - Update DB Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:02 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

3:09 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #166 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #146)

...

- Empty groups (without libraries) are displayed in the adv search form, I do not think they should.

Fixed!

...

- If Search groups contain several levels of subgroups, only the first one will be used. Not sure it's the expected behaviour.

Example: __SEARCH_GROUP__ Group 1 Library 1 Subgroup Library 2

Search on "Group 1" will search in library 1.

That is expected behavior and will be documented in the manual. There is no additional utility for this particular feature to sub-groups. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7 Mar 7 Mar

5:17 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #167 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #166)

...

...
- If Search groups contain several levels of subgroups, only the first one will be used. Not sure it's the expected behaviour.

Example: __SEARCH_GROUP__ Group 1 Library 1 Subgroup Library 2

Search on "Group 1" will search in library 1.

That is expected behavior and will be documented in the manual. There is no additional utility for this particular feature to sub-groups.

If L1 is in a subgroup that is in a group, L1 is not considered part of the group? This behaviour sounds very weird. Why did you choose this behaviour? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Mar 16 Mar

11:10 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #168 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #167)

...

(In reply to Kyle M Hall from comment #166)

...
...
- If Search groups contain several levels of subgroups, only the first one will be used. Not sure it's the expected behaviour.

Example: __SEARCH_GROUP__ Group 1 Library 1 Subgroup Library 2

Search on "Group 1" will search in library 1.

That is expected behavior and will be documented in the manual. There is no additional utility for this particular feature to sub-groups.

If L1 is in a subgroup that is in a group, L1 is not considered part of the group? This behaviour sounds very weird. Why did you choose this behaviour?

For efficiency. If you think it makes more sense to have all libraries in all subgroups selected as well I'd be happy to change it. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:55 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #169 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #168)

...

For efficiency. If you think it makes more sense to have all libraries in all subgroups selected as well I'd be happy to change it.

To me it does not make sense not to go all over the whole tree, I think it would be good to get other opinions. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Mar 29 Mar

9:11 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

30 Mar 30 Mar

8:34 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #170 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've not really been following this one too closely yet, though it is interesting. I agree that we need a clear inheritance model defined, and personally would agree with the above comments. As a further note, I see you've chosen to use Adjacency List, and you've coded the queries yourself. Did you investigate any of the other options for storing hierarchies in a database.. Nested Set or Materialized Path perhaps, and did you not consider leaning on the shoulders of giants and using one of the DBIx::Class modules to construct the queries for you in the most optimal way for the data you require? It's important to consider future use cases, each hierarchical data model has it's strengths and it's weaknesses in terms of performance and space requirements. In general, I think Materialized Path is the defacto recommended way of doing hierarchies in relational databases now. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Apr 13 Apr

1:22 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #171 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is there a 'functional requirements' document anywhere for all this.. the more I read the code and linked bugs the more confused I get about what it's actually trying to achieve :( -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Apr 26 Apr

8:21 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Jun 16 Jun

5:15 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #172 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Martin Renvoize from comment #171)

...

Is there a 'functional requirements' document anywhere for all this.. the more I read the code and linked bugs the more confused I get about what it's actually trying to achieve :(

Bug 10276 - RIP. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Aug 8 Aug

16 Aug 16 Aug

4:20 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Aug 23 Aug

11:30 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:03 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69514|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:03 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69515|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:03 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69516|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:03 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:03 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:03 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:03 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69521|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69522|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69528|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:04 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:05 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #206 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69573&action=edit Bug 15707: Update DB Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:05 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #207 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69574&action=edit Bug 15707: Add Koha::Library::Group(s) modules Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:05 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #208 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69575&action=edit Bug 15707: Add library groups editor Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:05 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #209 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69576&action=edit Bug 15707: Unit Tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:05 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #210 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69577&action=edit Bug 15707: Fix conflict with bug 15446 (type vs _type) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:05 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #211 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69578&action=edit Bug 15707: (QA followup) Switch to treetable which Koha already uses Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #212 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69579&action=edit Bug 15707: (QA followup) Drop table if exists 1/ DROP table if exists 2/ FAIL spelling decendents ==> descendants Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #213 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69580&action=edit Bug 15707: (QA followup) Fix UI issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #214 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69581&action=edit Bug 15707: (QA followup) Remove class for treegrid Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #215 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69582&action=edit Bug 15707: (QA followup) Allow object names to be styled without impeding translation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #216 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69583&action=edit Bug 15707: (followup) use cat-search instead of cities-search in header Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #217 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69584&action=edit Bug 15707: Switch datetimes to timestamps Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #218 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69585&action=edit Bug 15707: Add UNIQUE constraint to library groups table Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #219 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69586&action=edit Bug 15707: Updates for Bootstrap 3 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:06 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #220 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69587&action=edit Bug 15707: Display error if group title is already used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit: I added !$branchcode && to the checked condition so we can add multiple libraries back. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:07 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #221 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69588&action=edit Bug 15707: DBIC Schema files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:13 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:13 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #222 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69589&action=edit Bug 15707: (QA followup) Style buttons correctly Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Dec 18 Dec

3:45 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Jan 12 Jan

9:27 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Feb 2 Feb

5:51 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #223 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- library_groups.created_on and updated_on are DATETIME in kohastructure but timestamp in atomic update. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #224 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches do not apply but rebased on https://github.com/joubu/Koha/commits/bug_18403 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 Feb 9 Feb

9:07 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #225 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #223)

...

library_groups.created_on and updated_on are DATETIME in kohastructure but timestamp in atomic update.

I kept TIMESTAMP -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Feb 12 Feb

7:47 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

16 Feb 16 Feb

2:39 a.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com --- Comment #227 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! New feature, not backported to stable. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Apr 6 Apr

3:21 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

9 Apr 9 Apr

1:41 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

24 Oct 24 Oct

3:56 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21645 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 [Bug 21645] Clean up library groups template -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Oct 25 Oct

10:28 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon＠bugs.koha-community.org

10:34 p.m.

New subject: [Bug 15707] Add ability to define hierarchical groups of libraries

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674 [Bug 21674] Data integrity not enforced for library groups -- You are receiving this mail because: You are watching all bug changes.

2819

Age (days ago)

3817

Last active (days ago)

List overview

Download

276 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org