[Bug 40772] New: Title says "Issuing to {user}"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40772 Bug ID: 40772 Summary: Title says "Issuing to {user}" Change sponsored?: --- Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Created attachment 186270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186270&action=edit the title (tab) says "Issuing to {user}" instead of the user's name When issuing to a user in the staff client, the title (tab) says "Issuing to {user}" instead of the user's name -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40772 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40772 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40772 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I think "Issuing" is a en-NZ localisation as the core code uses "Checking out". When I grep "Checking out to", I see the following: grep -R "Checking out to " koha-tmpl/* koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: [% tx("Checking out to {patron}", { patron = patron_in_title }) | html %] koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: <label class="circ_barcode" for="barcode">Checking out to [% INCLUDE 'patron-title.inc' %]</label> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: <h4>Checking out to [% INCLUDE 'patron-title.inc' %]</h4> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt: <legend>Checking out to [% INCLUDE 'patron-title.inc' %]</legend> koha-tmpl/intranet-tmpl/prog/fr-FR/modules/circ/circulation.tt: [% tx("Checking out to {patron}", { patron = patron_in_title }) | html %] If I do this 'grep "Issuing" misc/translator/po/en-NZ*', I can see the following: misc/translator/po/en-NZ-messages.po:msgstr "Issuing to {user}" -- If I look at that file then I see the following: 7329 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:20 7330 #, perl-brace-format 7331 msgid "Checking out to {patron}" 7332 msgstr "Issuing to {user}" -- There are similar issues further down: 7342 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt:16 7343 #, perl-brace-format 7344 msgid "Batch check out to {patron}" 7345 msgstr "Batch issue to {user}" -- So overall I think this is a translation issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40772 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I tried running the following: misc/translator/translate update en-NZ -v But it didn't update the existing msgstr, since the msgid "Checking out to {patron}" is still the same I imagine. So I imagine the solution will be to update the msgstr in Weblate? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40772 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #2)
I tried running the following: misc/translator/translate update en-NZ -v
But it didn't update the existing msgstr, since the msgid "Checking out to {patron}" is still the same I imagine.
So I imagine the solution will be to update the msgstr in Weblate?
When I go on to Weblate and start looking at the messages, I see there's a warning that says the following: Things to check Perl brace format The following format strings are missing: {patron} The following format strings are extra: {user} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40772 --- Comment #4 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Thanks heaps David! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40772 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org