[Bug 20659] New: Blocking errors are not longer displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659 Bug ID: 20659 Summary: Blocking errors are not longer displayed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 18403 The include file blocking-errors.inc has been created to by-pass regular processing and display an error that should block the elements of the view. For instance you call a patron's page with invalid borrowernumber => we do not want the app to crash (500) or the page to display with broken elements. It worked well on bug 18403 but it's now broken, a blank page is displayed instead. It may be caused by the move of the JS to the bottom of the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74856&action=edit Bug 20659: Fix blocking errors display The include file blocking-errors.inc has been created to by-pass regular processing and display an error that should block the elements of the view. For instance you call a patron's page with invalid borrowernumber => we do not want the app to crash (500) or the page to display with broken elements. It worked well on bug 18403 but it's now broken, a blank page is displayed instead. It may be caused by the move of the JS to the bottom of the page. Test plan: hit /cgi-bin/koha/members/moremember.pl?borrowernumber=45432 Without this patch a blank page is displayed. With this patch you see the blocking error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org