[Bug 42052] New: Do not export first column of items table in catalogue details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Bug ID: 42052 Summary: Do not export first column of items table in catalogue details page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In catalogue details page, staff interface, do not export first column of items (aka holdings) table. It contains only checkboxes. CSV export generates a column wihtout heading which is useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Idem for "Spine label" column, should not be exported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 195088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195088&action=edit Bug 42052: Do not export useless columns of items table in catalogue details page In catalogue details page, staff interface, do not export first column of items (aka holdings) table. It contains only checkboxes. CSV export generates a column wihtout heading which is useless. Idem for "Spine label" column, should not be exported. Patch simply add "no-export" class on those column header. Test plan : 1) Enable systempreference 'SpineLabelShowPrintOnBibDetails' 2) In staff interface go to a biblio record with items 3) Check you see items table with first colum containing checkboxes and column containing links to print label 4) Click Export > CSV 5) Check you dont see first empty column nor spine label column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195088|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195090&action=edit Bug 42052: Do not export useless columns of items table in catalogue details page In catalogue details page, staff interface, do not export first column of items (aka holdings) table. It contains only checkboxes. CSV export generates a column wihtout heading which is useless. Idem for "Spine label" column, should not be exported. Patch simply add "no-export" class on those column header. Test plan : 1) Enable systempreference 'SpineLabelShowPrintOnBibDetails' 2) In staff interface go to a biblio record with items 3) Check you see items table with first colum containing checkboxes and column containing links to print label 4) Click Export > CSV 5) Check you dont see first empty column nor spine label column Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- With SpineLabelShowPrintOnBibDetails off, the print version correctly leaves out the checkboxes on the left and the Edit button on the right. But with SpineLabelShowPrintOnBibDetails turned on, the print correctly leaves out the checkboxes on the left and the Print Label button but incorrectly includes the Edit button on the right side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Andrew Fuerste-Henry from comment #4)
With SpineLabelShowPrintOnBibDetails off, the print version correctly leaves out the checkboxes on the left and the Edit button on the right. But with SpineLabelShowPrintOnBibDetails turned on, the print correctly leaves out the checkboxes on the left and the Print Label button but incorrectly includes the Edit button on the right side.
Ah strange, without this patch the edit button already has "no-export" class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- @Owen can you confirm this please ? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org