https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- With SpineLabelShowPrintOnBibDetails off, the print version correctly leaves out the checkboxes on the left and the Edit button on the right. But with SpineLabelShowPrintOnBibDetails turned on, the print correctly leaves out the checkboxes on the left and the Print Label button but incorrectly includes the Edit button on the right side. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Andrew Fuerste-Henry from comment #4)

With SpineLabelShowPrintOnBibDetails off, the print version correctly leaves out the checkboxes on the left and the Edit button on the right. But with SpineLabelShowPrintOnBibDetails turned on, the print correctly leaves out the checkboxes on the left and the Print Label button but incorrectly includes the Edit button on the right side.

Ah strange, without this patch the edit button already has "no-export" class -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 210698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210698&action=edit Bug 42052: Do not export useless columns of items table in catalogue details page In catalogue details page, staff interface, do not export first column of items (aka holdings) table. It contains only checkboxes. CSV export generates a column wihtout heading which is useless. Idem for "Spine label" column, should not be exported. Patch simply add "no-export" class on those column header. Test plan : 1) Enable systempreference 'SpineLabelShowPrintOnBibDetails' 2) In staff interface go to a biblio record with items 3) Check you see items table with first colum containing checkboxes and column containing links to print label 4) Click Export > CSV 5) Check you dont see first empty column nor spine label column Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 210789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210789&action=edit Bug 42052: Do not export the checkbox and spine label columns for the holdings table In the catalogue details page in the staff interface, the CSV export generates an empty column without a heading for the first column of the holdings table (which only contains checkboxes). This empty column and the "Spine label" column (which has a "Print label" action button) should not be exported. This patch adds a "no-export" class for these column headers. Test plan: 1. In the staff interface go to a bibliographic record with items. 2. Click "Show filters", then for the "Columns" options select "Spine label". 3. The items table should now show the first column without a column label and checkboxes, and a "Spine label" column with a "Print label" action button for each item. 4. Click Export > CSV. 5. Note that the exported file has an empty column at the start and a "Spine label" column with "Print label" for each item. 6. Apply the patch. 7. Repeat step 4 and note that it no longer has an empty column and a spine label column. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Do not export first column |Do not export the checkbox |of items table in catalogue |and spine label columns in |details page |the staff interface | |holdings table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 210793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210793&action=edit Bug 42052: Do not export the checkbox and spine label columns for the holdings table In the catalogue details page in the staff interface, the CSV export generates an empty column without a heading for the first column of the holdings table (which only contains checkboxes). This empty column and the "Spine label" column (which has a "Print label" action button) should not be exported. This patch adds a "no-export" class for these column headers. Test plan: 1. In the staff interface go to a bibliographic record with items. 2. Click "Show filters", then for the "Columns" options select "Spine label". 3. The items table should now show the first column without a column label and checkboxes, and a "Spine label" column with a "Print label" action button for each item. 4. Click Export > CSV. 5. Note that the exported file has an empty column at the start and a "Spine label" column with "Print label" for each item. 6. Apply the patch. 7. Repeat step 4 and note that it no longer has an empty column and a spine label column. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42052 --- Comment #12 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.