[Bug 7186] New: add new 'Koha Stats' tab to 'About' page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Bug #: 7186 Summary: add new 'Koha Stats' tab to 'About' page Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: About AssignedTo: nengard@gmail.com ReportedBy: mtj@kohaaloha.com QAContact: ian.walls@bywatersolutions.com Created attachment 6240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6240 screenshot this enhancement adds some statistics (and links) from Koha's Ohloh.net page, to the Koha staff 'About' page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 --- Comment #1 from Mason James <mtj@kohaaloha.com> 2011-11-06 09:24:50 UTC --- Created attachment 6241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6241 Bug 7186 - add new 'Koha Stats' tab to 'About' page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nengard@gmail.com |mtj@kohaaloha.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-12-02 15:12:01 UTC --- In my opinion this information is not necessary to display. It seems more promotional than informational, and anyway I'm not sure we should be pulling data directly from a third-party source for this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-02 15:17:03 UTC --- Not a fan of hard-coded third party integration, myself. I prefer to see things like that wrapped in system preferences (like our Enhanced Content area), liked to using specific syspref code (like Facebook/Twitter API calls in OPACMySummaryHTML) or handled through external cronjobs. Could this whole new tab be added with JQuery? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-02 15:22:44 UTC --- Magnus points out that the Facebook/Twitter API calls are not an explicit part of OPACMySummaryHTML. They're entirely optional, made possible by the parsing of the BIBLIONUMBER token (I'm a little loopy today, so I'm sorry if I didn't make that clear) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 --- Comment #5 from Mason James <mtj@kohaaloha.com> 2011-12-03 00:07:39 UTC --- (In reply to comment #2)
In my opinion this information is not necessary to display.
agreed, its not necessary - is that enough reason to not allow the patch to be committed? is the 'OPAC cover-images' feature necessary, too?
It seems more promotional than informational,
the info is *both* promotional and informational, thats why i did the patch...
and anyway I'm not sure we should be pulling data directly from a third-party source for this.
why not? we pull 'data directly from a third-party source' when fetching cover images fyi: ohloh's 'terms and conditions' allow this specific usage any other problems with the patch? :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 --- Comment #6 from Mason James <mtj@kohaaloha.com> 2011-12-03 00:26:47 UTC --- (In reply to comment #3)
Not a fan of hard-coded third party integration, myself. I prefer to see things like that wrapped in system preferences (like our Enhanced Content area), liked to using specific syspref code (like Facebook/Twitter API calls in OPACMySummaryHTML) or handled through external cronjobs.
Ian, i'm prepared to add a on/off display syspref to this, if you would accept it but any more effort than that? i'll just let this patch die... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-03 05:41:04 UTC --- Third party integration is kind of a sensitive issue and I would like to see an option to turn this off, with off being the default setting. Perhaps the 'off' version can show a link to the stats somewhere in the about page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master Patch Status|Needs Signoff |Does not apply --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 07:40:04 UTC --- There is some controversial disscussion about this bug. Patch does currently not apply to master: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 7186 - add new 'Koha Stats' tab to 'About' page Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Failed to merge in the changes. Patch failed at 0001 Bug 7186 - add new 'Koha Stats' tab to 'About' page When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6241|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10004&action=edit Bug 7186 - add new 'Koha Stats' tab to 'About' page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Francois Charbonnier <francois.charbonnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |francois.charbonnier@biblib | |re.com --- Comment #10 from Francois Charbonnier <francois.charbonnier@biblibre.com> --- Patch tested : * the stastistic tab appears well * but the syspref interface css looks broken. Question : Is there a syspref to turn this stat tab on/off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I would really like to see an option to have this configurable (see comment 7). It's a nice feature, but might introduce some problems for data privacy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Resetting to ASSIGNED since there are serious privacy concerns with this patch. A better option for this functionality would be to provide a script with which the RM can generate the required statistics at release time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #13 from Mason James <mtj@kohaaloha.com> --- (In reply to Jared Camins-Esakov from comment #12)
Resetting to ASSIGNED since there are serious privacy concerns with this patch. A better option for this functionality would be to provide a script with which the RM can generate the required statistics at release time.
this feature is not really needed i think this bug can be closed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org