[Bug 32672] New: Incorrect CSS path to jquery-ui
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Bug ID: 32672 Summary: Incorrect CSS path to jquery-ui Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 30011 Not sure how bad this is, but we are pointing to a non-existing css file: koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt: [% Asset.css("lib/jquery/jquery-ui-1.13.1.css") | $raw %] koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt:[% Asset.css("lib/jquery/jquery-ui-1.13.1.css") | $raw %] koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt: [% Asset.css("lib/jquery/jquery-ui-1.13.1.css") | $raw %] From commit de2d8ba3e4f611aadc29165a7748cc1797d87ce3 Bug 30011: Update links to jQueryUI assets, remove datepicker references, etc. - [% Asset.css("lib/jquery/jquery-ui-1.12.1.css") | $raw %] + [% Asset.css("lib/jquery/jquery-ui-1.13.1.css") | $raw %] We only have the min version for 1.13.1.css Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145400&action=edit Bug 32672: Incorrect CSS path to jquery-ui This patch removes links to jQueryUI assets which are not required in the self-checkout and self-checkin pages. The patch also adds missing JS to the self-checkin page related to internationalization. This prevents a JS error related to an undefined function, "__". To test, apply the patch and view the main pages in self-checkout and self-checkin, and the help page in self checkout. There should be no errors in the browser console related to missing files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- There were no browser messages related to missing files after applying the patch. However, I had these warning and error messages when accessing the help page from the self-checkout system (http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl): Warning ------- jQuery.Deferred exception: __ is not defined @http://127.0.0.1:8080/opac-tmpl/bootstrap/js/global_22.1200001.js:248:6 e@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... Deferred/then/l/</t<@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... setTimeout handler*Deferred/then/l/<@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... c@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... fireWith@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... fire@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... c@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... fireWith@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... ready@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... B@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... EventListener.handleEvent*@http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... @http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... @http://127.0.0.1:8080/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min_22.120... undefined jquery-3.6.0.min_22.1200001.js:2:31593 Error ----- Uncaught ReferenceError: __ is not defined <anonymous> http://127.0.0.1:8080/opac-tmpl/bootstrap/js/global_22.1200001.js:248 jQuery 13 e t setTimeout handler*Deferred/then/l/< c fireWith fire c fireWith ready B EventListener.handleEvent* <anonymous> <anonymous> global_22.1200001.js:248:6 Testing notes (using KTD): 1. Enable the SelfCheckInModule system preferences (SCOAllowCheckin and WebBasedSelfCheck are enabled by default in KTD). 2. I checked out, renewed and checked in 39999000011418 from http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl 3. After checking out 39999000011418 again, I checked it in from http://127.0.0.1:8080/cgi-bin/koha/sci/sci-main.pl 4. I accessed the help page from http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl (the help page for the self check-in page is a modal window). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> ---
However, I had these warning and error messages when accessing the help page from the self-checkout system
I saw this too but it should be considered a separate bug because it's unrelated to the jQueryUI assets. I have filed Bug 32701 - Self checkout help page lacks required I18N JavaScript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 ajestin <ajestin@univ-brest.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |ajestin@univ-brest.fr --- Comment #4 from ajestin <ajestin@univ-brest.fr> --- I tested the same workflow than David and the file /bootstrap/lib/jquery/jquery-ui-1.13.1.min_22.1200000.js is still loaded (web developer network panel) on Self checkout system page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to ajestin from comment #4)
/bootstrap/lib/jquery/jquery-ui-1.13.1.min_22.1200000.js is still loaded
The patch doesn't change links to jQueryUI javascript (.js) only CSS (.css) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145400|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 145591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145591&action=edit Bug 32672: Incorrect CSS path to jquery-ui This patch removes links to jQueryUI assets which are not required in the self-checkout and self-checkin pages. The patch also adds missing JS to the self-checkin page related to internationalization. This prevents a JS error related to an undefined function, "__". To test, apply the patch and view the main pages in self-checkout and self-checkin, and the help page in self checkout. There should be no errors in the browser console related to missing files. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145591|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145944&action=edit Bug 32672: Incorrect CSS path to jquery-ui This patch removes links to jQueryUI assets which are not required in the self-checkout and self-checkin pages. The patch also adds missing JS to the self-checkin page related to internationalization. This prevents a JS error related to an undefined function, "__". To test, apply the patch and view the main pages in self-checkout and self-checkin, and the help page in self checkout. There should be no errors in the browser console related to missing files. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working now, nice bit of cleanup. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 --- Comment #10 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on 30011, can't backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (last comment targets 21.11.x) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32701 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org