https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 [Bug 24152] Add the ability to purge pseudonymized data -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95959&action=edit Bug 24151: DB Changes Add tables anonymized_borrowers and anonymized_transactions Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95961&action=edit Bug 24151: Copy info to the pseudonymized table when a patron is modified This is the commit where you will find useful information about this development. The goal of this neww feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 3 different tables: * 1 for patrons' data (anonymized_borrowers) * 1 for transactions (anonymized_transactions) * 1 for patrons' attributes (anonymized_borrower_attributes) Entries to anonymized_borrowers are added when a new patron is added or modified, to anonymized_transactions when a new transaction (checkout, checkin, renew, on-site checkout) is done, and anonymized_borrower_attributes when attributes are added or modified. That way we are maintaining up-to-date informations in 3 different tables. To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in each of the 3 tables. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_anonymized that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section (</config) it should be something like: <key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key> 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new patron => Confirm that a new entry has been added to anonymized_borrowers with the data you expect to be copied 7/ Modify an existing patron (ie. that does not have a corresponding entry in anonymized_borrowers) => Confirm that a new entry has been added to anonymized_borrowers with the data you expect to be copied 8/ Add some transactions (checkout, checkin, renew, on-site checkout) for patron that existed before you turned the pref Pseudonymization on and for newly created/modified patrons => Confirm that new entries have been added to anonymized_transactions with the data you expect 9/ Edit some patron attribute types and tick "Keep for pseudonymization" 10/ Edit or create patrons and add data for those patron attributes => Confirm that new entries have been added to anonymized_borrower_attributese 11/ Delete the patrons => Confirm that the entries still exist in the anonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the anonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95963&action=edit Bug 24151: Pseudonymize transactions on the fly Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95965&action=edit Bug 24151: Move get_hash to Koha::Anonymized To avoid duplicated code. Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95967&action=edit Bug 24151: Add warning to the about page if key is missing in the config Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95969&action=edit Bug 24151: Handle case where the setting is turned on later Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95971&action=edit Bug 24151: Add new column borrower_attribute_types.keep_for_anonymized Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95973&action=edit Bug 24151: Add Koha::Anonymized::Patron::Attribute[s] classes Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95975&action=edit Bug 24151: DBIC Changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_24151 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The whole patch stack of this feature has been pushed to a remote branch (https://gitlab.com/joubu/Koha/commits/bug_24151) It includes the tree dependency of bug 24153 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Axelle Aix-Marseille Université <axelle.clarisse@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse@univ-amu.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95970|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95966|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97240&action=edit Bug 24151: DB changes 1 new table: * pseudonymized_transactions 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97242&action=edit Bug 24151: Copy info to the pseudonymized table when a transaction is done This is the commit where you will find useful information about this development. The goal of this new feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 2 different tables: * 1 for transactions and patrons data (pseudonymized_transactions) * 1 for patrons' attributes (pseudonymized_borrower_attributes) Entries to pseudonymized_transactions are added when a new transaction (checkout, checkin, renew, on-site checkout) is done. Also, anonymized_borrower_attributes is populated if patron's attributes are marked as "keep for pseudonymization". To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in pseudonymized_transactions. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_pseudonymization that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section (</config) it should be something like: <key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key> 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new transaction (checkin for instance) => Confirm that a new entry has been added to pseudonymized_transaction with the data you expect to be copied 7/ Edit some patron attribute types and tick "Keep for pseudonymization" 8/ Create a new transaction => Confirm that new entries have been added to pseudonymized_borrower_attributes 11/ Delete the patrons => Confirm that the entries still exist in the pseudonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the pseudonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97244&action=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97246&action=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97248&action=edit Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97250&action=edit Bug 24151: Sync patron's attributes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97252&action=edit Bug 24151: Add boolean flag for has_cardnumber -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #33 from Michal Denar <black23@gmail.com> --- Nice work, Jonathan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 20604 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97248|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97250|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97243|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97245|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr Status|Needs Signoff |Signed Off --- Comment #37 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- I've tested for Association KohaLa. I've followed the test plan and everything is Ok. I've played to check / uncheck borrowers/transaction information in the PseudonymizationPatronFields and PseudonymizationTransactionFields and data saved in the pseudonymized_transactions are consistent. I've also checked /unckecked "Keep for pseudonymization" for borrowers attributes and data in pseudonymized_borrower_attributes are also consistent. The data are keeped after deleting borrowers and cleaning deletedborrowers. Thank you for this job! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101035&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101037&action=edit Bug 24151: Add tests Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101039&action=edit Bug 24151: Add warning to the about page if key is missing in the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101041&action=edit Bug 24151: DB changes - pseudonymized_borrower_attributes Add a new DB table pseudonymized_borrower_attributes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101043&action=edit Bug 24151: Adding keep_for_anonymized to the UI Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101045&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101047&action=edit Bug 24151: Fix location on return The item's location where not passed to UpdateStat Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101049&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Patch doesn't apply --- Comment #54 from Julian Maurice <julian.maurice@biblibre.com> --- Does not apply on master. Can you rebase please ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101034|0 |1 is obsolete| | Attachment #101035|0 |1 is obsolete| | Attachment #101036|0 |1 is obsolete| | Attachment #101037|0 |1 is obsolete| | Attachment #101038|0 |1 is obsolete| | Attachment #101039|0 |1 is obsolete| | Attachment #101040|0 |1 is obsolete| | Attachment #101041|0 |1 is obsolete| | Attachment #101042|0 |1 is obsolete| | Attachment #101043|0 |1 is obsolete| | Attachment #101044|0 |1 is obsolete| | Attachment #101045|0 |1 is obsolete| | Attachment #101046|0 |1 is obsolete| | Attachment #101047|0 |1 is obsolete| | Attachment #101048|0 |1 is obsolete| | Attachment #101049|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105801&action=edit Bug 24151: DB changes 1 new table: * pseudonymized_transactions 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105803&action=edit Bug 24151: Copy info to the pseudonymized table when a transaction is done This is the commit where you will find useful information about this development. The goal of this new feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 2 different tables: * 1 for transactions and patrons data (pseudonymized_transactions) * 1 for patrons' attributes (pseudonymized_borrower_attributes) Entries to pseudonymized_transactions are added when a new transaction (checkout, checkin, renew, on-site checkout) is done. Also, anonymized_borrower_attributes is populated if patron's attributes are marked as "keep for pseudonymization". To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in pseudonymized_transactions. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_pseudonymization that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section (</config) it should be something like: <key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key> 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new transaction (checkin for instance) => Confirm that a new entry has been added to pseudonymized_transaction with the data you expect to be copied 7/ Edit some patron attribute types and tick "Keep for pseudonymization" 8/ Create a new transaction => Confirm that new entries have been added to pseudonymized_borrower_attributes 11/ Delete the patrons => Confirm that the entries still exist in the pseudonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the pseudonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105805&action=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105807&action=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105809&action=edit Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105811&action=edit Bug 24151: Sync patron's attributes Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105813&action=edit Bug 24151: Add boolean flag for has_cardnumber Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105815&action=edit Bug 24151: Add items.homebranch to the list Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/joubu/Ko | |ha/commits/bug_24151 | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105801|0 |1 is obsolete| | --- Comment #72 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106032&action=edit Bug 24151: DB changes 1 new table: * pseudonymized_transactions 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105803|0 |1 is obsolete| | --- Comment #74 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106034&action=edit Bug 24151: Copy info to the pseudonymized table when a transaction is done This is the commit where you will find useful information about this development. The goal of this new feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 2 different tables: * 1 for transactions and patrons data (pseudonymized_transactions) * 1 for patrons' attributes (pseudonymized_borrower_attributes) Entries to pseudonymized_transactions are added when a new transaction (checkout, checkin, renew, on-site checkout) is done. Also, anonymized_borrower_attributes is populated if patron's attributes are marked as "keep for pseudonymization". To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in pseudonymized_transactions. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_pseudonymization that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section (</config) it should be something like: <key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key> 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new transaction (checkin for instance) => Confirm that a new entry has been added to pseudonymized_transaction with the data you expect to be copied 7/ Edit some patron attribute types and tick "Keep for pseudonymization" 8/ Create a new transaction => Confirm that new entries have been added to pseudonymized_borrower_attributes 11/ Delete the patrons => Confirm that the entries still exist in the pseudonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the pseudonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105805|0 |1 is obsolete| | --- Comment #76 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106036&action=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105807|0 |1 is obsolete| | --- Comment #78 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106038&action=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105809|0 |1 is obsolete| | --- Comment #80 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106040&action=edit Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105811|0 |1 is obsolete| | --- Comment #82 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106042&action=edit Bug 24151: Sync patron's attributes Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105813|0 |1 is obsolete| | --- Comment #84 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106044&action=edit Bug 24151: Add boolean flag for has_cardnumber Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105815|0 |1 is obsolete| | --- Comment #86 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106046&action=edit Bug 24151: Add items.homebranch to the list Signed-off-by: Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #88 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 106048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106048&action=edit Bug 24151: (QA follow-up) Correct license in two modules Still listing the address.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #90 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me, some additional comments: t/db_dependent/Koha/Pseudonymization.t Please add test descriptions. This is a good habit. If we dont do it now, we will not. # Subtest: Config does not exist ok 2 # Subtest: Koha::Anonymized::Transactions tests ok 3 ok 4 ok 5 ok 6 ok 7 ok 8 ok 9 ok 10 ok 11 ok 12 $values->{branchcode} = $patron->branchcode; # FIXME Must be removed from the pref options, or FK removed (?) Adding a FIXME ! my $attributes = Koha::Database->new->schema->resultset('PseudonymizedBorrowerAttribute')->search({transaction_id => $p->id }); So no Koha objects here but DBIx ? $(htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/'); Why do you change $2y to $2a ? If I understand correctly, $2y signals use of a safer updated algorithm. <key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key> BAD choice for a new config variable! What is key? Where is it used for? Please add pseudonymize or something ? In general: We are filling these tables with transactions? Are we going to keep them indefinitely? What are the plans for cleanup etc.? This could be a large table in no time. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #92 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 106195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106195&action=edit Bug 24151: Add description for tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #94 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #93)

(In reply to Marcel de Rooy from comment #90)

...

my $attributes = Koha::Database->new->schema->resultset('PseudonymizedBorrowerAttribute')-

...

search({transaction_id => $p->id }); So no Koha objects here but DBIx ?

It's only used in test file. In pm file it's using create_related. 97 $self->_result->create_related('pseudonymized_borrower_attributes', $attribute);

I don't think it is worth creating a new module only for that purpose.

Agreed.

...

$(htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/'); Why do you change $2y to $2a ? If I understand correctly, $2y signals use of a safer updated algorithm.

Good question. I remember I first used some methods from Koha::AuthUtils, where we hardcode $2a. I guess it comes from there and so the replacement should be removed. I will investigate a bit further.

I would be inclined to remove the sed statement here.

...

<key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key> BAD choice for a new config variable! What is key? Where is it used for? Please add pseudonymize or something ?

We could, but the point of the generic wording was to make it use for something else, if needed. It could be better named "secret_key".

No blocker, but I prefer a more specific name. Using keys for several purposes may not always be so handy. 'key' is really too generic. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #96 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #95)

Tomas suggested me "encryption_key", would it work for you?

Another suggestion: since it seems to be a bcrypt settings string related to pseudonymization, why not "pseudonymization_bcrypt_settings" ? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #98 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #97)

(In reply to Julian Maurice from comment #96)

...

(In reply to Jonathan Druart from comment #95)

...

Tomas suggested me "encryption_key", would it work for you?

Another suggestion: since it seems to be a bcrypt settings string related to pseudonymization, why not "pseudonymization_bcrypt_settings" ? :)

I think this setting could be reuse for other uses, and so the naming should not be too specific.

Can it be something else than a bcrypt settings string ? If not, I think we should have these words (bcrypt, settings) in the config variable name, it will probably easier to search "koha bcrypt settings" than "koha key" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #100 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have renamed the config entry with "bcrypt_settings". Marcel, the sed part needs to be there, otherwise I get "bad bcrypt settings". POD says "It must begin with "$2", optional "a", "$", two digits, "$", and 22 base 64 digits", then "The function will die if SETTINGS does not have this format." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #102 from David Cook <dcook@prosentient.com.au> --- Oh I just want to say thanks for this. Very useful functionality! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #104 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #103)

As I said previously it could be reused for other features. I don't think it should be tight to the "anonymization" feature.

I suppose. If other features wanted to deviate, then the onus could be on them to create a new setting. Yeah, ok. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #107 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107127&action=edit Bug 24151: Use fully qualified names for UpdateStats t/db_dependent/Koha/Account/Line.t .. 8/12 # Looks like you planned 16 tests but ran 3. # Failed test 'void() tests' # at t/db_dependent/Koha/Account/Line.t line 723. Undefined subroutine &Koha::Account::UpdateStats called at /kohadevbox/koha/Koha/Account.pm line 289. It's certainly caused by a circ dep from commit 5ce968e0e571f555261c02a9e1d27447611cdb89 Bug 24151: Copy info to the pseudonymized table when a transaction is done See also bug 17600 for more context. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #109 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107225&action=edit Bug 24151: (follow-up) Rename the config key with 'bcrypt_settings' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #111 from Lucas Gass <lucas@bywatersolutions.com> --- Not backporting enhancement to 20.05.x series. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This new feature adds a way release notes| |to pseudonymize patron's | |data, in a way they could | |not be personally | |identifiable. | |https://en.wikipedia.org/wi | |ki/Pseudonymization | | | |There | |are different existing way | |to anonymize patron's | |information in | |Koha, but we | |loose the ability to make | |useful report. | |This | |development introduces two | |new tables: | | * 1 for | |transactions and patrons | |data | |(pseudonymized_transactions | |) | | * 1 for patrons' | |attributes | |(pseudonymized_borrower_att | |ributes) | |Entries to | |pseudonymized_transactions | |are added when a new | |transaction (checkout, | |checkin, renew, on-site | |checkout) is done. | |Also, | |anonymized_borrower_attribu | |tes is populated if | |patron's attributes are | |marked as "keep for | |pseudonymization". | | | |To make | |things configurable, three | |sysprefs have been added: | | | |* syspref Pseudonymization | |to turn on/off the whole | |feature | | * syspref | |PseudonymizationPatronField | |s to list the informations | |of the patrons to | |synchronize | | * syspref | |PseudonymizationTransaction | |Fields to list the | |informations of the | |transactions to copy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32438 [Bug 32438] Pseudonymized_transactions should include payments and writeoffs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32440 [Bug 32440] Allow selective deletion of statistics entries based on type by cleanup_database -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |Needs documenting Documentation| |Aude Charillon contact| | CC| |aude.charillon@ptfs-europe. | |com Resolution|FIXED |--- --- Comment #113 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Re-opening just for documentation. -- You are receiving this mail because: You are watching all bug changes.