[Bug 33158] New: Use template wrapper for authorized values administration tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Bug ID: 33158 Summary: Use template wrapper for authorized values administration tabs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 33157, 32571 Continuing the work of Bug 32571, the authorized values administration page should be updated to use the new WRAPPER for tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33157 [Bug 33157] Use template wrapper for item types administration tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Bug 33158 depends on bug 33157, which changed state. Bug 33157 Summary: Use template wrapper for item types administration tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33157 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use template wrapper for |Use template wrapper for |authorized values |authorized values and item |administration tabs |types administration tabs Depends on|33157 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33157 [Bug 33157] Use template wrapper for item types administration tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147854&action=edit Bug 33158: Use template wrapper for authorized values and item types administration tabs This patch updates the authorized values and item types administration templates so that they use the new WRAPPER directive to build tabbed navigation. Seeing that the markup in itemtypes.tt and authorised_values.tt is indential when it comes to icon selection, I have moved that section of the template into an include file and updated both templates to use it. To test, apply the patch and go to Administration -> Item types. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Perform the same tests in Administration -> Authorized values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 alexandra.speer@bsz-bw.de changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alexandra.speer@bsz-bw.de --- Comment #2 from alexandra.speer@bsz-bw.de --- Hello, everything works, except the following in Item types and Authorized values: If you did not previously have any icon selected, the "None" tab should be active. There is no active Tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Alexandra Speer from comment #2)
If you did not previously have any icon selected, the "None" tab should be active. There is no active Tab.
I believe this has just been fixed by Bug 33278 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com --- Comment #4 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Everything works correctly in item types, including for adding the remote image. However, when you go back to edit the item type with the remote image, I think there is a bug in the display. Initially it lands correctly with the 'remote image' tab active. However, as well as the radio button for the 'Remote image' and the field for the url there is also a 'None' radio button and label. If I switch between that active 'Remote image' tab and another, then back again, this 'None' radio button disappears. See screenshots. In authorised values, everything works correctly EXCEPT for the remote image option. It allows you to set a remote image, and correctly displays the remote image. However, when you go back to edit the authorised value, it starts on the "None" tab, unselected. When you then click on the 'Remote image' tab, the radio button is unselected and there is no url showing in the field. Saving out of that screen removes the remote image, even without selecting the 'None' radio button on the 'None' tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #5 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Created attachment 149041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149041&action=edit Screenshots to show buggy behaviour on testing for signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #6 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Created attachment 149042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149042&action=edit Screenshot2 to show buggy behaviour on testing for signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #7 from Andrew Auld <andrew.auld@ptfs-europe.com> --- (In reply to Andrew Auld from comment #4)
Saving out of that screen removes the remote image, even without selecting the 'None' radio button on the 'None' tab.
NB cancelling out of the screen leaves the remote image in place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147854|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149621&action=edit Bug 33158: Use template wrapper for authorized values and item types administration tabs This patch updates the authorized values and item types administration templates so that they use the new WRAPPER directive to build tabbed navigation. Seeing that the markup in itemtypes.tt and authorised_values.tt is indential when it comes to icon selection, I have moved that section of the template into an include file and updated both templates to use it. The patch also makes minor SCSS changes, so to test you must rebuild the staff interface CSS. To test, apply the patch and go to Administration -> Item types. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Perform the same tests in Administration -> Authorized values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149621|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 149669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149669&action=edit Bug 33158: Use template wrapper for authorized values and item types administration tabs This patch updates the authorized values and item types administration templates so that they use the new WRAPPER directive to build tabbed navigation. Seeing that the markup in itemtypes.tt and authorised_values.tt is indential when it comes to icon selection, I have moved that section of the template into an include file and updated both templates to use it. The patch also makes minor SCSS changes, so to test you must rebuild the staff interface CSS. To test, apply the patch and go to Administration -> Item types. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Perform the same tests in Administration -> Authorized values. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Great! Works perfectly now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please check on the QA test fail? FAIL koha-tmpl/intranet-tmpl/prog/en/includes/admin-icon-selection.inc FAIL valid_template tab_item: not found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 150893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150893&action=edit Bug 33158: (follow-up) Fix for QA test failure The page seems to work fine without these changes but the QA test script is happier with "USE raw" and html_helpers.inc added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Bug 33158 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.07 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Bug 33158 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org