[Bug 33126] New: Markup error in staff interface tab wrapper
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Bug ID: 33126 Summary: Markup error in staff interface tab wrapper Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32571 There is a closing </li> which lacks the slash. The example code also has an error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147697&action=edit Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a <li> which should be </li>. The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this: <li role="presentation" class="active"> <a href="about_panel" aria-controls="about_panel" role="tab" data-toggle="tab"> Server information </a> <li> After the patch the closing </li> will be correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147697|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 147826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147826&action=edit Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a <li> which should be </li>. The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this: <li role="presentation" class="active"> <a href="about_panel" aria-controls="about_panel" role="tab" data-toggle="tab"> Server information </a> <li> After the patch the closing </li> will be correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147826|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148231&action=edit Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a <li> which should be </li>. The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this: <li role="presentation" class="active"> <a href="about_panel" aria-controls="about_panel" role="tab" data-toggle="tab"> Server information </a> <li> After the patch the closing </li> will be correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Clear correction, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Bug 33126 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Bug 33126 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org