[Bug 29099] New: Add support for item bundles in the inventory tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Bug ID: 29099 Summary: Add support for item bundles in the inventory tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I chose to split out the inventory tool additions from the bundles bug.. that bug was already big enough ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125207&action=edit Bug 29099: Add bundle support to inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Bug 29099 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Bug 29099 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125207|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 140898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140898&action=edit Bug 29099: Add bundle support to inventory tool Test plan: 1. Create an item bundle (see bug 28854 comment 458) containing 2 items with barcodes B1 and B2 2. Go to the inventory tool 3. Enter B1 inside the barcode list 4. Select the item bundle in "Item location filters" fieldset 5. Submit the form In the result table you should see B2 with the problem "Missing (not scanned)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased and reworked to work with bug 28854 Also added unit tests for GetItemsForInventory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for your work here Julian, I'm so bad at remembering unit tests at the moment :(. Is your customer intending to test and sign this one off.. We don't really use the inventory at all here, so although I'm reasonably confident this achieves what's required, it would be great to hear from someone using it in earnest. It would be great to see this go in within this cycle to have the feature complete at release time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Bug 29099 depends on bug 28854, which changed state. Bug 28854 Summary: Add ability to create bundles of items for circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140898|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146009&action=edit Bug 29099: Add bundle support to inventory tool Test plan: 1. Create an item bundle (see bug 28854 comment 458) containing 2 items with barcodes B1 and B2 2. Go to the inventory tool 3. Enter B1 inside the barcode list 4. Select the item bundle in "Item location filters" fieldset 5. Submit the form In the result table you should see B2 with the problem "Missing (not scanned)" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd have loved to have seen a customer signoff here.. but I'm confident enough in the code and have tested it's working.. So I'm signing off myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #6)
I'd have loved to have seen a customer signoff here.. but I'm confident enough in the code and have tested it's working.. So I'm signing off myself.
It is not really a trivial one. But lets see. Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I think that this needs a bit more attention still but did not yet finish qa on it. Came across this exception with inventory form: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: 'koha_myclone.me.biblionumber' isn't in GROUP BY at /usr/share/koha/Koha/Objects.pm line 394 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Resuming next week. Fine for me to keep it BLOCKED now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [1] The following constructs look quite complicated and does not work: -my $schema = Koha::Database->new()->schema(); -my $item_bundles_rs = Koha::Items->search( - { - 'item_bundles_hosts.item' => { '!=' => undef }, - }, - { - join => 'item_bundles_hosts', - group_by => 'itemnumber', - } -); - -my @item_bundles = $item_bundles_rs->as_list; I am adding a follow-up as proposal to change this code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- General observation: + $item_bundle->_result->add_to_item_bundles_hosts({ item => $item1->itemnumber }); + $item_bundle->_result->add_to_item_bundles_hosts({ item => $item2->itemnumber }); If those were the first lines introducing ->result->add_to_$rel, I might say something about Koha objects. But apparently the door has been opened already for more of those ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148550&action=edit Bug 29099: Add Koha objects for item bundle(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The choice for the column 'item' on the parent report present difficulties here when you want to go from item to item if you understand what I mean.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146009|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148555&action=edit Bug 29099: Add bundle support to inventory tool Test plan: 1. Create an item bundle (see bug 28854 comment 458) containing 2 items with barcodes B1 and B2 2. Go to the inventory tool 3. Enter B1 inside the barcode list 4. Select the item bundle in "Item location filters" fieldset 5. Submit the form In the result table you should see B2 with the problem "Missing (not scanned)" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148556&action=edit Bug 29099: Fix item bundle fetch in inventory script Using the newly created Koha objects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #6)
I'd have loved to have seen a customer signoff here.. but I'm confident enough in the code and have tested it's working.. So I'm signing off myself.
The inventory form crashed. Please ask for another signoff when submitting adjustments now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The last follow-up seems to fix the crash. Another point: The biblio title in the inventory combo may appear double when you have multiple bundles on the same parent biblio. This is confusing. The bundle should probably have its own name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If you agree with the two new patches, please switch to NSO. Moving it to FQA now first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Ping Martin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ping Martin :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lisette@bywatersolutions.co | |m --- Comment #20 from Lisette Scheer <lisette@bywatersolutions.com> --- Applying: Bug 29099: Add bundle support to inventory tool Using index info to reconstruct a base tree... M C4/Items.pm M koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt M tools/inventory.pl Falling back to patching base and 3-way merge... Auto-merging tools/inventory.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Auto-merging C4/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 29099: Add bundle support to inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148555|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176237&action=edit Bug 29099: Add bundle support to inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148550|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176238&action=edit Bug 29099: Add Koha objects for item bundle(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148556|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176239&action=edit Bug 29099: Fix item bundle fetch in inventory script Using the newly created Koha objects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176237|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178502&action=edit Bug 29099: Add bundle support to inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176238|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178503&action=edit Bug 29099: Add Koha objects for item bundle(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176239|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178504&action=edit Bug 29099: Fix item bundle fetch in inventory script Using the newly created Koha objects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This is really a NSO.. not sure if anyone is really interested in this code or not.. I thought Biblibre's customer were interested but as no-one appears to want to test it perhaps they're not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #28 from David Nind <david@davidnind.com> --- I had a go at testing: 1. The patches still apply. 2. However, clicking the "Manage bundle" action in the holdings table generates this error in the browser development tools: Uncaught ReferenceError: createChild is not defined at HTMLButtonElement.<anonymous> (detail.pl?biblionumber=439:3717:25) at HTMLTableSectionElement.dispatch (jquery-3.6.0.min_25.0600001.js:2:43064) at v.handle (jquery-3.6.0.min_25.0600001.js:2:41048) 3. This looks like an unrelated bug to me, however I'm not familiar enough with bundles. Happy to create a bug for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- QA tool noticed: [FAIL] Koha/Item/Bundle.pm FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 18) [FAIL] Koha/Item/Bundles.pm FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 18) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- Any news ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'll rebase it.. but really it just needs someone to test it and agree it works as expected.. I don't use the inventory tool at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Sponsorship status|--- |Unsponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178502|0 |1 is obsolete| | Attachment #178503|0 |1 is obsolete| | Attachment #178504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200208&action=edit Bug 29099: Add bundle support to inventory tool Extends the inventory tool to allow filtering by item bundle. When item bundles are defined in the system, a searchable "Items bundle" dropdown is shown in the filter form. Selecting a bundle restricts the inventory run to only the items contained in that bundle. The filter is passed to GetItemsForInventory (C4/Items.pm), which uses a subquery against the item_bundles table to limit the result set. The dropdown is enhanced with select2 and is only rendered when at least one bundle exists. The existing "no filters selected" JavaScript warning is updated to treat a bundle selection as a valid filter. Test plan: 1. Set up at least one item bundle: find or create a host item, then attach other items to it via the item bundle management interface. 2. Go to Tools > Inventory. 3. Confirm a new "Items bundle" searchable dropdown is visible. The dropdown should NOT appear if no bundles exist in the system. 4. Select a bundle from the dropdown and run the inventory (with a barcode file or a manually scanned list of barcodes). 5. Confirm the "Expected items" list contains only items that belong to the selected bundle — no items from other bundles or unbundled items should appear. 6. Run the inventory again with no bundle selected; confirm normal unfiltered results are returned (no regression). 7. Load a barcode file, clear all other filters, and select a bundle. Confirm the "no catalog filters" warning is suppressed — the bundle alone should be treated as a sufficient filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200209&action=edit Bug 29099: Add Koha objects for item bundle(s) Introduces Koha::Item::Bundle and Koha::Item::Bundles as the modern Koha-object layer over the item_bundles table. Koha::Item::Bundle exposes two relationship helpers: item_object() — returns the bundled Koha::Item host_item() — returns the bundle host Koha::Item The name item_object() is used instead of item() to avoid shadowing the DBIC column accessor of the same name. Registers koha_object_class / koha_objects_class in the auto-generated Koha::Schema::Result::ItemBundle so that the standard Koha ORM mapping works correctly when constructing objects from DBIC result sets. Test plan: prove t/db_dependent/Koha/Item/Bundle.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200210&action=edit Bug 29099: Fix item bundle fetch in inventory script The initial implementation fetched item bundles via a raw DBIC schema resultset using the non-existent 'ItemsBundle' resultset name and an incorrect join on 'biblionumber'. The template likewise referenced fields that do not exist on the item_bundles schema (items_bundle_id, biblionumber.title). Replace the raw schema access with Koha::Item::Bundles->search() and correct the template to use the actual column names: host (the FK itemnumber of the host item) and host_item->biblio->title for the display label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200211&action=edit Bug 29099: Improve bundle host query and POD consistency Replace Koha::Item::Bundles GROUP BY approach with a direct Koha::Items JOIN query, eliminating the host_item() intermediate call and reducing query depth from 1+2N to 1+N per bundle in the dropdown. Also corrects =head3 to =head2 for object_class in Koha::Item::Bundles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #36 from David Nind <david@davidnind.com> --- With the patches applied (they still apply cleanly), I get this error when accessing the inventory tool (Cataloging > Reports > Inventory) (database in KTD is MariaDB 11.8.8): DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.me.biblionumber' isn't in GROUP BY at /usr/share/perl5/Exception/Class/Base.pm line 88 I don't get this error before the patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 209027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209027&action=edit Bug 29099: Improve bundle host query and POD consistency Replace Koha::Item::Bundles GROUP BY approach with a direct Koha::Items query for the hosts of bundles, eliminating the host_item() intermediate call and reducing query depth from 1+2N to 1+N per bundle in the dropdown. The hosts are selected with a subquery on item_bundles.host rather than joining and grouping on me.itemnumber: the join form selected all the items columns while grouping by one, which fails with "'me.biblionumber' isn't in GROUP BY" when ONLY_FULL_GROUP_BY is in effect (MariaDB). Also corrects =head3 to =head2 for object_class in Koha::Item::Bundles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks David, I've reproduced this and fixed it in the last patch (replaced attachment). The dropdown query joined item_bundles and grouped by me.itemnumber while selecting all the item columns, which fails when ONLY_FULL_GROUP_BY is in effect. It now selects the bundle hosts with a subquery on item_bundles.host, with no grouping. I checked it in KTD with a bundle defined: the inventory tool loads with no error, the "Items bundle" dropdown lists the host, and running the inventory with that bundle selected returns only the bundled item. The earlier http:// QA warning on Koha/Item/Bundle(s).pm no longer applies after the rebase, and koha-qa passes on all four patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200208|0 |1 is obsolete| | Attachment #200209|0 |1 is obsolete| | Attachment #200210|0 |1 is obsolete| | Attachment #209027|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #39 from David Nind <david@davidnind.com> --- Created attachment 209045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209045&action=edit Bug 29099: Add bundle support to inventory tool Extends the inventory tool to allow filtering by item bundle. When item bundles are defined in the system, a searchable "Items bundle" dropdown is shown in the filter form. Selecting a bundle restricts the inventory run to only the items contained in that bundle. The filter is passed to GetItemsForInventory (C4/Items.pm), which uses a subquery against the item_bundles table to limit the result set. The dropdown is enhanced with select2 and is only rendered when at least one bundle exists. The existing "no filters selected" JavaScript warning is updated to treat a bundle selection as a valid filter. Test plan: 1. Set up at least one item bundle: find or create a host item, then attach other items to it via the item bundle management interface. 2. Go to Tools > Inventory. 3. Confirm a new "Items bundle" searchable dropdown is visible. The dropdown should NOT appear if no bundles exist in the system. 4. Select a bundle from the dropdown and run the inventory (with a barcode file or a manually scanned list of barcodes). 5. Confirm the "Expected items" list contains only items that belong to the selected bundle — no items from other bundles or unbundled items should appear. 6. Run the inventory again with no bundle selected; confirm normal unfiltered results are returned (no regression). 7. Load a barcode file, clear all other filters, and select a bundle. Confirm the "no catalog filters" warning is suppressed — the bundle alone should be treated as a sufficient filter. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #40 from David Nind <david@davidnind.com> --- Created attachment 209046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209046&action=edit Bug 29099: Add Koha objects for item bundle(s) Introduces Koha::Item::Bundle and Koha::Item::Bundles as the modern Koha-object layer over the item_bundles table. Koha::Item::Bundle exposes two relationship helpers: item_object() — returns the bundled Koha::Item host_item() — returns the bundle host Koha::Item The name item_object() is used instead of item() to avoid shadowing the DBIC column accessor of the same name. Registers koha_object_class / koha_objects_class in the auto-generated Koha::Schema::Result::ItemBundle so that the standard Koha ORM mapping works correctly when constructing objects from DBIC result sets. Test plan: prove t/db_dependent/Koha/Item/Bundle.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #41 from David Nind <david@davidnind.com> --- Created attachment 209047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209047&action=edit Bug 29099: Fix item bundle fetch in inventory script The initial implementation fetched item bundles via a raw DBIC schema resultset using the non-existent 'ItemsBundle' resultset name and an incorrect join on 'biblionumber'. The template likewise referenced fields that do not exist on the item_bundles schema (items_bundle_id, biblionumber.title). Replace the raw schema access with Koha::Item::Bundles->search() and correct the template to use the actual column names: host (the FK itemnumber of the host item) and host_item->biblio->title for the display label. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 209048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209048&action=edit Bug 29099: Improve bundle host query and POD consistency Replace Koha::Item::Bundles GROUP BY approach with a direct Koha::Items query for the hosts of bundles, eliminating the host_item() intermediate call and reducing query depth from 1+2N to 1+N per bundle in the dropdown. The hosts are selected with a subquery on item_bundles.host rather than joining and grouping on me.itemnumber: the join form selected all the items columns while grouping by one, which fails with "'me.biblionumber' isn't in GROUP BY" when ONLY_FULL_GROUP_BY is in effect (MariaDB). Also corrects =head3 to =head2 for object_class in Koha::Item::Bundles. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #43 from David Nind <david@davidnind.com> --- Everything seems to work as expected, so have signed off. Testing notes (using KTD): 1. Apply the patches and restart everything (restart_all) 2. Create a bundle: - Edit a record and for the leader (000) change 7- Bibliographic level to c- Collection - For the record, add items to the bundle: I used The definitive guide to Catalyst (146) and added 39999000006117 and 39999000006131 to the item with barcode 39999000006094 3. To get to the inventory tool: Cataloging > Reports > Inventory 4. Running the inventory with the bundled item selected returns to results in the table: the two items in step 2 above that were added to the bundle. 5. Step 7, not sure what is required here, everything on the page is default and I selected the bundle from the dropdown list: Barcode file 1 - with barcodes for the bundled items: 3999900000017 3999900000019 39999000006117 39999000006131 Results: - 4 items modified : datelastseen set to 10/27/2026 00:00 - Number of potential barcodes read: 4 - 2 results rows in the table (the bundled items are not listed) Barcode file 2 - with the host item barcode: 3999900000017 3999900000019 39999000006094 Results: - 3 items modified : datelastseen set to 10/27/2026 00:00 - Number of potential barcodes read: 3 - 5 result rows in the table (includes host item and bundled items) 6. Tests pass: prove t/db_dependent/Koha/Item/Bundle.t 7. Added another bundle for Perl template toolkit (255) - 39999000011074 and 39999000011135 added to item with barcode 39999000011111 8. Selecting the bundle in the inventory tool shows the right results in the table (the items added to the bundle, and excludes the host item). 9. Removing the bundled items: no "Items bundle" dropdown list. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org