https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164376|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 164388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164388&action=edit Bug 36502: Canreservefromotherbranches allows staff to place holds even if independent branches is enabled To test: 1. Enable both the IndependentBranches and canreservefromotherbranches system preferences. 2. Log in to the staff interface with a non-super librarian staff user that has permissions to place holds. 3. Search the catalog for an item. 1. The non-super librarian user should be able to place holds on item from their branch. 2. They should see a “No holds allowed” on items from other branches. 4. Apply the patch and restart_all 5. Repeat step 3 or refresh the page. 1. The non-super librarian can now place holds on items from their branch and other branches. 6. Turn off canreservefromotherbranches 1. The non-super librarian cannot place holds on items from other branches again. 7. Sign off and have a great day! :D Signed-off-by: esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Laura, there's a little more work needed here. We're missing a unit test update (both to fix the failure this introduces and test the new case introduced) * Proving t/db_dependent/Koha/Items.t KO! # Failed test '2 items for hold, filtered by IndependentBranches' # at t/db_dependent/Koha/Items.t line 2068. # got: '6' # expected: '2' # Looks like you failed 1 test of 13. # Failed test 'filter_by_for_hold' # at t/db_dependent/Koha/Items.t line 2078. # Looks like you failed 1 test of 20. t/db_dependent/Koha/Items.t .. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164388|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 185992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185992&action=edit Bug 36502: Canreservefromotherbranches allows staff to place holds even if independent branches is enabled -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36502 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I attempted to test, but I'm not getting the behavour described in the test plan. Or maybe I'm not testing this correctly - any additional steps to help reproduce or understand the issue? ==>Step 3.2 - They should see a “No holds allowed” on items from other branches. I'm not seeing this: 1. I gave Henry (Midway) some permissions (catalogue, parameters, borrowers, reserveforothers, editcatalogue) 2. IndependentBranches = set to Yes 3. canreservefromotherbranches = allow (default, already set to allow in KTD) 4. Went to place a hold for Mary (Midway) on 'The definitive guide to Catalyst' (146), which has four items (3 at Fairview, and 1 at Midway) 5. I can place a hold on using the next available item, or any of the individual items - there is no "No holds allowed" indicator for any of the Fairview items 6. If I go to place a hold on a record where all the items are not from the library (that is, no items for Midway), then I don't have a hold toolbar button and can't place a hold 7. If I set canreservefromotherbranches = "Don't allow", this shows "X Patron is from a different library" 8. If I apply the patches and restart everything, I don't see any change in behavour - that is, it seems to work exactly the same way as before the patches for me (not that I have a great understanding of these options). 9. The tests pass before and after the patch. -- You are receiving this mail because: You are watching all bug changes.