[Bug 19088] New: plugins-upload.pl causes plack-error.log uninitialized value noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Bug ID: 19088 Summary: plugins-upload.pl causes plack-error.log uninitialized value noise Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: ldjamison@marywood.edu QA Contact: testopia@bugs.koha-community.org After uploading a plugin, plack-error.log indicates the message Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/plugins/plugins-upload.pl line 57. Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/plugins/plugins-upload.pl line 92. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ldjamison@marywood.edu |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 --- Comment #1 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 65926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65926&action=edit Test Plugin KPZ Test plugin KPZ file to use to test this bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 65928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65928&action=edit Bug 19088: plugins-upload causes error log noise After uploading a plugin the error log indicates use of uninitialized value in $op. This patch silences the noise. To test: 1) Set <enable_plugins> to 1 (one) in koha-conf.xml. 2) Set the UseKohaPlugins system preference to 'Enable'. 3) Navigate to Administration -> Manage plugins. 4) Install the test plugin KPZ file attached to this bug. 5) Notice the uninitialized value noise in the error log. 6) Uninstall the plugin (plack restart may be required if plack is enabled). 7) Apply patch. 8) Install the plugin again. 9) Notice no noise in the error log. 10) Run qa tools. 11) Run prove t/db_dependent/Plugins.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 65928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65928 Bug 19088: plugins-upload causes error log noise Review of attachment 65928: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19088&attachment=65928) ----------------------------------------------------------------- ::: plugins/plugins-upload.pl @@ +47,4 @@
my $uploadfilename = $input->param('uploadfile'); my $uploadfile = $input->upload('uploadfile'); +my $op = $input->param('op') || q{};
// is better. if 'op' is '0', then this would set $op to ''. || evaluates truthy only. // is a defined check. http://perldoc.perl.org/perlop.html#Logical-Defined-Or -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Don't even need the plugin. Using the breadcrumbs to go back you can trigger the error over and over. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65928|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65936&action=edit Bug 19088: plugins-upload causes error log noise After uploading a plugin the error log indicates use of uninitialized value in $op. This patch silences the noise. To test: 1) Set <enable_plugins> to 1 (one) in koha-conf.xml. 2) Set the UseKohaPlugins system preference to 'Enable'. 3) Navigate to Administration -> Manage plugins. 4) Install the test plugin KPZ file attached to this bug. 5) Notice the uninitialized value noise in the error log. 6) Uninstall the plugin (plack restart may be required if plack is enabled). 7) Apply patch. 8) Install the plugin again. 9) Notice no noise in the error log. 10) Run qa tools. 11) Run prove t/db_dependent/Plugins.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|plugins-upload.pl causes |plugins-upload.pl causes |plack-error.log |uninitialized value noise |uninitialized value noise | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- In an old school git install, it still triggers noise, just in a different log. Leave it up to the tester to know which log it should be in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65936|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66564&action=edit Bug 19088: plugins-upload causes error log noise After uploading a plugin the error log indicates use of uninitialized value in $op. This patch silences the noise. To test: 1) Set <enable_plugins> to 1 (one) in koha-conf.xml. 2) Set the UseKohaPlugins system preference to 'Enable'. 3) Navigate to Administration -> Manage plugins. 4) Install the test plugin KPZ file attached to this bug. 5) Notice the uninitialized value noise in the error log. 6) Uninstall the plugin (plack restart may be required if plack is enabled). 7) Apply patch. 8) Install the plugin again. 9) Notice no noise in the error log. 10) Run qa tools. 11) Run prove t/db_dependent/Plugins.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org