[Bug 14048] New: Change RefundLostItemFeeOnReturn to be branch specific
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Bug ID: 14048 Summary: Change RefundLostItemFeeOnReturn to be branch specific Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some library systems would like to be able to control the behavior of RefundLostItemFeeOnReturn Expected outcome: To make the RefundLostItemFeeOnReturn system preference branch specific Plan of Attack: 1) Add new field 'refund_lost_item_fee_on_return' to the 'branches' table 2) Pre-populate this field with the system preference value for RefundLostItemFeeOnReturn 3) Remove the system preference RefundLostItemFeeOnReturn 4) Replace uses of RefundLostItemFeeOnReturn with a lookup of the value of branches.refund_lost_item_fee_on_return 5) Use HomeOrHolding to control whether the home branch or the holding branch of the item is used to determine this. 6) Reveal the setting in the branches editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Peggy Thrasher <p.thrasher@dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Sheila Kearns <sheila.kearns@state.vt.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sheila.kearns@state.vt.us --- Comment #1 from Sheila Kearns <sheila.kearns@state.vt.us> --- --Kyle, There seems to be a conflict in this test plan for our consortium purposes. HomeOrHolding is set to "the library the item is checked out from" in order to make it possible for the holding library to charge fines and feeds for their patrons according to their own rules--particularly libraries that do not charge fines. However, it is the home libraries that want to be able to decide whether or not a lost item charge gets forgiven if a lost item makes it back to their library. It is completely possible that I do not understand what you are planning to do. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- The plan of attack looks good to me. I am just wondering if the field branches.refund_lost_item_fee_on_return makes sense. Don't you think it would be better to set this rule in the "Circulation and fine rules" page (admin/smart-rules.pl)? It would be easy to change the behavior for all libraries (if only a default rule is defined). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)
The plan of attack looks good to me. I am just wondering if the field branches.refund_lost_item_fee_on_return makes sense. Don't you think it would be better to set this rule in the "Circulation and fine rules" page (admin/smart-rules.pl)? It would be easy to change the behavior for all libraries (if only a default rule is defined).
I was wondering that myself Jonathan. I'll look into it, seems like a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Sheila has a good point - maybe the dependence on HomeOrHolding is not the best option here and we need something that is a bit more flexible? Only other thing is maybe the column name - refund_lost_item_fee_on_return is quite a bit to write, maybe just refund_lost_on_return? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
I think Sheila has a good point - maybe the dependence on HomeOrHolding is not the best option here and we need something that is a bit more flexible?
Only other thing is maybe the column name - refund_lost_item_fee_on_return is quite a bit to write, maybe just refund_lost_on_return? :)
(In reply to Jonathan Druart from comment #2)
The plan of attack looks good to me. I am just wondering if the field branches.refund_lost_item_fee_on_return makes sense. Don't you think it would be better to set this rule in the "Circulation and fine rules" page (admin/smart-rules.pl)? It would be easy to change the behavior for all libraries (if only a default rule is defined).
Jonathan, I believe moving this to the circulation rules is at odds with what Sheila is looking for. The only way to make both work will be to add a new system preference to choose which circulation rule to select. Something like RefundLostOnReturnControl. The options could be CheckinLibrary, PatronLibrary, ItemHomeBranch and ItemHoldingbranch. What do you think? Given this, should we still make this a circulation rule setting? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
I think Sheila has a good point - maybe the dependence on HomeOrHolding is not the best option here and we need something that is a bit more flexible?
See above for a new idea!
Only other thing is maybe the column name - refund_lost_item_fee_on_return is quite a bit to write, maybe just refund_lost_on_return? :)
Sure! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |jweaver@bywatersolutions.co | |m Assignee|kyle@bywatersolutions.com |jweaver@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Karl Holten <kholten@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15522 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 [Bug 15522] New interface for revamped circulation rules -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org