[Bug 29067] New: Remove duplicate conditional statement from OPAC messaging settings title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Bug ID: 29067 Summary: Remove duplicate conditional statement from OPAC messaging settings title Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org There is a duplicate conditional statement in OPAC messaging settings <title>. We need to check LibraryNameTitle just once. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 125083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125083&action=edit Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC messaging preferences title, so it's dead code. This patch removes the useless duplicate if-statement. To test: 1. Enable EnhancedMessagingPreferencesOPAC system preference 2. Go to /cgi-bin/koha/opac-messaging.pl 3. Observe title Your messaging settings > Koha online catalog 4. Apply patch 5. Refresh page /cgi-bin/koha/opac-messaging.pl 6. Observe same title Your messaging settings > Koha online catalog 7. See patch content 8. Confirm there are no functional changes in the new logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125083|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125139&action=edit Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC messaging preferences title, so it's dead code. This patch removes the useless duplicate if-statement. To test: 1. Enable EnhancedMessagingPreferencesOPAC system preference 2. Go to /cgi-bin/koha/opac-messaging.pl 3. Observe title Your messaging settings > Koha online catalog 4. Apply patch 5. Refresh page /cgi-bin/koha/opac-messaging.pl 6. Observe same title Your messaging settings > Koha online catalog 7. See patch content 8. Confirm there are no functional changes in the new logic Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125139|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125315&action=edit Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC messaging preferences title, so it's dead code. This patch removes the useless duplicate if-statement. To test: 1. Enable EnhancedMessagingPreferencesOPAC system preference 2. Go to /cgi-bin/koha/opac-messaging.pl 3. Observe title Your messaging settings > Koha online catalog 4. Apply patch 5. Refresh page /cgi-bin/koha/opac-messaging.pl 6. Observe same title Your messaging settings > Koha online catalog 7. See patch content 8. Confirm there are no functional changes in the new logic Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |27742 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27742 not in 20.11.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 [Bug 27742] Accessibility: OPAC - Page titles should have unique information first -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org