[Bug 38650] New: We should only fill title level or specific item holds when a patron checks out an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Bug ID: 38650 Summary: We should only fill title level or specific item holds when a patron checks out an item Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Follow up to bug 14549 - we handled the case here to fill a patron's reserve when they get another copy, however, we didn't cover the case where their reserve is title level. To recreate: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 [Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 175335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175335&action=edit Bug 38650: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 175336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175336&action=edit Bug 38650: Only fill title level reserves, or reserves on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- At step 10 my title-level hold is not filled when checking out an item other than the item that is already in transit. The hold should be marked filled when checking out an item that would have triggered the hold had it been checked in first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Stephanie <spetruso@aacpl.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spetruso@aacpl.net --- Comment #4 from Stephanie <spetruso@aacpl.net> --- Hi - we are the library that originally encountered this bug and it continues to be a major issue for us. We use item specific holds to recall hotspots and Chromebooks that have been disabled or expired so they aren't sent out to new patrons in non-working condition. However, when these item-specific, first-in-queue holds keep disappearing, patrons end up borrowing non-working devices. It also takes significant amounts of time for our staff to search these out and re-place them over and over again. Any movement to resolve this issue would be greatly appreciated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175335|0 |1 is obsolete| | Attachment #175336|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181143&action=edit Bug 38650: Unit tests Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181144&action=edit Bug 38650: Only fill title level reserves, or reserves on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181143|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 181369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181369&action=edit Bug 38650: Unit tests Signed-off-by: Stephanie Petruso <spetruso@aacpl.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181144|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 181370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181370&action=edit Bug 38650: Only fill title level reserves, or reserves on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled Signed-off-by: Stephanie Petruso <spetruso@aacpl.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181369|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182017&action=edit Bug 38650: Unit tests Signed-off-by: Stephanie Petruso <spetruso@aacpl.net> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181370|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182018&action=edit Bug 38650: Only fill title level reserves, or reserves on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled Signed-off-by: Stephanie Petruso <spetruso@aacpl.net> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- When following the test plan, on step 3, this message is shown: "Item Nordic roots (39999000003154) has been on hold for Johnny Bryan (23529000120056) at Centerville since 05/07/2025" Which is great, as it informs the staff member that the item being checked out to Henry is on hold for Johnny. I wonder if in this case we should also show a message, along the lines of: 'The patron has an item-level hold on a different item of "Nordic roots", barcode 39999000003192' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we get some additional notes or some more descriptive bug title? ... only fill title level or specific item holds... What other holds are there? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se --- Comment #15 from Hans Pålsson <hans.palsson@hkr.se> --- We suspect that this breaks circulation for us, although we are not sure yet. Our situation is that on a record we have items that are available for loan where one category can be reserved (can fill a hold) and another category can not (can not fill a hold). We discovered today on 24.11.05 that if a patron has a hold on title level, borrowing a copy from the category that should not fill a hold, the reservation is removed. This is unwanted behaviour that we have fixed before, however it seems to re-appear now and again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 [Bug 40792] Do not fill hold requests when issuing non-holdable items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Steve, OSLRI, USA <sspohn@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sspohn@oslri.net --- Comment #16 from Steve, OSLRI, USA <sspohn@oslri.net> --- The same is true for us. This breaks our normal practice. We're hoping to move this along to allow for local choice and customization. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41267 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org