https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.

From there it is possible to cancel requests or to print a slip (letter code CLOSED_STACK_SLIP in 'reserves' module) Once the slip is printed, closed stack requests move to another tab in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175354|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175371&action=edit Bug 38666: Closed stack requests A closed stack request is a special kind of hold that can only be placed on a closed stack item. A closed stack item is an item that is not available publicly in the library but can be made available on demand. When a request is made, a librarian will print a slip then will go retrieve the document and place the slip in place of the document. Internally, a closed stack item is an item that is flagged as "closed stack" (new column items.is_closed_stack). The flag can be modified on the biblio "Items" tab. The new column can also be mapped to an item MARC subfield. An item is available for a closed stack request only if: - it is flagged as "closed stack" - there is no holds on it - it is not checked out - it is not in transfer If any of the above conditions is false, it is not available for a closed stack request but it can be available for a regular hold. In particular this means that once a closed stack request has been made on a particular item, this item can now be reserved using regular holds. Closed stack requests behave like regular holds, with the following exceptions: - They can only be placed on a specific item (item-level hold is forced) - They can be placed on "not for loan" items - They bypass the "onshelfholds" circulation rule - They cannot be cancelled from OPAC There is a new page "Closed stack requests" accessible from the circulation menu that lists all pending closed stack requests. the same page. The patch also adds a template plugin 'GD.Barcode' that allows to include a barcode image inside a letter. Useful to be able to scan the printed closed stack request slip. Example usage: [% USE GD.Barcode %] <img src="[% GD.Barcode.create_as_data_url('Code39', hold.item.barcode) | html %]"> Test plan: 1. Apply patch, run updatedatabase.pl and update_dbix_class_files.pl, and restart koha 2. Create a biblio with two items. 3. On the biblio detail page, click on the "Items" tab 4. For one of the two items, change the "Closed stack" status from No to Yes 5. Notice there is now a "closed stack requests" tab on the left, and a "closed stack request" button in the toolbar 6. Click on "Place hold" and select a patron. Notice there is only one item displayed in the table (the non-"closed stack" item) 7. Go back to the biblio detail view and click on the "Closed stack request" button. Select a patron. Notice there is only one item displayed in the table (the "closed stack" item). 8. Select this item and click on "Place hold". You should be redirected to the "Closed stack requests" tab where you can see the request that you just made 9. Try to place a regular hold again. This time you should see both items in the table. 10. Go to Tools » Notices and slips 11. Create a new notice in the Holds module with code CLOSED_STACK_SLIP. Add content in the "Print" message. 12. Go to Circulation » Closed stack requests 13. You have two tabs: "Pending" and "Slip printed", you should have one request under the pending tab, and zero under the other one. 14. Click on the "Print closed stack request slip" button, in the "pending" table. A printer dialog should open, close it. The "Closed stack requests" should have been automatically refreshed, showing you an empty "pending" tab, while the "Slip printed" tab now contains the previously pending request. 15. Cancel the closed stack request. 16. Login to OPAC, find your biblio record and place a closed stack request. Like from the staff interface, only the closed stack item should be in the items table, and it should not be possible to place a biblio-level request 17. In your account page, verify that the closed stack request appear under the new tab "Closed stack requests" and that there is no "Cancel" button 18. Go back to the staff interface main page. You should see an alert at the bottom: "Pending closed stack requests: 1". Clicking on it should redirect you to the closed stack requests page seen earlier (step 12) 19. Set the closed stack item as "notforloan", either by editing the item or its item type. Verify that you can still do closed stack requests 20. Change circulation rules to forbid on-shelf holds on the closed stack item and verify that you can still do closed stack requests. Sponsored-by: Université de Lyon 3 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 175373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175373&action=edit Bug 38666: Flag new columns as boolean (SQL12) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- This isn't ready for QA, as there is no unit tests yet, but it is ready for testing. I'd really like to have some feedback on the feature itself before spending time writing tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New feature: closed stack |Closed stack requests |requests | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175372|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 178978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178978&action=edit Bug 38666: [DO NOT PUSH] Update DBIC schema -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on main (In reply to Thibault Keromnès from comment #6)

On step one I ran "dbic", "updatedatabase" and "restart_all" On step 2 of the test plan, after creating the items I have an error when i go back to the biblio details page. The logs read : ==> /var/log/koha/kohadev/plack-api-error.log <== [2025/01/14 13:28:29] [WARN] OpenAPI >>> GET api/v1/biblios/272/items [{"message":"Properties not allowed: is_closed_stack.","path":"\/body\/0"},{"message":"Properties not allowed: is_closed_stack.","path":"\/body\/1"},{"message":"Properties not allowed: is_closed_stack.","path":"\/body\/2"}]

Not sure what was causing that since is_closed_stack is defined in the OpenAPI spec. And I cannot reproduce after the rebase. Can you try again ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178978|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 179467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179467&action=edit Bug 38666: [DO NOT PUSH] Update DBIC schema -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #14 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- After applying - update_dbix_class_files.pl ends with : DBIx::Class::Schema::Loader::make_schema_at(): Checksum mismatch in './/Koha/Schema/Result/Deleteditem.pm', the auto-generated part of the file has been modified outside of this loader. Aborting. If you want to overwrite these modifications, set the 'overwrite_modifications' loader option. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #16 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- Test plan needs an update: no need for update_dbix_class_files.pl. Error on comment 14 was solved by running `yarn run api:bundle` and restarting Koha. On step 12 I get a error when loading closed-stack-requests.pl page. Log reads: Template process failed: file error - columns_settings.inc: not found at /kohadevbox/koha/C4/Templates.pm line 134. -- You are receiving this mail because: You are watching all bug changes.

From there it is possible to cancel requests or to print a slip (letter code CLOSED_STACK_SLIP in 'reserves' module) Once the slip is printed, closed stack requests move to another tab in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179466|0 |1 is obsolete| | --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 180309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180309&action=edit Bug 38666: Closed stack requests A closed stack request is a special kind of hold that can only be placed on a closed stack item. A closed stack item is an item that is not available publicly in the library but can be made available on demand. When a request is made, a librarian will print a slip then will go retrieve the document and place the slip in place of the document. Internally, a closed stack item is an item that is flagged as "closed stack" (new column items.is_closed_stack). The flag can be modified on the biblio "Items" tab. The new column can also be mapped to an item MARC subfield. An item is available for a closed stack request only if: - it is flagged as "closed stack" - there is no holds on it - it is not checked out - it is not in transfer If any of the above conditions is false, it is not available for a closed stack request but it can be available for a regular hold. In particular this means that once a closed stack request has been made on a particular item, this item can now be reserved using regular holds. Closed stack requests behave like regular holds, with the following exceptions: - They can only be placed on a specific item (item-level hold is forced) - They can be placed on "not for loan" items - They bypass the "onshelfholds" circulation rule - They cannot be cancelled from OPAC There is a new page "Closed stack requests" accessible from the circulation menu that lists all pending closed stack requests. the same page. The patch also adds a template plugin 'GD.Barcode' that allows to include a barcode image inside a letter. Useful to be able to scan the printed closed stack request slip. Example usage: [% USE GD.Barcode %] <img src="[% GD.Barcode.create_as_data_url('Code39', hold.item.barcode) | html %]"> Test plan: 1. Apply patch, run updatedatabase.pl and update_dbix_class_files.pl, and restart koha 2. Create a biblio with two items. 3. On the biblio detail page, click on the "Items" tab 4. For one of the two items, change the "Closed stack" status from No to Yes 5. Notice there is now a "closed stack requests" tab on the left, and a "closed stack request" button in the toolbar 6. Click on "Place hold" and select a patron. Notice there is only one item displayed in the table (the non-"closed stack" item) 7. Go back to the biblio detail view and click on the "Closed stack request" button. Select a patron. Notice there is only one item displayed in the table (the "closed stack" item). 8. Select this item and click on "Place hold". You should be redirected to the "Closed stack requests" tab where you can see the request that you just made 9. Try to place a regular hold again. This time you should see both items in the table. 10. Go to Tools » Notices and slips 11. Create a new notice in the Holds module with code CLOSED_STACK_SLIP. Add content in the "Print" message. 12. Go to Circulation » Closed stack requests 13. You have two tabs: "Pending" and "Slip printed", you should have one request under the pending tab, and zero under the other one. 14. Click on the "Print closed stack request slip" button, in the "pending" table. A printer dialog should open, close it. The "Closed stack requests" should have been automatically refreshed, showing you an empty "pending" tab, while the "Slip printed" tab now contains the previously pending request. 15. Cancel the closed stack request. 16. Login to OPAC, find your biblio record and place a closed stack request. Like from the staff interface, only the closed stack item should be in the items table, and it should not be possible to place a biblio-level request 17. In your account page, verify that the closed stack request appear under the new tab "Closed stack requests" and that there is no "Cancel" button 18. Go back to the staff interface main page. You should see an alert at the bottom: "Pending closed stack requests: 1". Clicking on it should redirect you to the closed stack requests page seen earlier (step 12) 19. Set the closed stack item as "notforloan", either by editing the item or its item type. Verify that you can still do closed stack requests 20. Change circulation rules to forbid on-shelf holds on the closed stack item and verify that you can still do closed stack requests. Sponsored-by: Université de Lyon 3 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179468|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 180311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180311&action=edit Bug 38666: Flag new columns as boolean (SQL12) -- You are receiving this mail because: You are watching all bug changes.

From there it is possible to cancel requests or to print a slip (letter code CLOSED_STACK_SLIP in 'reserves' module) Once the slip is printed, closed stack requests move to another tab in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180309|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 180321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180321&action=edit Bug 38666: Closed stack requests A closed stack request is a special kind of hold that can only be placed on a closed stack item. A closed stack item is an item that is not available publicly in the library but can be made available on demand. When a request is made, a librarian will print a slip then will go retrieve the document and place the slip in place of the document. Internally, a closed stack item is an item that is flagged as "closed stack" (new column items.is_closed_stack). The flag can be modified on the biblio "Items" tab. The new column can also be mapped to an item MARC subfield. An item is available for a closed stack request only if: - it is flagged as "closed stack" - there is no holds on it - it is not checked out - it is not in transfer If any of the above conditions is false, it is not available for a closed stack request but it can be available for a regular hold. In particular this means that once a closed stack request has been made on a particular item, this item can now be reserved using regular holds. Closed stack requests behave like regular holds, with the following exceptions: - They can only be placed on a specific item (item-level hold is forced) - They can be placed on "not for loan" items - They bypass the "onshelfholds" circulation rule - They cannot be cancelled from OPAC There is a new page "Closed stack requests" accessible from the circulation menu that lists all pending closed stack requests. the same page. The patch also adds a template plugin 'GD.Barcode' that allows to include a barcode image inside a letter. Useful to be able to scan the printed closed stack request slip. Example usage: [% USE GD.Barcode %] <img src="[% GD.Barcode.create_as_data_url('Code39', hold.item.barcode) | html %]"> Test plan: 1. Apply the patch: a. apply patch, b. run updatedatabase.pl and `update_dbix_class_files.pl --force`, c. run `yarn run build`, d. and finally restart koha 2. Create a biblio with two items. 3. On the biblio detail page, click on the "Items" tab 4. For one of the two items, change the "Closed stack" status from No to Yes 5. Notice there is now a "closed stack requests" tab on the left, and a "closed stack request" button in the toolbar 6. Click on "Place hold" and select a patron. Notice there is only one item displayed in the table (the non-"closed stack" item) 7. Go back to the biblio detail view and click on the "Closed stack request" button. Select a patron. Notice there is only one item displayed in the table (the "closed stack" item). 8. Select this item and click on "Place hold". You should be redirected to the "Closed stack requests" tab where you can see the request that you just made 9. Try to place a regular hold again. This time you should see both items in the table. 10. Go to Tools » Notices and slips 11. Create a new notice in the Holds module with code CLOSED_STACK_SLIP. Add content in the "Print" message. 12. Go to Circulation » Closed stack requests 13. You have two tabs: "Pending" and "Slip printed", you should have one request under the pending tab, and zero under the other one. 14. Click on the "Print closed stack request slip" button, in the "pending" table. A printer dialog should open, close it. The "Closed stack requests" should have been automatically refreshed, showing you an empty "pending" tab, while the "Slip printed" tab now contains the previously pending request. 15. Cancel the closed stack request. 16. Login to OPAC, find your biblio record and place a closed stack request. Like from the staff interface, only the closed stack item should be in the items table, and it should not be possible to place a biblio-level request 17. In your account page, verify that the closed stack request appear under the new tab "Closed stack requests" and that there is no "Cancel" button 18. Go back to the staff interface main page. You should see an alert at the bottom: "Pending closed stack requests: 1". Clicking on it should redirect you to the closed stack requests page seen earlier (step 12) 19. Set the closed stack item as "notforloan", either by editing the item or its item type. Verify that you can still do closed stack requests 20. Change circulation rules to forbid on-shelf holds on the closed stack item and verify that you can still do closed stack requests. Sponsored-by: Université de Lyon 3 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180311|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 180323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180323&action=edit Bug 38666: Flag new columns as boolean (SQL12) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amaury.gau@bulac.fr --- Comment #26 from Amaury GAU <amaury.gau@bulac.fr> --- (In reply to Julian Maurice from comment #22)

Created attachment 180321 [details] [review] Bug 38666: Closed stack requests

A closed stack request is a special kind of hold that can only be placed on a closed stack item. A closed stack item is an item that is not available publicly in the library but can be made available on demand. When a request is made, a librarian will print a slip then will go retrieve the document and place the slip in place of the document.

Internally, a closed stack item is an item that is flagged as "closed stack" (new column items.is_closed_stack). The flag can be modified on the biblio "Items" tab. The new column can also be mapped to an item MARC subfield.

An item is available for a closed stack request only if: - it is flagged as "closed stack" - there is no holds on it - it is not checked out - it is not in transfer

If any of the above conditions is false, it is not available for a closed stack request but it can be available for a regular hold. In particular this means that once a closed stack request has been made on a particular item, this item can now be reserved using regular holds.

Closed stack requests behave like regular holds, with the following exceptions: - They can only be placed on a specific item (item-level hold is forced) - They can be placed on "not for loan" items - They bypass the "onshelfholds" circulation rule - They cannot be cancelled from OPAC

There is a new page "Closed stack requests" accessible from the circulation menu that lists all pending closed stack requests. From there it is possible to cancel requests or to print a slip (letter code CLOSED_STACK_SLIP in 'reserves' module) Once the slip is printed, closed stack requests move to another tab in the same page.

The patch also adds a template plugin 'GD.Barcode' that allows to include a barcode image inside a letter. Useful to be able to scan the printed closed stack request slip. Example usage:

[% USE GD.Barcode %] <img src="[% GD.Barcode.create_as_data_url('Code39', hold.item.barcode) | html %]">

Test plan: 1. Apply the patch: a. apply patch, b. run updatedatabase.pl and `update_dbix_class_files.pl --force`, c. run `yarn run build`, d. and finally restart koha 2. Create a biblio with two items. 3. On the biblio detail page, click on the "Items" tab 4. For one of the two items, change the "Closed stack" status from No to Yes 5. Notice there is now a "closed stack requests" tab on the left, and a "closed stack request" button in the toolbar 6. Click on "Place hold" and select a patron. Notice there is only one item displayed in the table (the non-"closed stack" item) 7. Go back to the biblio detail view and click on the "Closed stack request" button. Select a patron. Notice there is only one item displayed in the table (the "closed stack" item). 8. Select this item and click on "Place hold". You should be redirected to the "Closed stack requests" tab where you can see the request that you just made 9. Try to place a regular hold again. This time you should see both items in the table. 10. Go to Tools » Notices and slips 11. Create a new notice in the Holds module with code CLOSED_STACK_SLIP. Add content in the "Print" message. 12. Go to Circulation » Closed stack requests 13. You have two tabs: "Pending" and "Slip printed", you should have one request under the pending tab, and zero under the other one. 14. Click on the "Print closed stack request slip" button, in the "pending" table. A printer dialog should open, close it. The "Closed stack requests" should have been automatically refreshed, showing you an empty "pending" tab, while the "Slip printed" tab now contains the previously pending request.

Why the request can be cancelled as "not found" before printing the slip. I guess this is a user practice to avoid.

15. Cancel the closed stack request. 16. Login to OPAC, find your biblio record and place a closed stack request. Like from the staff interface, only the closed stack item should be in the items table, and it should not be possible to place a biblio-level request 17. In your account page, verify that the closed stack request appear under the new tab "Closed stack requests" and that there is no "Cancel" button

There is a problem here. If the syspref `SuspendHoldsOpac` is allowed, a button 'Suspend all holds' will appear. I'm pretty sure this is not a wanted behaviour as librarians could be searching for the book while it gets cancelled.

18. Go back to the staff interface main page. You should see an alert at the bottom: "Pending closed stack requests: 1". Clicking on it should redirect you to the closed stack requests page seen earlier (step 12) 19. Set the closed stack item as "notforloan", either by editing the item or its item type. Verify that you can still do closed stack requests

It seems weird that a notforloan item can be asked from a patron. The main purpose of a notforloan item, is exactly the contrary. it should not be requestable. Otherwise, it might need a syspref to overrule this behaviour. I'd gladly ask other librarians about this.

20. Change circulation rules to forbid on-shelf holds on the closed stack item and verify that you can still do closed stack requests.

Sponsored-by: Université de Lyon 3

Thanks for the dev :) -- You are receiving this mail because: You are watching all bug changes.

From there it is possible to cancel requests or to print a slip (letter code CLOSED_STACK_SLIP in 'reserves' module) Once the slip is printed, closed stack requests move to another tab in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180321|0 |1 is obsolete| | --- Comment #28 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 180822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180822&action=edit Bug 38666: Closed stack requests A closed stack request is a special kind of hold that can only be placed on a closed stack item. A closed stack item is an item that is not available publicly in the library but can be made available on demand. When a request is made, a librarian will print a slip then will go retrieve the document and place the slip in place of the document. Internally, a closed stack item is an item that is flagged as "closed stack" (new column items.is_closed_stack). The flag can be modified on the biblio "Items" tab. The new column can also be mapped to an item MARC subfield. An item is available for a closed stack request only if: - it is flagged as "closed stack" - there is no holds on it - it is not checked out - it is not in transfer If any of the above conditions is false, it is not available for a closed stack request but it can be available for a regular hold. In particular this means that once a closed stack request has been made on a particular item, this item can now be reserved using regular holds. Closed stack requests behave like regular holds, with the following exceptions: - They can only be placed on a specific item (item-level hold is forced) - They can be placed on "not for loan" items - They bypass the "onshelfholds" circulation rule - They cannot be cancelled from OPAC There is a new page "Closed stack requests" accessible from the circulation menu that lists all pending closed stack requests. the same page. The patch also adds a template plugin 'GD.Barcode' that allows to include a barcode image inside a letter. Useful to be able to scan the printed closed stack request slip. Example usage: [% USE GD.Barcode %] <img src="[% GD.Barcode.create_as_data_url('Code39', hold.item.barcode) | html %]"> Test plan: 1. Apply the patch: a. apply patch, b. run updatedatabase.pl and `update_dbix_class_files.pl --force`, c. run `yarn run build`, d. and finally restart koha 2. Create a biblio with two items. 3. On the biblio detail page, click on the "Items" tab 4. For one of the two items, change the "Closed stack" status from No to Yes 5. Notice there is now a "closed stack requests" tab on the left, and a "closed stack request" button in the toolbar 6. Click on "Place hold" and select a patron. Notice there is only one item displayed in the table (the non-"closed stack" item) 7. Go back to the biblio detail view and click on the "Closed stack request" button. Select a patron. Notice there is only one item displayed in the table (the "closed stack" item). 8. Select this item and click on "Place hold". You should be redirected to the "Closed stack requests" tab where you can see the request that you just made 9. Try to place a regular hold again. This time you should see both items in the table. 10. Go to Tools » Notices and slips 11. Create a new notice in the Holds module with code CLOSED_STACK_SLIP. Add content in the "Print" message. 12. Go to Circulation » Closed stack requests 13. You have two tabs: "Pending" and "Slip printed", you should have one request under the pending tab, and zero under the other one. 14. Click on the "Print closed stack request slip" button, in the "pending" table. A printer dialog should open, close it. The "Closed stack requests" should have been automatically refreshed, showing you an empty "pending" tab, while the "Slip printed" tab now contains the previously pending request. 15. Cancel the closed stack request. 16. Login to OPAC, find your biblio record and place a closed stack request. Like from the staff interface, only the closed stack item should be in the items table, and it should not be possible to place a biblio-level request 17. In your account page, verify that the closed stack request appear under the new tab "Closed stack requests" and that there is no "Cancel" button 18. Go back to the staff interface main page. You should see an alert at the bottom: "Pending closed stack requests: 1". Clicking on it should redirect you to the closed stack requests page seen earlier (step 12) 19. Set the closed stack item as "notforloan", either by editing the item or its item type. Verify that you can still do closed stack requests 20. Change circulation rules to forbid on-shelf holds on the closed stack item and verify that you can still do closed stack requests. Sponsored-by: Université de Lyon 3 Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180323|0 |1 is obsolete| | --- Comment #30 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 180824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180824&action=edit Bug 38666: Flag new columns as boolean (SQL12) Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #32 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- (In reply to Amaury GAU from comment #26)

(In reply to Julian Maurice from comment #22)

...

19. Set the closed stack item as "notforloan", either by editing the item or its item type. Verify that you can still do closed stack requests

It seems weird that a notforloan item can be asked from a patron. The main purpose of a notforloan item, is exactly the contrary. it should not be requestable. Otherwise, it might need a syspref to overrule this behaviour. I'd gladly ask other librarians about this.

I think it depends on local setups. Part of our collection is not for "loan" but still needs to be requested for local use. We could use onsite checkouts for it (and i think i will change to that) but it could make sense to have a notforloan status, for instance if you don't need a library account to ask for the item and don't register the local use as a checkout. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #33 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- (In reply to Amaury GAU from comment #26)

It seems weird that a notforloan item can be asked from a patron. The main purpose of a notforloan item, is exactly the contrary. it should not be requestable. Otherwise, it might need a syspref to overrule this behaviour. I'd gladly ask other librarians about this.

We asked for this feature because we need that users can ask for these books that that can't borrow outside of the library but can read inside. If you don't want that some books can be asked from the closed stacks, don't tick the flag "closed stack" on the item.

Why the request can be cancelled as "not found" before printing the slip. I guess this is a user practice to avoid.

I can understand but it's not blocking for me

There is a problem here. If the syspref `SuspendHoldsOpac` is allowed, a button 'Suspend all holds' will appear. I'm pretty sure this is not a wanted behaviour as librarians could be searching for the book while it gets cancelled.

I totally agree on this one -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #34 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hey all, we set up a branch with this development for testing. According to Andrew's testing I believe we're ready to sign-off as well, but there's a CSRF error when you submit the 'cancel marked holds' buttons. This form needs a CSRF token input: https://github.com/openfifth/koha/commit/82eafa48f791280da225b8bd556dd90151d... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #36 from Andrew Auld <andrew.auld@openfifth.co.uk> --- This is a UI comment and may not be possible, given that the development is using Holds functionality currently. In the staff side, from the biblio record, when the staff member clicks on the 'Closed stack request' button and selects a patron, it would be good if rather than 'Hold a specific item' and 'Place hold', the UI could say 'Request a specific item' and 'Place request'. This would be clearer and distinguish the workflow from a normal hold. On the OPAC, it would also be better on the closed stack request confirmation screen (effectively the hold confirmation screen) if the wording on screen could say 'Place a request for' rather than 'Place a hold on', and 'Confirm request' rather than 'Confirm hold'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #38 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- (In reply to Andrew Auld from comment #36)

This is a UI comment and may not be possible, given that the development is using Holds functionality currently. In the staff side, from the biblio record, when the staff member clicks on the 'Closed stack request' button and selects a patron, it would be good if rather than 'Hold a specific item' and 'Place hold', the UI could say 'Request a specific item' and 'Place request'. This would be clearer and distinguish the workflow from a normal hold. On the OPAC, it would also be better on the closed stack request confirmation screen (effectively the hold confirmation screen) if the wording on screen could say 'Place a request for' rather than 'Place a hold on', and 'Confirm request' rather than 'Confirm hold'.

+1 -- You are receiving this mail because: You are watching all bug changes.

From there it is possible to cancel requests or to print a slip (letter code CLOSED_STACK_SLIP in 'reserves' module) Once the slip is printed, closed stack requests move to another tab in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180822|0 |1 is obsolete| | --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 187995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187995&action=edit Bug 38666: Closed stack requests A closed stack request is a special kind of hold that can only be placed on a closed stack item. A closed stack item is an item that is not available publicly in the library but can be made available on demand. When a request is made, a librarian will print a slip then will go retrieve the document and place the slip in place of the document. Internally, a closed stack item is an item that is flagged as "closed stack" (new column items.is_closed_stack). The flag can be modified on the biblio "Items" tab. The new column can also be mapped to an item MARC subfield. An item is available for a closed stack request only if: - it is flagged as "closed stack" - there is no holds on it - it is not checked out - it is not in transfer If any of the above conditions is false, it is not available for a closed stack request but it can be available for a regular hold. In particular this means that once a closed stack request has been made on a particular item, this item can now be reserved using regular holds. Closed stack requests behave like regular holds, with the following exceptions: - They can only be placed on a specific item (item-level hold is forced) - They can be placed on "not for loan" items - They bypass the "onshelfholds" circulation rule - They cannot be cancelled from OPAC There is a new page "Closed stack requests" accessible from the circulation menu that lists all pending closed stack requests. the same page. The patch also adds a template plugin 'GD.Barcode' that allows to include a barcode image inside a letter. Useful to be able to scan the printed closed stack request slip. Example usage: [% USE GD.Barcode %] <img src="[% GD.Barcode.create_as_data_url('Code39', hold.item.barcode) | html %]"> Test plan: 1. Apply the patch: a. apply patch, b. run updatedatabase.pl and `update_dbix_class_files.pl --force`, c. run `yarn run build`, d. and finally restart koha 2. Create a biblio with two items. 3. On the biblio detail page, click on the "Items" tab 4. For one of the two items, change the "Closed stack" status from No to Yes 5. Notice there is now a "closed stack requests" tab on the left, and a "closed stack request" button in the toolbar 6. Click on "Place hold" and select a patron. Notice there is only one item displayed in the table (the non-"closed stack" item) 7. Go back to the biblio detail view and click on the "Closed stack request" button. Select a patron. Notice there is only one item displayed in the table (the "closed stack" item). 8. Select this item and click on "Place hold". You should be redirected to the "Closed stack requests" tab where you can see the request that you just made 9. Try to place a regular hold again. This time you should see both items in the table. 10. Go to Tools » Notices and slips 11. Create a new notice in the Holds module with code CLOSED_STACK_SLIP. Add content in the "Print" message. 12. Go to Circulation » Closed stack requests 13. You have two tabs: "Pending" and "Slip printed", you should have one request under the pending tab, and zero under the other one. 14. Click on the "Print closed stack request slip" button, in the "pending" table. A printer dialog should open, close it. The "Closed stack requests" should have been automatically refreshed, showing you an empty "pending" tab, while the "Slip printed" tab now contains the previously pending request. 15. Cancel the closed stack request. 16. Login to OPAC, find your biblio record and place a closed stack request. Like from the staff interface, only the closed stack item should be in the items table, and it should not be possible to place a biblio-level request 17. In your account page, verify that the closed stack request appear under the new tab "Closed stack requests" and that there is no "Cancel" button 18. Go back to the staff interface main page. You should see an alert at the bottom: "Pending closed stack requests: 1". Clicking on it should redirect you to the closed stack requests page seen earlier (step 12) 19. Set the closed stack item as "notforloan", either by editing the item or its item type. Verify that you can still do closed stack requests 20. Change circulation rules to forbid on-shelf holds on the closed stack item and verify that you can still do closed stack requests. Sponsored-by: Université de Lyon 3 Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180824|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 187997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187997&action=edit Bug 38666: Flag new columns as boolean (SQL12) Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #43 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased + fix for comment 34 / comment 35 Back to needs signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #45 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- (In reply to Andrew Auld from comment #44)

I have retested this patch and confirm that all steps in the test plan work.

The holds to pull report now runs, but the closed stack request hold doesn't show up in the report - is this deliberate?

My UI comments above are still valid.

I am happy to sign this off once I understand whether it is intended that the closed stack requests don't appear in the holds to pull report.

Hello, yes, it is intended. As the principle is that closed stacks request and holds will not be handled in the same workflow, we don't want that closed stacks to appear in "holds to pull" but only on the closed stacks request table. I hope it makes sense for everyone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #47 from Andrew Auld <andrew.auld@openfifth.co.uk> --- As above, tested and signed off and I understand the reasoning for keeping holds and closed stack requests separate on the staff side reporting. I would still encourage the UI improvement suggestions to be added as follow-up patches. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #49 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 191041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191041&action=edit Bug 38666: [DO NOT PUSH] Update DBIC schema Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 191043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191043&action=edit Bug 38666: Fix CSRF error when cancelling closed stack request Patch from commit bbffd70 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #53 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 191045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191045&action=edit Bug 38666: Make checked out closed stack items holdable Patch from commit 5bb4ed9 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Patch doesn't apply --- Comment #55 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Unsuccessful rebase attempt. I forgot could just stay at the autorebase result ( 2026-01-09 main + patches on top) and already review a lot of stuff there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #57 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

8. Select this item and click on "Place hold". You should be redirected to the "Closed stack requests" tab where you can see the request that you just made

It is weird to have hold everywhere on the page but if there is no actual confusion (it's not a thing I can really give feedback on) then it's worth not having to mess everywhere with the templates. Does anyone uses a language where the way they would translate "closed stack request" will not work well with their translation of "holds" still being everywhere around? The concepts might be close enough that this is never an issue. I'm merely highlighting this so people with functional backgrounds can dismiss or confirm the potential issue. ----

12. Go to Circulation » Closed stack requests

"The following holds have not been filled." Maybe just there it feel more clear that it's worth having the right term to be sure to not go search something in the wrong place. -----

and a "closed stack request" button in the toolbar

I previously reported that in staff I don't seed the button in the toolbar when an item is marked for closed stack. But at least here it works in the OPAC. -----

18. Go back to the staff interface main page. You should see an alert at the bottom: "Pending closed stack requests: 1".

I don't see it :o /cgi-bin/koha/circ/closed-stack-requests.pl report none. But the patrons OPAC page and the record staff page indeed list the CS request. DB: MariaDB [koha_kohadev]> select * from reserves\G *************************** 1. row *************************** reserve_id: 4 borrowernumber: 5 reservedate: 2026-03-08 biblionumber: 295 deleted_biblionumber: NULL item_group_id: NULL branchcode: FPL desk_id: NULL notificationdate: NULL reminderdate: NULL cancellationdate: NULL cancellation_reason: NULL reservenotes: priority: 1 found: NULL timestamp: 2026-03-08 03:17:03 itemnumber: 656 waitingdate: NULL expirationdate: NULL patron_expiration_date: NULL lowestPriority: 0 suspend: 0 suspend_until: NULL itemtype: NULL item_level_hold: 1 non_priority: 0 closed_stack_request_slip_printed: 0 hold_group_id: NULL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #59 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201181&action=edit Bug 38666: [DO NOT PUSH] Update DBIC schema Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #61 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201183&action=edit Bug 38666: Fix CSRF error when cancelling closed stack request -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #63 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201185&action=edit Bug 38666: Make checked out closed stack items holdable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #65 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201187&action=edit Bug 38666: Disable hold suspension for closed stack requests at OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m --- Comment #67 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Hello, I’m trying to continue the development work started by Julian; I’ve now rebased onto a fresh main branch. I spotted a few issues during my tests, so I’ve made some fixes: in the API, I’ve added a missing property; I’ve removed the button on the OPAC side that allowed users to ‘Suspend all holds’ – precisely because, as I understand it, there shouldn’t be any suspensions on the OPAC side. And I’ve changed some labelling to make the page dedicated to closed stack requests clearer. If this is on the right track, I’ll be able to add the unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Sonia Bouis <sonia.bouis@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #69 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- Hello, I can't apply the patches on a ktd : kohadev-koha@kohadevbox:koha(closedstacks)$ git bz apply 38666 📋 Bug 38666 - Closed stack requests • 201180 - Bug 38666: Closed stack requests • 201181 - Bug 38666: [DO NOT PUSH] Update DBIC schema • 201182 - Bug 38666: Flag new columns as boolean (SQL12) • 201183 - Bug 38666: Fix CSRF error when cancelling closed stack request • 201184 - Bug 38666: Fix DBI error in pendingreserves.pl • 201185 - Bug 38666: Make checked out closed stack items holdable • 201186 - Bug 38666: Add closed_stack_request_slip_printed to OpenAPI hold schema • 201187 - Bug 38666: Disable hold suspension for closed stack requests at OPAC • 201188 - Bug 38666: Fix terminology on closed stack requests page Apply? [(y)es, (n)o, (i)nteractive] y Preparing 9 patch(es): ✓ Prepared 9 patch(es) Applying 9 patch(es): Patch application failed for attachment 201180 - Bug 38666: Closed stack requests Patches left in /tmp/3NB_re4sM9 for manual application if needed To resolve: 1. Fix conflicts (use 'git mergetool' or edit files manually) 2. Stage resolved files with 'git add' 3. Continue with 'git bz apply --continue' or 'git am --continue' 4. Or skip this patch with 'git bz apply --skip' 5. Or abort with 'git bz apply --abort' Error: Apply failed: Git command (git am -3 /tmp/3NB_re4sM9/0001-201180.patch) failed: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config advice.mergeConflict false" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 i.gray@arts.ac.uk <i.gray@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.gray@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #71 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207879&action=edit Bug 38666: [DO NOT PUSH] Update DBIC schema -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #73 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207881&action=edit Bug 38666: Fix CSRF error when cancelling closed stack request -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #75 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207883&action=edit Bug 38666: Make checked out closed stack items holdable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #77 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207885&action=edit Bug 38666: Disable hold suspension for closed stack requests at OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #79 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207887&action=edit Bug 38666: Resolve QA issues in the closed stack request series -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #80 from Andrii Nugged <nugged@gmail.com> --- Rebased the original nine patches onto community main (1328267f64c78382d5048b66ecdba8905ed73f8d), preserving the original authors and commit messages. Added a separate QA follow-up for POD coverage, HTTPS GPL references, CSP nonces and formatting. No new functionality or request-processing changes are included in that follow-up. koha-qa.pl -c 10 reports no failures; the additional checks pass. The unchanged spelling warning concerns the copyright name Provence. The existing POD check for Koha/Template/Plugin/Biblio.pm is skipped because the file has no POD. Full-file formatter checks match all applicable touched files. The earlier nine attachments are retained as obsolete history. The Signed-off-by trailers in the original patches are historical; no new sign-off of this rebase is claimed. Functional review and sign-off of the new series are still needed. Would the community prefer closed stack requests to be optional through a system preference? We have a separate follow-up candidate that enables or disables the feature, restoring ordinary request behaviour when disabled. If that option is wanted, we can prepare and submit the follow-up separately. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #82 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207923&action=edit Bug 38666: [DO NOT PUSH] Update DBIC schema Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #84 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207925&action=edit Bug 38666: Fix CSRF error when cancelling closed stack request -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #86 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207927&action=edit Bug 38666: Make checked out closed stack items holdable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #88 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207929&action=edit Bug 38666: Disable hold suspension for closed stack requests at OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #90 from Andrii Nugged <nugged@gmail.com> --- Created attachment 207931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207931&action=edit Bug 38666: Resolve QA issues in the closed stack request series Document the existing closed stack filter and custom attribute helpers, use HTTPS in the GPL references, and add the standard CSP nonce to the existing inline scripts. Apply Koha's formatter to the affected method chain, template text and template parameter hash. This follow-up leaves the preceding nine patches and their original messages intact. It adds no functionality or request processing changes. Automated checks: 1. Apply the preceding nine patches and this follow-up. 2. Run koha-qa.pl -c 10 on the complete series. 3. Run misc/devel/tidy.pl --silent --no-write for the touched files. Co-Authored-By: Loontik <loontik@nugged.team> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #91 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- Hello, Thank you Andrii for reviewing these patches! I tested once again and everything seems ok : 1. Place an item in closed stacks -> OK 2. The button to request a closed stacks item is displayed via the OPAC -> OK 3. The request appears in the patron’s account under a “closed stacks” tab -> OK 4. You cannot request an item from the stacks if it has already been requested -> OK 5. You can place a hold on an item that has already been requested from the stacks -> OK 6. Add a CLOSED_STACK_SLIP notification (configuration in the Print section) -> OK 7. On the staff interface, if you’re logged into the branch where the item is held, you can see the pending request on the home page -> OK 8. There is a new “Closed Stacks Requests” section on the circulation homepage -> OK 9. The request is in the table dedicated to the closed stacks in the pending tab 10. Print the notification -> OK 11. Once the notification is printed, the request moves to the “printed slip” tab -> OK 11. The request can be viewed in a specific tab on the reader’s page -> OK 12. The request can be viewed in the “closed stacks” tab of the library record -> OK 13. Return the book -> it is set aside for the user and disappears from the circulation desk request tracking table -> OK Additionals tests : 14. If there are two items , one in closed stacks and the other in openshelves, only the one on closed stacks appears in the list of items that can be requested via the OPAC -> OK 15. You can place a hold on an item with a “not for loan” status 16. If there is one item on loan from the open shelves and one item available in closed stacks, in the OPAC, only the item on loan appears when you click “Holds,” and only the item in closed stacks appears when you click “Closed Stacks” -> OK 17. You can request a book from closed stacks using the “Closed Stacks” link on the staff interface -> OK -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #92 from Community Sandboxes <sandboxes@biblibre.com> --- Created attachment 208197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208197&action=edit Bug 38666: Closed stack requests A closed stack request is a special kind of hold that can only be placed on a closed stack item. A closed stack item is an item that is not available publicly in the library but can be made available on demand. When a request is made, a librarian will print a slip then will go retrieve the document and place the slip in place of the document. Internally, a closed stack item is an item that is flagged as "closed stack" (new column items.is_closed_stack). The flag can be modified on the biblio "Items" tab. The new column can also be mapped to an item MARC subfield. An item is available for a closed stack request only if: - it is flagged as "closed stack" - there is no holds on it - it is not checked out - it is not in transfer If any of the above conditions is false, it is not available for a closed stack request but it can be available for a regular hold. In particular this means that once a closed stack request has been made on a particular item, this item can now be reserved using regular holds. Closed stack requests behave like regular holds, with the following exceptions: - They can only be placed on a specific item (item-level hold is forced) - They can be placed on "not for loan" items - They bypass the "onshelfholds" circulation rule - They cannot be cancelled from OPAC There is a new page "Closed stack requests" accessible from the circulation menu that lists all pending closed stack requests. From there it is possible to cancel requests or to print a slip (letter code CLOSED_STACK_SLIP in 'reserves' module) Once the slip is printed, closed stack requests move to another tab in the same page. The patch also adds a template plugin 'GD.Barcode' that allows to include a barcode image inside a letter. Useful to be able to scan the printed closed stack request slip. Example usage: [% USE GD.Barcode %] <img src="[% GD.Barcode.create_as_data_url('Code39', hold.item.barcode) | html %]"> Test plan: 1. Apply the patch: a. apply patch, b. run updatedatabase.pl and `update_dbix_class_files.pl --force`, c. run `yarn run build`, d. and finally restart koha 2. Create a biblio with two items. 3. On the biblio detail page, click on the "Items" tab 4. For one of the two items, change the "Closed stack" status from No to Yes 5. Notice there is now a "closed stack requests" tab on the left, and a "closed stack request" button in the toolbar 6. Click on "Place hold" and select a patron. Notice there is only one item displayed in the table (the non-"closed stack" item) 7. Go back to the biblio detail view and click on the "Closed stack request" button. Select a patron. Notice there is only one item displayed in the table (the "closed stack" item). 8. Select this item and click on "Place hold". You should be redirected to the "Closed stack requests" tab where you can see the request that you just made 9. Try to place a regular hold again. This time you should see both items in the table. 10. Go to Tools » Notices and slips 11. Create a new notice in the Holds module with code CLOSED_STACK_SLIP. Add content in the "Print" message. 12. Go to Circulation » Closed stack requests 13. You have two tabs: "Pending" and "Slip printed", you should have one request under the pending tab, and zero under the other one. 14. Click on the "Print closed stack request slip" button, in the "pending" table. A printer dialog should open, close it. The "Closed stack requests" should have been automatically refreshed, showing you an empty "pending" tab, while the "Slip printed" tab now contains the previously pending request. 15. Cancel the closed stack request. 16. Login to OPAC, find your biblio record and place a closed stack request. Like from the staff interface, only the closed stack item should be in the items table, and it should not be possible to place a biblio-level request 17. In your account page, verify that the closed stack request appear under the new tab "Closed stack requests" and that there is no "Cancel" button 18. Go back to the staff interface main page. You should see an alert at the bottom: "Pending closed stack requests: 1". Clicking on it should redirect you to the closed stack requests page seen earlier (step 12) 19. Set the closed stack item as "notforloan", either by editing the item or its item type. Verify that you can still do closed stack requests 20. Change circulation rules to forbid on-shelf holds on the closed stack item and verify that you can still do closed stack requests. Sponsored-by: Université de Lyon 3 Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #94 from Community Sandboxes <sandboxes@biblibre.com> --- Created attachment 208199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208199&action=edit Bug 38666: Flag new columns as boolean (SQL12) Signed-off-by: thibault <thibault.keromnes@univ-paris8.fr> Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #96 from Community Sandboxes <sandboxes@biblibre.com> --- Created attachment 208201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208201&action=edit Bug 38666: Fix DBI error in pendingreserves.pl Error was: Column 'itemnumber' in WHERE is ambiguous Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #98 from Community Sandboxes <sandboxes@biblibre.com> --- Created attachment 208203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208203&action=edit Bug 38666: Add closed_stack_request_slip_printed to OpenAPI hold schema Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 --- Comment #100 from Community Sandboxes <sandboxes@biblibre.com> --- Created attachment 208205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208205&action=edit Bug 38666: Fix terminology on closed stack requests page Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Community Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #102 from Community Sandboxes <sandboxes@biblibre.com> --- Signed off using a sandbox -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38666 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #103 from Andrii Nugged <nugged@gmail.com> --- (In reply to Andrii Nugged from comment #80)

Would the community prefer closed stack requests to be optional through a system preference? We have a separate follow-up candidate that enables or disables the feature, restoring ordinary request behaviour when disabled. If that option is wanted, we can prepare and submit the follow-up separately.

Closed stack requests: on/off setting We have prepared an optional system preference, EnableClosedStackRequests, that turns the closed stack request feature on or off. When it is off, the closed stack options are hidden in the staff interface and the OPAC, and holds on these items follow the ordinary hold rules. Existing data is kept, so the feature can be switched back on later. It is on by default, so nothing changes for you unless you switch it off. Would you/anyone like this setting included in your Koha? Some our librarians not using this feature and confused to have it in interfase and asked to have it off. I can attach two extra commits with this feature here. --- Comment #104 from Andrii Nugged <nugged@gmail.com> --- (In reply to Andrii Nugged from comment #80)

Would the community prefer closed stack requests to be optional through a system preference? We have a separate follow-up candidate that enables or disables the feature, restoring ordinary request behaviour when disabled. If that option is wanted, we can prepare and submit the follow-up separately.

Closed stack requests: on/off setting We have prepared an optional system preference, EnableClosedStackRequests, that turns the closed stack request feature on or off. When it is off, the closed stack options are hidden in the staff interface and the OPAC, and holds on these items follow the ordinary hold rules. Existing data is kept, so the feature can be switched back on later. It is on by default, so nothing changes for you unless you switch it off. Would you/anyone like this setting included in your Koha? Some our librarians not using this feature and confused to have it in interfase and asked to have it off. I can attach two extra commits with this feature here. -- You are receiving this mail because: You are watching all bug changes.