[Bug 7231] New: ordering from staged file not using price
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Bug #: 7231 Summary: ordering from staged file not using price Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com when you're ordering from a staged file if you import all the price comes over, if you do it one by one you don't get the price. the price should fill in in both instances. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-01-24 04:42:35 UTC --- Can you please provide more details, maybe a screenshot if it is not a problem. I tried ordering a single record from a file, which took me to the new empty order with the price fields. On the other hand, I could not see price on the "Import All" screen. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2012-01-24 05:04:53 UTC --- Srdjan, When you ordered from the single record, there were price fields but they were not populated - or were they? When you order from a full file there is no price field, but when you finish the import you see the price on each line item. Video: http://screencast.com/t/JU7RrfmoVf -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff AssignedTo|henridamien@koha-fr.org |srdjan@catalyst.net.nz --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-01-27 02:23:04 UTC --- Created attachment 7341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7341 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-07 13:21:59 UTC --- If price in 020$c has a currency symbol ( e.g. $12.00 ), this price will not be pulled over. If it is just a bare number ( e.g. 12.00 ), it works just fine. Is this expected behavior? As an aside, why does GetMarcPrice look for the price in 345$c? Field 345 is "Projection Characteristics of Moving Image", and doesn't even have a subfield c, let alone a price in it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-07 14:05:55 UTC --- I'm going to revise my previous comment and state that this is good functionality. The price is only pulled if we are sure it is really a price. 020$c can contain many different things, not just prices. From the LOC 022 Page: 020 ##$a0802142176 (pbk.) :$c$1.95 020 ##$c$8.95 020 ##$cRs15.76 ($5.60 U.S.) 020 ##$cRental material 020 ##$cFor sale ($450.00) or rent ($45.00) 020 ##$cFor sale ($200.00 for 3/4 in.; $150.00 for 1/2 in.) 020 ##$c$4.95 (lib. bdg.) 020 ##$c$3.60 (pbk.) [Two prices for two items on one catalog record; no ISBNs are known.] I think ignoring 020$c if it doesn't contain just a numeral is safe, but stripping out currency characters, or using them to decide the currency would be better. Perhaps that should be a separate bug report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-07 14:11:05 UTC --- I need to switch my opinion *again*. I stand by my previous statement, but the "Import All" option works with or without a dollar sign in 020$c. Since both should be functionally equivalent, the single record import needs to be able to handle this as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-08 23:43:00 UTC --- Can you please check if the behaviour was different before the patch? If it was, I will correct it. Otherwise, we should file a separate bug to make it work correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7516 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 --- Comment #8 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-09 14:56:28 UTC --- (In reply to comment #7) I believe this behavior should not be considered different than before, and I have created and attached a separate bug report, Bug 7516 - Create Subroutine For GetMarcPrice that will discern the actual price from a given price field value. for this issue.
Can you please check if the behaviour was different before the patch? If it was, I will correct it. Otherwise, we should file a separate bug to make it work correctly.
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-09 14:58:31 UTC --- Created attachment 7528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7528 bug_7231: Call GetMarcPrice() in acqui/neworderempty.pl for staged imports -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-09 15:00:05 UTC --- Created attachment 7529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7529 bug_7231: Call GetMarcPrice() in acqui/neworderempty.pl for staged imports Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7341|0 |1 is obsolete| | Attachment #7528|0 |1 is obsolete| | Attachment #7529|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-09 15:05:00 UTC --- Created attachment 7530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7530 bug_7231: Call GetMarcPrice() in acqui/neworderempty.pl for staged imports -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7530|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-09 15:05:38 UTC --- Created attachment 7531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7531 [SIGNED-OFF] bug_7231: Call GetMarcPrice() in acqui/neworderempty.pl for staged imports -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-20 21:25:19 UTC --- QA comment: small patch, use a sub instead of a copy/paste of some code -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-20 21:29:44 UTC --- (In reply to comment #4)
As an aside, why does GetMarcPrice look for the price in 345$c? Field 345 is "Projection Characteristics of Moving Image", and doesn't even have a subfield c, let alone a price in it.
The 345 is an alternate place for the price in UNIMARC. I don't know for MARC21 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7231 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch will be included in the forthcoming 3.6.5 release (no string changes). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org