[Bug 28898] New: Disambiguisation for translation : term
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Bug ID: 28898 Summary: Disambiguisation for translation : term Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In English, "term" has many different meanings, evidenced here : https://www.merriam-webster.com/dictionary/term In French, we have different words for these, and the case that mainly interests me here is 1 : a word or expression that has a precise meaning in some uses or is peculiar to a science, art, profession, or subject (for example "search term", "broader term", etc.) vs 3 : division in a school year during which instruction is regularly given to students (i.e. semester) in the case of course reserves. For example, #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt:43 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt:139 #: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-authorities.inc:14 #, c-format msgid "Term" msgstr "Terme" Here, there are instances of the word in authorities and tags, which presumably have the first meaning. And there is one instance in course reserves where is means semester. I propose to disambiguate the term "term" specifically for course reserves, where the meaning is "semester". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same problem in German btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Good! that means it will benefit more than one language :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Disambiguisation for |Context for translation: |translation : term |term (word) vs. term | |(semester) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 124089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124089&action=edit Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I apologize for the gazillion steps in the test plan >_< I hope I did everything right, it's been a while. Let me know if anything needs changing. Caroline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124089|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124212&action=edit Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124213&action=edit Bug 28898: (follow-up) Remove comment lines before PROCESS statements Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124214&action=edit Bug 28898: (follow-up) Add context to some more occurrences of Term in course reserves Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Caroline, I used to have to rename these with jQuery, so quite keen on these patches. I have found some more "Term:" in the course reserves templates, would you check my follow-up and maybe sign off on them? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124212|0 |1 is obsolete| | --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 124438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124438&action=edit Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124213|0 |1 is obsolete| | --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 124439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124439&action=edit Bug 28898: (follow-up) Remove comment lines before PROCESS statements Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124214|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 124440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124440&action=edit Bug 28898: (follow-up) Add context to some more occurrences of Term in course reserves Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This was my first time signing off a patch of a set and I ran into errors. I hope I did everything ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124438|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 124741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124741&action=edit Bug 28898: Context for translation: term (word) vs. term (semester) This patch add context to the term Term in the context of course reserves. To test: 0- Apply patch Set up course reserves 1- Enable UseCourseReserves 2- Create at least one authorized value for DEPARTMENT 3- Create at least one authorized value for TERM 4- Create a course 5- Add at least one item to the course Check the terms: 6- Go to the OPAC 7- Go to Course reserves ** 8- In the list of courses, check the Term column heading 9- Go to the staff interface 10- Go to Course reserves ** 11- In the list of courses, check the Term column heading 12- Click on the course name ** 13- Check the Term line in the course description Add a new language (fr-CA in the example, change for whatever language code you want) 14- In a terminal, run gulp po:create --lang fr-CA 15- Then, run gulp po:update --lang fr-CA 16- In system preferences, enable the new language in language and OpacLanguages 17- Switch the language in staff interface and OPAC Change the translations 18- In your favourite text editor, open fr-CA-messages.po 19- Find the string 'msgctxt Semester' 20- Enter a word in msgstr 21- Save the file 22- In a terminal, go to misc/translator 23- Run ./translate install fr-CA Check the translations 24- Redo the steps to check the terms (6-16) and make sure the terms in steps 8, 11, and 13 are changed for the word you put in step 20. 25- Optionally, check the following pages to make sure the terms are not the word you put in step 20 (these pages shouldn't have been changed) - opac-tags (your account > your tags) - opac-authorities (search for an authority in Authority search) - review (tags in staff interface) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124439|0 |1 is obsolete| | --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 124742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124742&action=edit Bug 28898: (follow-up) Remove comment lines before PROCESS statements Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124440|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 124743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124743&action=edit Bug 28898: (follow-up) Add context to some more occurrences of Term in course reserves Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This disambiguates the term release notes| |"term" used in course | |reserves, where the meaning | |is "semester". This allows | |it to be translated, rather | |than having to use JQuery | |to change the text | |displayed for languages | |other then English. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #17 from David Cook <dcook@prosentient.com.au> --- I'm a bit confused by this one. Does it show "Term" in the English UI but "Semester" in the translation file? While a "semester" is a "term", not all terms are semesters. https://en.wikipedia.org/wiki/Academic_term French should be the same as English with trimestres, semestres, etc. I'm not across Koha's translation idiosyncrasies but I can't see how "semester" would be the right choice here. Happy for someone to explain it though as I imagine I'm just confused. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- For context, here in Sydney Australia some universities use semesters and others use trimesters for their academic terms. While back in western Canada we had quarter terms in high school. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #17)
I'm a bit confused by this one.
Does it show "Term" in the English UI but "Semester" in the translation file?
The strings with the same context will be translated together with the context showing as a "hint" when translating. You still see "term". The English GUI is not changed by this patch set at all. The main point here is not semester vs. term, but more: term vs. search terms. We have "term" showing up in context of search and in the course reserves module. The context is different, but without this patch you can't differentiate. In German the term for 'time' and term for 'words' are completely different words and this patch allows to use different translations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #19)
(In reply to David Cook from comment #17)
I'm a bit confused by this one.
Does it show "Term" in the English UI but "Semester" in the translation file?
The strings with the same context will be translated together with the context showing as a "hint" when translating. You still see "term". The English GUI is not changed by this patch set at all.
The main point here is not semester vs. term, but more: term vs. search terms. We have "term" showing up in context of search and in the course reserves module. The context is different, but without this patch you can't differentiate. In German the term for 'time' and term for 'words' are completely different words and this patch allows to use different translations.
Thanks for the explanation, Katrin. I figured it must be something like that but it wasn't obvious at a glance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This disambiguates the term |This disambiguates and release notes|"term" used in course |provides a hint for |reserves, where the meaning |translating the term "term" |is "semester". This allows |used in course reserves, |it to be translated, rather |where the meaning is |than having to use JQuery |"semester" rather than |to change the text |something like search term. |displayed for languages |This allows it to be |other then English. |translated, rather than | |having to use JQuery to | |change the text displayed | |for languages other then | |English. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org