[Bug 42322] New: Collapse sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Bug ID: 42322 Summary: Collapse sidebar Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. It would be good to have the behaviour available everywhere, not only on the report result view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196990&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196991&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196992&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196993&action=edit Bug 42322: Auto tidy To ease rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Note that main-container.inc is still not used from all our template files, but the ultimate goal is to have it everywhere! With the new addition from the second patch (Pass the aside to main-container) it will be easier to reuse it where it's not yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |george@nekls.org, | |katrin.fischer@bsz-bw.de, | |michael.skarupianski@gmail. | |com, | |michaela.sieber@kit.edu, | |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- This is a good idea imo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 [Bug 42190] Add datatables to reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |matt.blenkinsop@openfifth.c | |o.uk, | |pedro.amorim@openfifth.co.u | |k --- Comment #7 from Michaela Sieber <michaela.sieber@kit.edu> --- Yes, I love it. I often wish there were a “collapse the sidebar” option. At the hackfest, we had several topics dealing with large tables (circulation rules, the items table on the biblio details page, etc.). Even if we address these cases, there will still be other places in Koha where tables don’t fit the width of the screen. And even if they do fit on a “normal” screen size, it would still be helpful for users who have smaller screens or prefer more space for content. I think this would be a great improvement for usability. I’m adding Matt, as we discussed this some time ago in one of our acquisitions meetings as well :-) I guess we need a separate bug for the VueJS sidebar ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197001&action=edit Bug 42322: Vue apps Patch from commit 6b07208 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197001|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197002&action=edit Bug 42322: Vue apps Patch from commit 21beb5e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31159 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #10 from Michaela Sieber <michaela.sieber@kit.edu> --- *** Bug 31159 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42330 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Bug 42330 will take care of adding the collapse button to all our templates (using main-container.inc). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42330 [Bug 42330] Use main-container.inc from all the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #12 from Mathieu Saby <mathsabypro@gmail.com> --- +100 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42190 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42190 [Bug 42190] Add datatables to reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197091&action=edit Bug 42322: WIP - improve styling Patch from commit e411e25 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197092&action=edit Bug 42322: WIP - improve styling Patch from commit 28605ea -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 197093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197093&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 197094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197094&action=edit Bug 42322: (follow-up) A version with just the button Patch from commit dc1b111 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Skip the "WIP - improve styling" patch to test my follow-ups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42163 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197141&action=edit Bug 42322: Hide .patroninfo when collapsed Fix sidebar when collapsed on /members/moremember.pl?borrowernumber=42 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197153&action=edit Bug 42322: Hide .patroninfo and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197153|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197155&action=edit Bug 42322: Hide .patroninfo and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Test plan: Apply the patches and regenerate the CSS files (yarn css:build) The go to different pages in Koha and confirm that the sidebar can be collapsed using the new button (top-right of the sidebar). Test the Vue apps and the regular views. Note that this will only apply to template using the main-container include file. Some files don't use it yet. See bug 42330. Tell us if you would prefer the state of the sidebar to be preserved when navigating. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197155|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197181&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197182&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196992|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197093|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197094|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #24 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 197193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197193&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #25 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 197194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197194&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #26 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 197195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197195&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #27 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 197196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197196&action=edit Bug 42322: Auto tidy To ease rebase! Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #28 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 197197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197197&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #29 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 197198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197198&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #30 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 197199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197199&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #31 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 197200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197200&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> ---
Bug 42322: (follow-up) Proposed alternative style
This version keeps a visual indicator of the collapsed sidebar.
Testers please note that I have proposed two versions here. Please test with the "A version with just the button" patch and without it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #33 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Owen Leonard from comment #32)
Bug 42322: (follow-up) Proposed alternative style
This version keeps a visual indicator of the collapsed sidebar.
Testers please note that I have proposed two versions here. Please test with the "A version with just the button" patch and without it.
We tested both versions and like the second version (with all Patches applied incl. "A version with just the button" patch ) most -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42748 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 [Bug 42748] Rewrite selenium/administration_tasks.t using Cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197193|0 |1 is obsolete| | Attachment #197194|0 |1 is obsolete| | Attachment #197195|0 |1 is obsolete| | Attachment #197196|0 |1 is obsolete| | Attachment #197197|0 |1 is obsolete| | Attachment #197198|0 |1 is obsolete| | Attachment #197199|0 |1 is obsolete| | Attachment #197200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200060&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200061&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200062&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200063&action=edit Bug 42322: Auto tidy To ease rebase! Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200064&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200065&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200066&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200067&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42748 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42748 [Bug 42748] Rewrite selenium/administration_tasks.t using Cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Signed Off |Patch doesn't apply --- Comment #43 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(... git bz apply 42322 📋 Bug 42322 - Collapse sidebar • 200060 - Bug 42322: Add a 'collapse sidebar' button • 200061 - Bug 42322: Pass the aside to main-container • 200062 - Bug 42322: Use main-container.inc from reports • 200063 - Bug 42322: Auto tidy • 200064 - Bug 42322: Vue apps • 200065 - Bug 42322: (follow-up) Proposed alternative style • 200066 - Bug 42322: (follow-up) A version with just the button • 200067 - Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Apply? [(y)es, (n)o, (i)nteractive] y Preparing 8 patch(es): ✓ Prepared 8 patch(es) Applying 8 patch(es): ✓ [1/8] Applied Bug 42322: Add a 'collapse sidebar' button ✓ [2/8] Applied Bug 42322: Pass the aside to main-container ✓ [3/8] Applied Bug 42322: Use main-container.inc from reports Patch application failed for attachment 200063 - Bug 42322: Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200060|0 |1 is obsolete| | Attachment #200061|0 |1 is obsolete| | Attachment #200062|0 |1 is obsolete| | Attachment #200063|0 |1 is obsolete| | Attachment #200064|0 |1 is obsolete| | Attachment #200065|0 |1 is obsolete| | Attachment #200066|0 |1 is obsolete| | Attachment #200067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200118&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #45 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200119&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #46 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200120&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #47 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200121&action=edit Bug 42322: Auto tidy To ease rebase! Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #48 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200122&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200123&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200124&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #51 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200125&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200121|0 |1 is obsolete| | Attachment #200122|0 |1 is obsolete| | Attachment #200123|0 |1 is obsolete| | Attachment #200124|0 |1 is obsolete| | Attachment #200125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #52 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200508&action=edit Bug 42322: Auto tidy To ease rebase! Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #53 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200509&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #54 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200510&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #55 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200511&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #56 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200512&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #57 from Jonathan Druart <jonathan.druart@gmail.com> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200118|0 |1 is obsolete| | Attachment #200119|0 |1 is obsolete| | Attachment #200120|0 |1 is obsolete| | Attachment #200508|0 |1 is obsolete| | Attachment #200509|0 |1 is obsolete| | Attachment #200510|0 |1 is obsolete| | Attachment #200511|0 |1 is obsolete| | Attachment #200512|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #58 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200519&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200520&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #60 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200521&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #61 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200522&action=edit Bug 42322: Auto tidy To ease rebase! Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200523&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #63 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200524&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200525&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #65 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200526&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #66 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200527&action=edit Bug 42322: Add missing raw filter for aside_block Patch from commit ce5073b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #32)
Bug 42322: (follow-up) Proposed alternative style
This version keeps a visual indicator of the collapsed sidebar.
Testers please note that I have proposed two versions here. Please test with the "A version with just the button" patch and without it.
Without the "A version with just the button" patch this does not apply clean. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- With all patches applied this looks and works great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
Tell us if you would prefer the state of the sidebar to be preserved when navigating.
In my opinion, yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- When I collapse the menu the aria-expanded attribute still is aria-expanded="true" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #71 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200905&action=edit Bug 42322: Correctly toggle aria-expanded Patch from commit d0e976a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #72 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #70)
When I collapse the menu the aria-expanded attribute still is aria-expanded="true"
Fixed. Thanks for your interest in this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- When the sidebar is collapsed and I shrink my screen to less than 1000px the toggle icon becomes a useless grey box on the right hand side of the screen. This happens to me in both FF and Chrome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #74 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass (lukeg) from comment #73)
When the sidebar is collapsed and I shrink my screen to less than 1000px the toggle icon becomes a useless grey box on the right hand side of the screen. This happens to me in both FF and Chrome.
Libraries).
Can confirm: 1. Go to a page with a sidebar (for example, Administration > Basic parameters 2. Click the arrow to collapse the sidebar. 3. Make the browser window narrower. 4. Becomes a darker grey box under the help icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #75 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200965&action=edit Bug 42322: Hide collapsed sidebar on small screens When the sidebar is collapsed and the screen is resized to <= 1000px, '#sidebar-container' should be hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #76 from Jonathan Druart <jonathan.druart@gmail.com> --- This patch fixes the problem! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #77 from David Nind <david@davidnind.com> --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #78 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200989&action=edit Bug 42322: (follow-up) Switch to mobile-first handling of sidebar toggle Patch from commit 814819b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200519|0 |1 is obsolete| | Attachment #200520|0 |1 is obsolete| | Attachment #200521|0 |1 is obsolete| | Attachment #200522|0 |1 is obsolete| | Attachment #200523|0 |1 is obsolete| | Attachment #200524|0 |1 is obsolete| | Attachment #200525|0 |1 is obsolete| | Attachment #200526|0 |1 is obsolete| | Attachment #200527|0 |1 is obsolete| | Attachment #200905|0 |1 is obsolete| | Attachment #200965|0 |1 is obsolete| | Attachment #200989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #79 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201015&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #80 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201016&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #81 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201017&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #82 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201018&action=edit Bug 42322: Auto tidy To ease rebase! Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #83 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201019&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #84 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201020&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #85 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201021&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #86 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201022&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #87 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201023&action=edit Bug 42322: Add missing raw filter for aside_block Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #88 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201024&action=edit Bug 42322: Correctly toggle aria-expanded Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #89 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201025&action=edit Bug 42322: Hide collapsed sidebar on small screens When the sidebar is collapsed and the screen is resized to <= 1000px, '#sidebar-container' should be hidden Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #90 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201026&action=edit Bug 42322: (follow-up) Switch to mobile-first handling of sidebar toggle Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Status|Passed QA |Failed QA --- Comment #91 from Lisette Scheer <lisette@bywatersolutions.com> --- Bug 42322: Auto tidy (202.52 KB, patch) causes a sha1 error. Error: Apply failed: Git command (git am -3 /tmp/_ZtRVof1Kc/0001-201018.patch) failed: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201015|0 |1 is obsolete| | Attachment #201016|0 |1 is obsolete| | Attachment #201017|0 |1 is obsolete| | Attachment #201018|0 |1 is obsolete| | Attachment #201019|0 |1 is obsolete| | Attachment #201020|0 |1 is obsolete| | Attachment #201021|0 |1 is obsolete| | Attachment #201022|0 |1 is obsolete| | Attachment #201023|0 |1 is obsolete| | Attachment #201024|0 |1 is obsolete| | Attachment #201025|0 |1 is obsolete| | Attachment #201026|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #92 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201978&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #93 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201979&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #94 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201980&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #95 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201981&action=edit Bug 42322: Auto tidy To ease rebase! Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #96 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201982&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #97 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201983&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #98 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201984&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #99 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201985&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #100 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201986&action=edit Bug 42322: Add missing raw filter for aside_block Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #101 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201987&action=edit Bug 42322: Correctly toggle aria-expanded Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #102 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201988&action=edit Bug 42322: Hide collapsed sidebar on small screens When the sidebar is collapsed and the screen is resized to <= 1000px, '#sidebar-container' should be hidden Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #103 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201989&action=edit Bug 42322: (follow-up) Switch to mobile-first handling of sidebar toggle Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201978|0 |1 is obsolete| | Attachment #201979|0 |1 is obsolete| | Attachment #201980|0 |1 is obsolete| | Attachment #201981|0 |1 is obsolete| | Attachment #201982|0 |1 is obsolete| | Attachment #201983|0 |1 is obsolete| | Attachment #201984|0 |1 is obsolete| | Attachment #201985|0 |1 is obsolete| | Attachment #201986|0 |1 is obsolete| | Attachment #201987|0 |1 is obsolete| | Attachment #201988|0 |1 is obsolete| | Attachment #201989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #104 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202791&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #105 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202792&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #106 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202793&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #107 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202794&action=edit Bug 42322: Auto tidy To ease rebase! Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #108 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202795&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #109 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202796&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #110 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202797&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #111 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202798&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #112 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202799&action=edit Bug 42322: Add missing raw filter for aside_block Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #113 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202800&action=edit Bug 42322: Correctly toggle aria-expanded Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #114 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202801&action=edit Bug 42322: Hide collapsed sidebar on small screens When the sidebar is collapsed and the screen is resized to <= 1000px, '#sidebar-container' should be hidden Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #115 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202802&action=edit Bug 42322: (follow-up) Switch to mobile-first handling of sidebar toggle Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #116 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- 1) ILL module home page sidebar renders broken/squashed (not accounted for in the patchset): - http://localhost:8081/cgi-bin/koha/ill/home 2) The patron-title h5 on the siderbar of the patron is no longer clickable: Visit before and after the patches: http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=42 3) A change like this should include some sort of test given its blast radius. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #117 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Pedro Amorim (ammopt) from comment #116)
2) The patron-title h5 on the siderbar of the patron is no longer clickable
I think the fact that the h5 is clickable is an unintended side-effect of Bug 29768 and should be considered a bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #118 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #117)
should be considered a bug.
I have filed Bug 43220. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202791|0 |1 is obsolete| | Attachment #202792|0 |1 is obsolete| | Attachment #202793|0 |1 is obsolete| | Attachment #202794|0 |1 is obsolete| | Attachment #202795|0 |1 is obsolete| | Attachment #202796|0 |1 is obsolete| | Attachment #202797|0 |1 is obsolete| | Attachment #202798|0 |1 is obsolete| | Attachment #202799|0 |1 is obsolete| | Attachment #202800|0 |1 is obsolete| | Attachment #202801|0 |1 is obsolete| | Attachment #202802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #119 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203335&action=edit Bug 42322: Add a 'collapse sidebar' button On bug 42190 we discuss the possibility to collapse the sidebar in order to enlarge the screen and specifically the table in the main div. This patch adds the button to main-container.inc that is supposed to be used from everywhere. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #120 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203336&action=edit Bug 42322: Pass the aside to main-container Improve main-container.inc so we can pass a specific aside block Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #121 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203337&action=edit Bug 42322: Use main-container.inc from reports Pass the aside block from the report module Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #122 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203338&action=edit Bug 42322: Auto tidy To ease rebase! Re-run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #123 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203339&action=edit Bug 42322: Vue apps Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #124 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203340&action=edit Bug 42322: (follow-up) Proposed alternative style This version keeps a visual indicator of the collapsed sidebar. I've also added handling of the "aria-expanded" attribute. Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #125 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203341&action=edit Bug 42322: (follow-up) A version with just the button Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #126 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203342&action=edit Bug 42322: Hide .patroninfo, .browse-controls and #search-facets when collapsed Fix sidebar when collapsed on: * /members/moremember.pl?borrowernumber=42 * /catalogue/search.pl?advsearch=1&idx=kw&q=d&idx=kw&q=&idx=kw&q=&weight_search_submitted=1&weight_search=1&sort_by=relevance * /catalogue/detail.pl?biblionumber=438&searchid=scs_1776086577193 (with BrowseResultSelection ON) Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #127 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203343&action=edit Bug 42322: Add missing raw filter for aside_block Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #128 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203344&action=edit Bug 42322: Correctly toggle aria-expanded Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #129 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203345&action=edit Bug 42322: Hide collapsed sidebar on small screens When the sidebar is collapsed and the screen is resized to <= 1000px, '#sidebar-container' should be hidden Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #130 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203346&action=edit Bug 42322: (follow-up) Switch to mobile-first handling of sidebar toggle Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #131 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203347&action=edit Bug 42322: (follow-up) Correct markup of ILL sidebar menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #132 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Pedro Amorim (ammopt) from comment #116)
1) ILL module home page sidebar renders broken/squashed (not accounted for in the patchset): - http://localhost:8081/cgi-bin/koha/ill/home
I have rebased the patches and added a followup to fix the ILL sidebar problem. We still need tests, so I'm leaving this as FQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #133 from Owen Leonard <oleonard@myacpl.org> ---
We still need tests, so I'm leaving this as FQA
Or does the test on Bug 42330 fulfill this requirement? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 --- Comment #134 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks for the work here Owen. I'm happy with moving this to PQA as is, but inclined on waiting on Joubu's opinion once he's back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42322 Kimberly <kimberly.diebolt@edcgov.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kimberly.diebolt@edcgov.us -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org