[Bug 29565] New: selenium/regressions.t can fail on slow boxes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Bug ID: 29565 Summary: selenium/regressions.t can fail on slow boxes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 25551 # Failed test 'Encoding in session variables' # at t/db_dependent/selenium/regressions.t line 300. Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 285. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127972&action=edit Bug 29565: Prevent regressions.t to fail on slow boxes It's failing randomly on some Jenkins' nodes # Failed test 'Encoding in session variables' # at t/db_dependent/selenium/regressions.t line 300. Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 285. It can be recreated locally with the following changes: @ t/lib/Selenium.pm:50 @ sub new { ); bless $self, $class; $self->add_error_handler; - $self->driver->set_implicit_wait_timeout(5000); + $self->driver->set_implicit_wait_timeout(1000); return $self; } @ t/lib/Selenium.pm:50 @ sub new { ); bless $self, $class; $self->add_error_handler; - $self->driver->set_implicit_wait_timeout(5000); + $self->driver->set_implicit_wait_timeout(1000); return $self; } This patch suggests to simply double the timeout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patch pushed to master for 21.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Not fixed, Koha_Master/1885 00:58:27 koha_1 | # Looks like you planned 18 tests but ran 1. 00:58:27 koha_1 | 00:58:27 koha_1 | # Failed test 'Encoding in session variables' 00:58:27 koha_1 | # at t/db_dependent/selenium/regressions.t line 300. 00:58:27 koha_1 | Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 285. 00:58:27 koha_1 | # Looks like your test exited with 2 just after 6. 00:58:27 koha_1 | [23:58:24] t/db_dependent/selenium/regressions.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #1)
@ t/lib/Selenium.pm:50 @ sub new { ); bless $self, $class; $self->add_error_handler; - $self->driver->set_implicit_wait_timeout(5000); + $self->driver->set_implicit_wait_timeout(1000); return $self; }
This patch suggests to simply double the timeout.
5000*2=1000?? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Koha_Master/2531 22:21:45 koha_1 | # Looks like you planned 18 tests but ran 15. 22:21:45 koha_1 | 22:21:45 koha_1 | # Failed test 'Encoding in session variables' 22:21:45 koha_1 | # at t/db_dependent/selenium/regressions.t line 340. 22:21:45 koha_1 | Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 325. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Koha_22.11_D11/188 11:21:22 koha_1 | Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. 11:21:22 koha_1 | Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. 11:21:22 koha_1 | # Looks like you planned 18 tests but ran 7. 11:21:22 koha_1 | 11:21:22 koha_1 | # Failed test 'Encoding in session variables' 11:21:22 koha_1 | # at t/db_dependent/selenium/regressions.t line 340. 11:21:22 koha_1 | Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 325. 11:21:22 koha_1 | # Looks like your test exited with 11 just after 7. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org