[Bug 26819] New: Error when adding items to course reserves - can't view items in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Bug ID: 26819 Summary: Error when adding items to course reserves - can't view items in the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org Created attachment 112487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112487&action=edit Error trace - listing items for a course reserve After adding an item to a course: - you cannot view the items for the course in the staff interface, and - there is an error trace message. You can view the items as expected in the OPAC. To recreate: 1. In the staff interface go to course reserves. 2. Add a new course. 3. Add a reserve (Add reserves > add a valid barcode > submit). 4. Go to the list of courses and select the course you added the item to. 5. An error trace log is generated - see attachment. Tested on master using koha-testing-docker. Functionality works as expected in 20.05.x. Identified when testing bug 19532 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed on master with kohadevbox. My item was 39999000000276 from sample data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112848&action=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112848|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 112861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112861&action=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112861|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112878&action=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |26323 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 9bbf90969304943210e24dcd69422c9fe7d28303 Bug 26323: (follow-up) Add new cases introduced Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It may fixes the crash, but not the behaviour. The parameter is authorised_value, not authorized_value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is also another occurrence in circ/branchtransfers.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113926&action=edit Bug 26819: (QA follow-up) authorized_value should be authorised_value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113927&action=edit Bug 26819: (QA follow-up) Fix branchtransfers.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 27038 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113927|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113978&action=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113979&action=edit Bug 26819: (QA follow-up) authorized_value should be authorised_value Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113980&action=edit Bug 26819: (QA follow-up) Fix branchtransfers.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Works as expected, passes the QA script. Sanity check is ok as well: $ git grep AuthorisedValues.GetDescriptionByKohaField | grep -v authorised_value => empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an error release notes| |introduced during the 20.11 | |development cycle with | |course reserves. After | |adding an item you could | |not list the items for a | |course in the staff | |interface (an error page | |was generated), and you | |could not add additional | |items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependencies, not backported for 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Bug 26819 depends on bug 26323, which changed state. Bug 26323 Summary: Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org