[Bug 9292] New: Remove dead code related to 'publictype'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Bug ID: 9292 Summary: Remove dead code related to 'publictype' Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14153&action=edit Bug 9292 - Remove dead code related to 'publictype' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Patch complexity|--- |Trivial patch Severity|enhancement |minor --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch should have a commit message which includes a description of the problem, a description of the solution, and a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14153|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14366&action=edit Bug 9292 - Remove dead code related to 'publictype' This patch removes the superflous code related to 'publictype' which is a key set for item hashes in some perl files. This key is never used or stored. Test Plan: 1) Apply patch 2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl 3) You should not see any changes in behavior -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14366|0 |1 is obsolete| | --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14484&action=edit Bug 9292 - Remove dead code related to 'publictype' This patch removes the superflous code related to 'publictype' which is a key set for item hashes in some perl files. This key is never used or stored. Test Plan: 1) Apply patch 2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl 3) You should not see any changes in behavior Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: I did not find any occurrence of publictype. These lines are useless and can be deleted. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14484|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14497&action=edit Bug 9292 - Remove dead code related to 'publictype' This patch removes the superflous code related to 'publictype' which is a key set for item hashes in some perl files. This key is never used or stored. Test Plan: 1) Apply patch 2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl 3) You should not see any changes in behavior Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9292 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x, will be in 3.10.2 and 3.8.9 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org