https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168762&action=edit Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168762|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 168774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168774&action=edit Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't want to miss something, please rebase! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168774|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171070&action=edit Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171071|0 |1 is obsolete| | --- Comment #6 from Olivier V <ovezina@inlibro.com> --- Created attachment 171148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171148&action=edit Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses Rather than add a style to a whole table row I think we should use BS5's badge classes to style debug mode and default configuration information. To test you should have at least one SMTP server set as default and at least one with debug mode turned on. Go to Administration -> SMTP servers and view the table of SMTP servers. Any server with debug mode turned on should show "On" styled as a yellow badge with black text. A server set as default should show "Default" styled as a green badge with white text. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171070|0 |1 is obsolete| | --- Comment #7 from Olivier V <ovezina@inlibro.com> --- Created attachment 171149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171149&action=edit Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174475&action=edit Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses Rather than add a style to a whole table row I think we should use BS5's badge classes to style debug mode and default configuration information. To test you should have at least one SMTP server set as default and at least one with debug mode turned on. Go to Administration -> SMTP servers and view the table of SMTP servers. Any server with debug mode turned on should show "On" styled as a yellow badge with black text. A server set as default should show "Default" styled as a green badge with white text. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174474|0 |1 is obsolete| | --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174938&action=edit Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|dcook@prosentient.com.au |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This took a while, happy to push. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement improves |This enhancement improves release notes|the SMTP servers |the SMTP servers |administration page. |administration page. | | |It |It |adds an information section |reformats the information |to the top of the page with |section at the top of the |the details the current |page with the current |default SMTP server's |default SMTP server |details and an edit link |detailsand adds an edit |(there can only be one |link. |active SMTP server at a | |time). |For the table | |listing all the SMTP |For the table |servers: |listing all the SMTP |- "Is default" |servers: |column: if the server is |- "Is default" |the default, it is |column: if the server is |highlighted with a green |the default, it is |badge and "Default" in bold |highlighted with a green |(the row is no longer in |badge and "Default" in bold |red and italicised, |(the row is no longer in |implying action is required |red and italicised). |to fix something). |- |- "Debug |"Debug mode" column: if the |mode" column: if the server |server is in debug mode, it |is in debug mode, it is |is highlighted with a |highlighted with a yellow |yellow badge and "On" in |badge and "On" in bold. |bold. | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37311 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement improves |This enhancement improves release notes|the SMTP servers |the SMTP servers |administration page. |administration page. | | |It reformats the |It reformats the |information section at the |information section at the |top of the page with the |top of the page with the |current default SMTP server |current default SMTP server |detailsand adds an edit |details and adds an edit |link. |link. | | |For the table listing all |For the table listing all |the SMTP servers: |the SMTP servers: |- "Is default" column: if |- "Is default" column: if |the server is the default, |the server is the default, |it is highlighted with a |it is highlighted with a |green badge and "Default" |green badge and "Default" |in bold (the row is no |in bold (the row is no |longer in red and |longer in red and |italicised, implying action |italicised, implying action |is required to fix |is required to fix |something). |something). |- "Debug mode" column: if |- "Debug mode" column: if |the server is in debug |the server is in debug |mode, it is highlighted |mode, it is highlighted |with a yellow badge and |with a yellow badge and |"On" in bold. |"On" in bold. -- You are receiving this mail because: You are watching all bug changes.