[Bug 15289] New: "borrowers" permission doesn't allow to see current loans
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Bug ID: 15289 Summary: "borrowers" permission doesn't allow to see current loans Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Permission "borrowers" gives an access to the Details page of a patron. But, in our previous version, we can see the list of the document checkout in this page. Now, we just have the information 'loading' in the checkout tables, but we can't see documents on loan. We should have an access to list of the loan, even without the "circulate" permission, to be able to inform patrons about the books they have, tell them the due date... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Indeed, the file svc/checkouts contains : my ( $auth_status, $sessionID ) = check_cookie_auth( $input->cookie('CGISESSID'), { circulate => 'circulate_remaining_permissions' } ); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Maybe it should depend on which page calls the code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's not obvious which permission should be required to see the checkout list. Katrin and Nicole, will you agree that a user with only the borrowers permission could access to this list? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hi, "borrowers" permission is required to deal with information related to patrons and it seems that it's the only one for this purpose. It's really difficult to imagine that staff who deal with borrowers in the library won't be able to know if patrons have loans, how many and what is the return date, even if they don't have the permission to do circulation action. Until the 3.16 version, it was the case : we can have the loans table in the details page of a patron for staff who have borrowers permission without circulate permission. Sonia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have just tested on a 3.14 and... it was quite buggy :) Without the circulate permission, indeed I can see the checkout list, but I also see the checkin checkboxes, the checkout tab, etc. And if I click on them, I am redirected to the login page :) The description of the borrower permission is "Add or modify patrons". That's why I would prefer to wait for an answer from Nicole and/or Katrin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Ah yes.. in 3.14, I found logical to be redirected to the login page when you check checkin or renew checkbox as you need to login with another user having the circulate permission to use it. Perhaps I just got used to this behaviour. I'm sure that we can have a better behaviour which also permit to see the loans only with borrowers permission in the current version :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is kind of a tricky question, because there is something like a 'grey area' between circulate and borrowers permissions. If we assume: borrowers - add borrowers - modify borrowers - delete borrowers circulate - check-out - check-in - renew It's not really clear, what the correct permission for "seeing patron information" or "seeing checkouts and holds" really is. I guess ideally there would be an option to circulate books for a borrower, without seeing any patron information, just by scanning the cardnumber and checking out. - but currently that's not really possible. I think "borrowers" for seeing the holds and checkouts is a bit of a stretch, but it seems like it was like that before, so it would be ok. I think it would be a nice change to hide the checkboxes if you don't have "circulate" - would that be possible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45699&action=edit Bug 15289 - borrowers permission allows to see patron's loans Test plan: - log with a user that have "borrowers" permission but not "Remaining circulation permissions" - go to a borrower's detail page (who has at least a loan) and click on "show checkouts" - check that you see loan(s) and that you can't renew and checkin - Do the same with a borrower that have "Remaining circulation permissions" - check that you see loan(s) and that you can renew and checkin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45699|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 45720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45720&action=edit Bug 15289 - borrowers permission allows to see patron's loans Test plan: - log with a user that have "borrowers" permission but not "Remaining circulation permissions" - go to a borrower's detail page (who has at least a loan) and click on "show checkouts" - check that you see loan(s) and that you can't renew and checkin - Do the same with a borrower that have "Remaining circulation permissions" - check that you see loan(s) and that you can renew and checkin Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45720|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45850&action=edit Bug 15289 - borrowers permission allows to see patron's loans Test plan: - log with a user that have "borrowers" permission but not "Remaining circulation permissions" - go to a borrower's detail page (who has at least a loan) and click on "show checkouts" - check that you see loan(s) and that you can't renew and checkin - Do the same with a borrower that have "Remaining circulation permissions" - check that you see loan(s) and that you can renew and checkin Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45851&action=edit Bug 15289 [QA Followup] - Fix minor language issue Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45850|0 |1 is obsolete| | --- Comment #12 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46058&action=edit Bug 15289 - borrowers permission allows to see patron's loans Test plan: - log with a user that have "borrowers" permission but not "Remaining circulation permissions" - go to a borrower's detail page (who has at least a loan) and click on "show checkouts" - check that you see loan(s) and that you can't renew and checkin - Do the same with a borrower that have "Remaining circulation permissions" - check that you see loan(s) and that you can renew and checkin Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45851|0 |1 is obsolete| | --- Comment #13 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46059&action=edit Bug 15289 [QA Followup] - Fix minor language issue Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #14 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15442 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15442 [Bug 15442] Checkouts table will not display due to javascript error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org