[Bug 29046] New: Allow libraries to specify email order for "AutoEmailPrimaryAddress"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Bug ID: 29046 Summary: Allow libraries to specify email order for "AutoEmailPrimaryAddress" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com At the moment, Koha::Patron->first_valid_email_address is hard-coded to go "email", "emailpro", and then "B_email". Libraries should be able to specify their own preference (at least since historically email was "Home" and emailpro was "Work" and many non-public library Koha databases would rather privilege emailpro over email). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148054&action=edit Bug 29046: Add 'EmailFieldPrecidence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148055&action=edit Bug 29046: Use EmailFieldPrecidence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecidence preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148054|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148056&action=edit Bug 29046: Add 'EmailFieldPrecidence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148057&action=edit Bug 29046: Use EmailFieldPrecedence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecedence preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148055|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18398 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33191 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33191 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148056|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148145&action=edit Bug 29046: Add 'EmailFieldPrecidence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148057|0 |1 is obsolete| | --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148146&action=edit Bug 29046: Use EmailFieldPrecedence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecedence preference. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148147&action=edit Bug 29046: Change link in EmailFieldPrecedence and add link in EmailFieldPrimary This patch modifies the link in EmailFieldPrecedence to reflect the new name of EmailFieldPrimary. It also adds a note in the latter to set the 'first valid' order in the former. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrecedence 3. Click on the link in the description --> It should lead to EmailFieldPrimary 4. Read the note in EmailFieldPrimary, make sure the grammar and spelling are correct. 5. Click the link to EmailFieldPrecedence --> It should lead to EmailFieldPrecedence -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tested the new syspref and it works. 1. Add primary, secondary and alternate email addresses in a patron's account - Primary email = primary@... - Secondary email = secondary@... - Email, under Alternate address = alternate@... 2. Set EmailFieldPrimary to first valid 3. In the patron's account click More > Send welcome email 4. Check the message_queue, the to_address should be primary@... select to_address, message_transport_type, letter_code, time_queued from message_queue where date(time_queued) = curdate(); 5. Set EmailFieldPrecedence to emailpro|B_email|email 6. Repeat steps 3 and 4, the to_address should be secondary@... 7. Set EmailFieldPrecedence to B_email|email|emailpro 8. Repeat steps 3 and 4, the to_address should be alternate@... 9. Set EmailFieldPrecedence to email|emailpro|B_email 10. Remove the primary email from the patron's account 14. Repeat steps 3 and 4, the to_address should be secondary@... 15. Remove the secondary email from the patron's account 16. Repeat steps 3 and 4, the to_address should be alternate@... Try other orders in EmailFieldPrecedence and removing the emails in a different order. I added a link from EmailFieldPrimary to the new syspref and changed the link to reflect the changes in the dependant bug 33192... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a new release notes| |system preference | |EmailFieldPrecedence, which | |allows libraries to set the | |order in which patron email | |addresses are used when | |selecting "first valid" in | |EmailFieldPrimary (formerly | |AutoEmailPrimaryAddress). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148147|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148155&action=edit Bug 29046: Change link in EmailFieldPrecedence and add link in EmailFieldPrimary This patch modifies the link in EmailFieldPrecedence to reflect the new name of EmailFieldPrimary. It also adds a note in the latter to set the 'first valid' order in the former. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrecedence 3. Click on the link in the description --> It should lead to EmailFieldPrimary 4. Read the note in EmailFieldPrimary, make sure the grammar and spelling are correct. 5. Click the link to EmailFieldPrecedence --> It should lead to EmailFieldPrecedence Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the follow-up Caroline, looks great. Signing off on that bit and updating the bug status :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Overall this looks good, but we got one blocker: 1) Unit tests are missing. 2) I wonder if we could simplify the system preference description a little: Use the following patron email fields in order of highest precedence first [email|emailpro|B_email] when selecting which email address to use to send patron notices. 2 things: * I think we should list the valid options in the system preference so that when one was deleted, it can be restored more easily. * I have no idea how to translate highest precedence... but what it means is that the first field with an email address will be used, right? Maybe we could phrase it along the lines of: When EmailFieldPrimary is set to 'first valid', check the patron email address fields in the following order and use the first valid email address found: * Not blocker: For languages we can sort the entries with drag&drop. Could this be a possible option here? Or maybe I could file as a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148145|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149385&action=edit Bug 29046: Add 'EmailFieldPrecedence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148146|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149386&action=edit Bug 29046: Use EmailFieldPrecedence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecedence preference. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148155|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149387&action=edit Bug 29046: Change link in EmailFieldPrecedence and add link in EmailFieldPrimary This patch modifies the link in EmailFieldPrecedence to reflect the new name of EmailFieldPrimary. It also adds a note in the latter to set the 'first valid' order in the former. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrecedence 3. Click on the link in the description --> It should lead to EmailFieldPrimary 4. Read the note in EmailFieldPrimary, make sure the grammar and spelling are correct. 5. Click the link to EmailFieldPrecedence --> It should lead to EmailFieldPrecedence Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149385|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149959&action=edit Bug 29046: Add 'EmailFieldPrecedence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149386|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149960&action=edit Bug 29046: Use EmailFieldPrecedence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecedence preference. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149387|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149961&action=edit Bug 29046: Change link in EmailFieldPrecedence and add link in EmailFieldPrimary This patch modifies the link in EmailFieldPrecedence to reflect the new name of EmailFieldPrimary. It also adds a note in the latter to set the 'first valid' order in the former. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrecedence 3. Click on the link in the description --> It should lead to EmailFieldPrimary 4. Read the note in EmailFieldPrimary, make sure the grammar and spelling are correct. 5. Click the link to EmailFieldPrecedence --> It should lead to EmailFieldPrecedence Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149962&action=edit Bug 29046: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149963&action=edit Bug 29046: Reword system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #11)
Overall this looks good, but we got one blocker:
1) Unit tests are missing.
Done
2) I wonder if we could simplify the system preference description a little:
Use the following patron email fields in order of highest precedence first [email|emailpro|B_email] when selecting which email address to use to send patron notices.
2 things: * I think we should list the valid options in the system preference so that when one was deleted, it can be restored more easily.
* I have no idea how to translate highest precedence... but what it means is that the first field with an email address will be used, right? Maybe we could phrase it along the lines of:
When EmailFieldPrimary is set to 'first valid', check the patron email address fields in the following order and use the first valid email address found:
Done
* Not blocker: For languages we can sort the entries with drag&drop. Could this be a possible option here? Or maybe I could file as a separate bug?
Please do this on another bug... this was meant as a starting point.. I don't have time to polish it any further I'm afraid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33592 [Bug 33592] Use drag&drop or sorting options for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
* Not blocker: For languages we can sort the entries with drag&drop. Could this be a possible option here? Or maybe I could file as a separate bug?
Please do this on another bug... this was meant as a starting point.. I don't have time to polish it any further I'm afraid.
Specifically marked it as 'not blocker' just wanted to get your opinion. I am still not sure if you like the idea, but filed separately now: bug 33592 I have tests failing with this patch set applied that pass without it :( prove t/db_dependent/Koha/Patron.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patron.t ... 10/23 Use of uninitialized value in split at /kohadevbox/koha/Koha/Patron.pm line 1440. Use of uninitialized value in split at /kohadevbox/koha/Koha/Patron.pm line 1440. t/db_dependent/Koha/Patron.t ... 13/23 WARNING: The key derivation method "opensslv1" is deprecated. Using -pbkdf=>'pbkdf2' would be better. Pass -nodeprecate=>1 to inhibit this message. at /kohadevbox/koha/Koha/Patron.pm line 2423. t/db_dependent/Koha/Patron.t ... ok t/db_dependent/Koha/Patrons.t .. 31/43 Use of uninitialized value in split at /kohadevbox/koha/Koha/Patron.pm line 1440. t/db_dependent/Koha/Patrons.t .. 32/43 Use of uninitialized value in split at /kohadevbox/koha/Koha/Patron.pm line 1440. # Failed test 'One notice queued when NotifyPasswordChange enabled' # at t/db_dependent/Koha/Patrons.t line 1972. # got: '0' # expected: '1' # Looks like you planned 16 tests but ran 15. # Looks like you failed 1 test of 15 run. # Failed test '->set_password' # at t/db_dependent/Koha/Patrons.t line 1976. Can't call method "status" on an undefined value at t/db_dependent/Koha/Patrons.t line 1974. # Looks like your test exited with 11 just after 33. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 11/43 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 2816 Tests: 33 Failed: 1) Failed test: 33 Non-zero exit status: 11 Parse errors: Bad plan. You planned 43 tests but ran 33. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My fault - it works now after running the database update :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149959|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150124&action=edit Bug 29046: Add 'EmailFieldPrecedence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149960|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150125&action=edit Bug 29046: Use EmailFieldPrecedence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecedence preference. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149961|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150126&action=edit Bug 29046: Change link in EmailFieldPrecedence and add link in EmailFieldPrimary This patch modifies the link in EmailFieldPrecedence to reflect the new name of EmailFieldPrimary. It also adds a note in the latter to set the 'first valid' order in the former. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrecedence 3. Click on the link in the description --> It should lead to EmailFieldPrimary 4. Read the note in EmailFieldPrimary, make sure the grammar and spelling are correct. 5. Click the link to EmailFieldPrecedence --> It should lead to EmailFieldPrecedence Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149962|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150127&action=edit Bug 29046: Unit tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149963|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150128&action=edit Bug 29046: Reword system preference. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150129&action=edit Bug 29046: Fix and amend system preference description The first line would not show in the system preference editor due to missing quotes. Also added information on the option names, link to the schema and an example. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- I am so excited for this one to get in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 150125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150125 Bug 29046: Use EmailFieldPrecedence in first_valid_email_address Review of attachment 150125: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29046&attachment=150125) ----------------------------------------------------------------- ::: Koha/Patron.pm @@ +1439,5 @@
+ + my @fields = split /\s*\|\s*/, + C4::Context->preference('EmailFieldPrecedence'); + for my $field (@fields) { + $email = $self->$field;
You could crash Koha by putting junk into EmailFieldPrecedence. I think either @fields should be validated or $self->$field should be validated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #31 from David Cook <dcook@prosentient.com.au> --- Despite my above comment, I think this should go ahead. It's a valuable contribution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Bug 29046 depends on bug 33192, which changed state. Bug 33192 Summary: We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a new |**Sponsored by** *PTFS release notes|system preference |Europe* |EmailFieldPrecedence, which | |allows libraries to set the |This enhancement |order in which patron email |adds a new system |addresses are used when |preference |selecting "first valid" in |EmailFieldPrecedence, which |EmailFieldPrimary (formerly |allows libraries to set the |AutoEmailPrimaryAddress). |order in which patron email | |addresses are used when | |selecting "first valid" in | |EmailFieldPrimary (formerly | |AutoEmailPrimaryAddress). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/692 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 30665 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 [Bug 34280] Patrons with no email address produce a warning when saving -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37216 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37216 [Bug 37216] Fix dbrev for EmailFieldSelection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37216 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37216 [Bug 37216] Fix dbrev for EmailFieldSelection -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org