[Bug 36096] New: Add ability to select default sort and display length for tables on waitingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Bug ID: 36096 Summary: Add ability to select default sort and display length for tables on waitingreserves.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com There are 3 tables on waitingreserves.pl. ( holdscr | holdso | holdst ) It would be nice if we could set the default sort and display length via Table settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162159&action=edit Bug 36096: Add ability to set default sort and length to waitingreserves tables To test: 1. APPLY patch and restart services. 2. Have waiting holds, waiting holds past the expiration date, and waiting holds with cancellation requests. 3. Go to Administration -> Table settings and find each of the tables. ( holdscr | holdso | holdst ) 4. Each table should now include a 'Default display length:' and 'Default sort order:' 5. Play with those Table settings, ensuring they behave correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Status|Needs Signoff |Failed QA --- Comment #2 from Philip Orr <philip.orr@lmscloud.de> --- The buttons are there, but when I changed the default sort order for "holdscr" to "title", saving did nothing - it just jumped back to the default "waiting_since". Same for "holdso" and "holdst". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Philip Orr from comment #2)
The buttons are there, but when I changed the default sort order for "holdscr" to "title", saving did nothing - it just jumped back to the default "waiting_since". Same for "holdso" and "holdst".
Thanks Philip! It looks like we have a bug with setting the default sort and display length. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36592 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36592 [Bug 36592] Cannot save Default display length or Default sort order in Table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36592 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36592 [Bug 36592] Cannot save Default display length or Default sort order in Table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36592 [Bug 36592] Cannot save Default display length or Default sort order in Table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162159|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164850&action=edit Bug 36096: Add ability to set default sort and length to waitingreserves tables To test: 1. APPLY patch and restart services. 2. Have waiting holds, waiting holds past the expiration date, and waiting holds with cancellation requests. 3. Go to Administration -> Table settings and find each of the tables. ( holdscr | holdso | holdst ) 4. Each table should now include a 'Default display length:' and 'Default sort order:' 5. Play with those Table settings, ensuring they behave correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164850|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166627&action=edit Bug 36096: Add ability to set default sort and length to waitingreserves tables To test: 1. APPLY patch and restart services. 2. Have waiting holds, waiting holds past the expiration date, and waiting holds with cancellation requests. 3. Go to Administration -> Table settings and find each of the tables. ( holdscr | holdso | holdst ) 4. Each table should now include a 'Default display length:' and 'Default sort order:' 5. Play with those Table settings, ensuring they behave correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial improvement, no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please double check - I changed the default from 20 to 50 on the holds waiting for pickup table and it remains preselected at 20. Same for updated sorting, it sticks with waiting date. Looking at the first tab of the pickup report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
Please double check - I changed the default from 20 to 50 on the holds waiting for pickup table and it remains preselected at 20. Same for updated sorting, it sticks with waiting date.
Looking at the first tab of the pickup report.
I can't recreate this. Are you picking the right tables in Table settings? holdscr - Holds with cancellation requests holdso - Holds over... holdst - Holds awaiting pickup These table ID's do cause a bit of confusion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Indeed.. it's working for me too.. though you did have me questioning myself.. I thought it might be a disparity between 'GetColumns' and 'GetTableSettings'.. but it is indeed the later consistently already for these tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll double check as soon as I can. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I will admit... pushing this and trusting you guys. Please don't disappoint :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to select |Add ability to select |default sort and display |default sort and display |length for tables on |length for tables on 'Holds |waitingreserves.pl |awaiting pickup' page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36592 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36096 Bug 36096 depends on bug 36592, which changed state. Bug 36592 Summary: Cannot save default display length or default sort order in table settings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36592 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org